Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35180

transformToJSX handles Path string wrong on windows

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Trivial Trivial
    • js-builder
    • None

      When building blueocean on windows the build breaks with

      [INFO] [13:01:55] Browserify bundle processing error
      [INFO] [13:01:55] 	error: Error: Cannot find module '..srcmainjs/AdminNavLink.jsx' from 'C:\Develop\blueocean\blueocean-dashboard\target'
      [ERROR] 
      [ERROR] C:\Develop\blueocean\blueocean-dashboard\node_modules\@jenkins-cd\js-builder\index.js:555
      [ERROR]                         throw 'Browserify bundle processing error. See above for details.';
      

      the cause is the path writen to jenkins-js-extension.jsx the \ is not escaped correctly
      changing

      var relPath = path.relative(targetRoot, srcRoot);
      

      to

      var relPath = path.relative(targetRoot, srcRoot).split("\\").join("\\\\");
      

      solves the problem for me (in @jenkins-cd\subs\extensions-bundle.js)

          [JENKINS-35180] transformToJSX handles Path string wrong on windows

          Thomas Kalmár created issue -
          Tom FENNELLY made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 171403 ] New: JNJira + In-Review [ 199094 ]

            tfennelly Tom FENNELLY
            thomas_kalmar Thomas Kalmár
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: