There are several problems with the way ping threads are set up.

      • ChannelPinger sets up a master → agent ping, and also an agent → master ping. But Launcher sets up another slave → master ping for JNLP agents (not for master-initiated ones)...and is more awkward to disable, since you must pass a system property to each agent's launch line.
      • As noted here, the agent → master ping from ChannelPinger does not work at all, due to a mistake in usage of PingFailureAnalyzer. (Oddly, kohsuke introduced this extension point claiming it could be implemented in ssh-slaves, but apparently never did so there, or anywhere else!)
      • The Launcher variant fails to override the nondeprecated onDead variant that gets a stack trace.

          [JENKINS-35190] Improper PingThread handling

          Jesse Glick created issue -
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Jesse Glick made changes -
          Remote Link New: This issue links to "remoting PR 85 (Web Link)" [ 14349 ]
          Jesse Glick made changes -
          Remote Link New: This issue links to "core PR 2377 (Web Link)" [ 14350 ]
          Jesse Glick made changes -
          Link New: This issue is duplicated by JENKINS-34887 [ JENKINS-34887 ]
          Oleg Nenashev made changes -
          Assignee Original: Jesse Glick [ jglick ] New: Oleg Nenashev [ oleg_nenashev ]
          Jesse Glick made changes -
          Remote Link New: This issue links to "core PR 2403 (Web Link)" [ 14444 ]
          Oleg Nenashev made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
          Oliver Gondža made changes -
          Labels Original: remoting New: 2.7.2-fixed remoting
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 171413 ] New: JNJira + In-Review [ 199096 ]
          CloudBees Inc. made changes -
          Remote Link New: This issue links to "CloudBees Internal OSS-1013 (Web Link)" [ 18786 ]

            oleg_nenashev Oleg Nenashev
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: