[JENKINS-35247] Move git/svn steps out of workflow-scm-steps

Type: Bug
Resolution: Fixed
Priority: Major
Component/s: git-plugin, pipeline, subversion-plugin
Labels:
None

Similar Issues:
Powered by SuggestiMate

Show

aheritier pointed out that when installing recommended plugins in Jenkins 2, sometimes the git step does not work in Pipeline builds until after a restart. This is because when workflow-scm-step is loaded, git might not yet be installed, so GitStep.DescriptorImpl would be skipped. If later in the same session git is installed, this extension is not revisited.

Simpler to keep the SCM-specific steps in the corresponding plugins.

is blocked by

JENKINS-36666 Jenkins startup fails due to cyclic dependency miscalculation

Resolved

is duplicated by

JENKINS-35609 GitStep is missing its descriptor with example build

Resolved

is related to

JENKINS-19508 Replace @Extension(optional=true) and optional dependencies with bridge plugins

Open

JENKINS-36239 StackOverflowError in plugin manager on 1.596.1

Open

links to

workflow-scm-step PR 2

SCM/JIRA link daemon added a comment - 2016-06-01 15:15

Code changed in jenkins
User: Jesse Glick
Path:
scm-step/pom.xml
scm-step/src/main/java/org/jenkinsci/plugins/workflow/steps/scm/GitStep.java
scm-step/src/main/java/org/jenkinsci/plugins/workflow/steps/scm/SubversionStep.java
http://jenkins-ci.org/commit/pipeline-plugin/fd7d4eb54c59aeb3bab396a45cfdbd93dceb6ae0
Log:
~~JENKINS-35247~~ Delegate to Git and Subversion plugins via reflection.
(cherry picked from commit 87113cfdc9e4939b123de673a5672ac6b3fb76fc)

SCM/JIRA link daemon added a comment - 2016-06-01 15:15 Code changed in jenkins User: Jesse Glick Path: scm-step/pom.xml scm-step/src/main/java/org/jenkinsci/plugins/workflow/steps/scm/GitStep.java scm-step/src/main/java/org/jenkinsci/plugins/workflow/steps/scm/SubversionStep.java http://jenkins-ci.org/commit/pipeline-plugin/fd7d4eb54c59aeb3bab396a45cfdbd93dceb6ae0 Log: JENKINS-35247 Delegate to Git and Subversion plugins via reflection. (cherry picked from commit 87113cfdc9e4939b123de673a5672ac6b3fb76fc)

SCM/JIRA link daemon added a comment - 2016-06-01 15:15

Code changed in jenkins
User: Jesse Glick
Path:
aggregator/pom.xml
aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowTest.java
aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/scm/MercurialStepTest.java
api/pom.xml
basic-steps/pom.xml
cps-global-lib/pom.xml
cps/pom.xml
durable-task-step/pom.xml
job/pom.xml
pom.xml
scm-step/pom.xml
scm-step/src/main/java/org/jenkinsci/plugins/workflow/steps/scm/GitStep.java
scm-step/src/main/java/org/jenkinsci/plugins/workflow/steps/scm/SubversionStep.java
step-api/pom.xml
support/pom.xml
http://jenkins-ci.org/commit/pipeline-plugin/8a10c799995843ce466ecc792ea9b1cd1181e461
Log:
Merge pull request #390 from jglick/SCMStep-~~JENKINS-35247~~-1.4.x

~~JENKINS-35247~~ Delegate to Git and Subversion plugins via reflection (1.4.x)

Compare: https://github.com/jenkinsci/pipeline-plugin/compare/141f26962bcc...8a10c7999958

SCM/JIRA link daemon added a comment - 2016-06-01 15:15 Code changed in jenkins User: Jesse Glick Path: aggregator/pom.xml aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/scm/MercurialStepTest.java api/pom.xml basic-steps/pom.xml cps-global-lib/pom.xml cps/pom.xml durable-task-step/pom.xml job/pom.xml pom.xml scm-step/pom.xml scm-step/src/main/java/org/jenkinsci/plugins/workflow/steps/scm/GitStep.java scm-step/src/main/java/org/jenkinsci/plugins/workflow/steps/scm/SubversionStep.java step-api/pom.xml support/pom.xml http://jenkins-ci.org/commit/pipeline-plugin/8a10c799995843ce466ecc792ea9b1cd1181e461 Log: Merge pull request #390 from jglick/SCMStep- JENKINS-35247 -1.4.x JENKINS-35247 Delegate to Git and Subversion plugins via reflection (1.4.x) Compare: https://github.com/jenkinsci/pipeline-plugin/compare/141f26962bcc...8a10c7999958

SCM/JIRA link daemon added a comment - 2016-06-01 15:47

Code changed in jenkins
User: Jesse Glick
Path:
scm-step/pom.xml
scm-step/src/main/java/org/jenkinsci/plugins/workflow/steps/scm/GitStep.java
scm-step/src/main/java/org/jenkinsci/plugins/workflow/steps/scm/SubversionStep.java
http://jenkins-ci.org/commit/pipeline-plugin/87113cfdc9e4939b123de673a5672ac6b3fb76fc
Log:
~~JENKINS-35247~~ Delegate to Git and Subversion plugins via reflection.

SCM/JIRA link daemon added a comment - 2016-06-01 15:47 Code changed in jenkins User: Jesse Glick Path: scm-step/pom.xml scm-step/src/main/java/org/jenkinsci/plugins/workflow/steps/scm/GitStep.java scm-step/src/main/java/org/jenkinsci/plugins/workflow/steps/scm/SubversionStep.java http://jenkins-ci.org/commit/pipeline-plugin/87113cfdc9e4939b123de673a5672ac6b3fb76fc Log: JENKINS-35247 Delegate to Git and Subversion plugins via reflection.

SCM/JIRA link daemon added a comment - 2016-06-01 15:47

Code changed in jenkins
User: Jesse Glick
Path:
scm-step/pom.xml
scm-step/src/main/java/org/jenkinsci/plugins/workflow/steps/scm/GitStep.java
scm-step/src/main/java/org/jenkinsci/plugins/workflow/steps/scm/SubversionStep.java
http://jenkins-ci.org/commit/pipeline-plugin/524b5fb35b7272df64e230c8af5a40dd25770c90
Log:
Merge pull request #389 from jglick/SCMStep-~~JENKINS-35247~~-1.14.x

~~JENKINS-35247~~ Delegate to Git and Subversion plugins via reflection (1.14.x)

Compare: https://github.com/jenkinsci/pipeline-plugin/compare/46945b6ce555...524b5fb35b72

SCM/JIRA link daemon added a comment - 2016-06-01 15:47 Code changed in jenkins User: Jesse Glick Path: scm-step/pom.xml scm-step/src/main/java/org/jenkinsci/plugins/workflow/steps/scm/GitStep.java scm-step/src/main/java/org/jenkinsci/plugins/workflow/steps/scm/SubversionStep.java http://jenkins-ci.org/commit/pipeline-plugin/524b5fb35b7272df64e230c8af5a40dd25770c90 Log: Merge pull request #389 from jglick/SCMStep- JENKINS-35247 -1.14.x JENKINS-35247 Delegate to Git and Subversion plugins via reflection (1.14.x) Compare: https://github.com/jenkinsci/pipeline-plugin/compare/46945b6ce555...524b5fb35b72

SCM/JIRA link daemon added a comment - 2016-06-01 16:24

Code changed in jenkins
User: Jesse Glick
Path:
CHANGES.md
http://jenkins-ci.org/commit/pipeline-plugin/8c13adbd32bdf5474b3134a7b21e5eceb7815db3
Log:
~~JENKINS-35247~~ Noting.

SCM/JIRA link daemon added a comment - 2016-06-01 16:24 Code changed in jenkins User: Jesse Glick Path: CHANGES.md http://jenkins-ci.org/commit/pipeline-plugin/8c13adbd32bdf5474b3134a7b21e5eceb7815db3 Log: JENKINS-35247 Noting.

SCM/JIRA link daemon added a comment - 2016-06-09 16:18

Code changed in jenkins
User: Jesse Glick
Path:
pom.xml
src/main/java/org/jenkinsci/plugins/workflow/steps/scm/GitStep.java
src/main/java/org/jenkinsci/plugins/workflow/steps/scm/SubversionStep.java
http://jenkins-ci.org/commit/workflow-scm-step-plugin/ff3e0b937a5ff9e62754af2080bef89bd0b82aab
Log:
~~JENKINS-35247~~ Delegate to Git and Subversion plugins via reflection.

SCM/JIRA link daemon added a comment - 2016-06-09 16:18 Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/steps/scm/GitStep.java src/main/java/org/jenkinsci/plugins/workflow/steps/scm/SubversionStep.java http://jenkins-ci.org/commit/workflow-scm-step-plugin/ff3e0b937a5ff9e62754af2080bef89bd0b82aab Log: JENKINS-35247 Delegate to Git and Subversion plugins via reflection.

SCM/JIRA link daemon added a comment - 2016-06-09 16:18

Code changed in jenkins
User: Jesse Glick
Path:
pom.xml
src/main/java/org/jenkinsci/plugins/workflow/steps/scm/GitStep.java
src/main/java/org/jenkinsci/plugins/workflow/steps/scm/SubversionStep.java
http://jenkins-ci.org/commit/workflow-scm-step-plugin/58237d3ca4f72fa102234910018286d9898cfcc4
Log:
Merge pull request #3 from jglick/SCMStep-~~JENKINS-35247~~-reflection

~~JENKINS-35247~~ Delegate to Git and Subversion plugins via reflection

Compare: https://github.com/jenkinsci/workflow-scm-step-plugin/compare/edc5c6262d9f...58237d3ca4f7

SCM/JIRA link daemon added a comment - 2016-06-09 16:18 Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/steps/scm/GitStep.java src/main/java/org/jenkinsci/plugins/workflow/steps/scm/SubversionStep.java http://jenkins-ci.org/commit/workflow-scm-step-plugin/58237d3ca4f72fa102234910018286d9898cfcc4 Log: Merge pull request #3 from jglick/SCMStep- JENKINS-35247 -reflection JENKINS-35247 Delegate to Git and Subversion plugins via reflection Compare: https://github.com/jenkinsci/workflow-scm-step-plugin/compare/edc5c6262d9f...58237d3ca4f7

SCM/JIRA link daemon added a comment - 2016-06-10 21:43

Code changed in jenkins
User: Jesse Glick
Path:
pom.xml
src/main/java/hudson/plugins/git/GitSCM.java
src/main/java/jenkins/plugins/git/GitStep.java
src/main/resources/jenkins/plugins/git/GitStep/config.jelly
src/main/resources/jenkins/plugins/git/GitStep/help.html
src/main/resources/jenkins/plugins/git/Messages.properties
src/test/java/jenkins/plugins/git/GitSampleRepoRule.java
src/test/java/jenkins/plugins/git/GitStepTest.java
http://jenkins-ci.org/commit/git-plugin/470a4ca0837e1af444423a156e20115f58ae9124
Log:
~~JENKINS-35247~~ Moved GitStep to git-plugin.

SCM/JIRA link daemon added a comment - 2016-06-10 21:43 Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/hudson/plugins/git/GitSCM.java src/main/java/jenkins/plugins/git/GitStep.java src/main/resources/jenkins/plugins/git/GitStep/config.jelly src/main/resources/jenkins/plugins/git/GitStep/help.html src/main/resources/jenkins/plugins/git/Messages.properties src/test/java/jenkins/plugins/git/GitSampleRepoRule.java src/test/java/jenkins/plugins/git/GitStepTest.java http://jenkins-ci.org/commit/git-plugin/470a4ca0837e1af444423a156e20115f58ae9124 Log: JENKINS-35247 Moved GitStep to git-plugin.

SCM/JIRA link daemon added a comment - 2016-06-10 21:43

Code changed in jenkins
User: Mark Waite
Path:
pom.xml
src/main/java/hudson/plugins/git/GitSCM.java
src/main/java/jenkins/plugins/git/GitStep.java
src/main/resources/jenkins/plugins/git/GitStep/config.jelly
src/main/resources/jenkins/plugins/git/GitStep/help.html
src/main/resources/jenkins/plugins/git/Messages.properties
src/test/java/jenkins/plugins/git/GitSampleRepoRule.java
src/test/java/jenkins/plugins/git/GitStepTest.java
http://jenkins-ci.org/commit/git-plugin/7e9edc7e448ed29e287171046ba2c859b41a1cd8
Log:
Merge pull request #406 from jglick/SCMStep-~~JENKINS-35247~~

~~JENKINS-35247~~ Moved GitStep to git-plugin

Compare: https://github.com/jenkinsci/git-plugin/compare/7a31858e61d2...7e9edc7e448e

SCM/JIRA link daemon added a comment - 2016-06-10 21:43 Code changed in jenkins User: Mark Waite Path: pom.xml src/main/java/hudson/plugins/git/GitSCM.java src/main/java/jenkins/plugins/git/GitStep.java src/main/resources/jenkins/plugins/git/GitStep/config.jelly src/main/resources/jenkins/plugins/git/GitStep/help.html src/main/resources/jenkins/plugins/git/Messages.properties src/test/java/jenkins/plugins/git/GitSampleRepoRule.java src/test/java/jenkins/plugins/git/GitStepTest.java http://jenkins-ci.org/commit/git-plugin/7e9edc7e448ed29e287171046ba2c859b41a1cd8 Log: Merge pull request #406 from jglick/SCMStep- JENKINS-35247 JENKINS-35247 Moved GitStep to git-plugin Compare: https://github.com/jenkinsci/git-plugin/compare/7a31858e61d2...7e9edc7e448e

Mark Waite added a comment - 2016-07-02 00:03

Included in git plugin 2.5.0 released 19 Jun 2016

Mark Waite added a comment - 2016-07-02 00:03 Included in git plugin 2.5.0 released 19 Jun 2016

Arnaud Héritier added a comment - 2016-07-02 16:23

cool. Thanks guys

Arnaud Héritier added a comment - 2016-07-02 16:23 cool. Thanks guys

Assignee:: Jesse Glick

Reporter:: Jesse Glick

Votes:: 2 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 2016-05-31 22:06

Updated:: 2019-10-23 01:28

Resolved:: 2016-07-02 00:03

Jenkins

Details

Description

Attachments

Issue Links

Activity

Collapse comment: SCM/JIRA link daemon added a comment - 2016-06-01 15:15

Expand comment: SCM/JIRA link daemon added a comment - 2016-06-01 15:15

Collapse comment: SCM/JIRA link daemon added a comment - 2016-06-01 15:15

Expand comment: SCM/JIRA link daemon added a comment - 2016-06-01 15:15

Collapse comment: SCM/JIRA link daemon added a comment - 2016-06-01 15:47

Expand comment: SCM/JIRA link daemon added a comment - 2016-06-01 15:47

Collapse comment: SCM/JIRA link daemon added a comment - 2016-06-01 15:47

Expand comment: SCM/JIRA link daemon added a comment - 2016-06-01 15:47

Collapse comment: SCM/JIRA link daemon added a comment - 2016-06-01 16:24

Expand comment: SCM/JIRA link daemon added a comment - 2016-06-01 16:24

Collapse comment: SCM/JIRA link daemon added a comment - 2016-06-09 16:18

Expand comment: SCM/JIRA link daemon added a comment - 2016-06-09 16:18

Collapse comment: SCM/JIRA link daemon added a comment - 2016-06-09 16:18

Expand comment: SCM/JIRA link daemon added a comment - 2016-06-09 16:18

Collapse comment: SCM/JIRA link daemon added a comment - 2016-06-10 21:43

Expand comment: SCM/JIRA link daemon added a comment - 2016-06-10 21:43

Collapse comment: SCM/JIRA link daemon added a comment - 2016-06-10 21:43

Expand comment: SCM/JIRA link daemon added a comment - 2016-06-10 21:43

Collapse comment: Mark Waite added a comment - 2016-07-02 00:03

Expand comment: Mark Waite added a comment - 2016-07-02 00:03

Collapse comment: Arnaud Héritier added a comment - 2016-07-02 16:23

Expand comment: Arnaud Héritier added a comment - 2016-07-02 16:23

People

Dates