Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35451

Change name of "slave.jar" to "agent.jar"

    XMLWordPrintable

Details

    • Improvement
    • Status: Resolved (View Workflow)
    • Major
    • Resolution: Fixed
    • core
    • Jenkins 2.6

    Description

      Found when launching a jnlp agent from command line:
      "java -jar slave.jar -jnlpUrl ..."

      The name of this jar should match agreed naming guidelines.

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-43528 "slave.jar" should be "agent.jar"

          • Major - Major loss of function.
          • Resolved
          is related to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. JENKINS-31095 2.0: Jenkins terminology sweep

          • Major - Major loss of function.
          • Open

          Task - A task that needs to be done. JENKINS-35449 Review and document all remaining uses of the term "slave" in core

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-35452 Change Jnlp url from "slave-agent.jnlp" to "agent.jnlp"

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            View 4 older comments
            jamesdumay James Dumay added a comment -

            Surely we can do a hard redirect when someone is asking for /slave.jar?

            jamesdumay James Dumay added a comment - Surely we can do a hard redirect when someone is asking for /slave.jar?
            ndeloof Nicolas De Loof added a comment -

            see https://github.com/jenkinsci/jenkins/pull/3004 as a minimal backward compatible fix. slave.jar still supported to ensure no regression, but document use of agent.jar

            ndeloof Nicolas De Loof added a comment - see https://github.com/jenkinsci/jenkins/pull/3004  as a minimal backward compatible fix. slave.jar still supported to ensure no regression, but document use of agent.jar
            bitwiseman Liam Newman added a comment -

            ndeloof Thanks!

            bitwiseman Liam Newman added a comment - ndeloof Thanks!
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/java/hudson/FilePath.java
            core/src/main/java/hudson/Launcher.java
            core/src/main/java/hudson/model/Slave.java
            core/src/main/java/hudson/slaves/Channels.java
            core/src/main/java/hudson/slaves/CommandLauncher.java
            core/src/main/java/hudson/slaves/SlaveComputer.java
            core/src/main/resources/hudson/slaves/CommandLauncher/help-command.html
            core/src/main/resources/hudson/slaves/CommandLauncher/help-command_bg.html
            core/src/main/resources/hudson/slaves/CommandLauncher/help-command_fr.html
            core/src/main/resources/hudson/slaves/CommandLauncher/help-command_ja.html
            core/src/main/resources/hudson/slaves/CommandLauncher/help-command_ru.html
            core/src/main/resources/hudson/slaves/JNLPLauncher/main.jelly
            core/src/main/resources/windows-service/jenkins-slave.xml
            test/src/test/java/hudson/model/Slave2Test.java
            test/src/test/resources/hudson/model/update-center.json
            http://jenkins-ci.org/commit/jenkins/0a2d6ca2bad601c2ad80502e0f4de861e93c6f2c
            Log:
            Merge pull request #3004 from ndeloof/agent

            JENKINS-35451 - prefer ‘agent.jar’ over ‘slave.jar’

            Compare: https://github.com/jenkinsci/jenkins/compare/7f093d3dd786...0a2d6ca2bad6

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/FilePath.java core/src/main/java/hudson/Launcher.java core/src/main/java/hudson/model/Slave.java core/src/main/java/hudson/slaves/Channels.java core/src/main/java/hudson/slaves/CommandLauncher.java core/src/main/java/hudson/slaves/SlaveComputer.java core/src/main/resources/hudson/slaves/CommandLauncher/help-command.html core/src/main/resources/hudson/slaves/CommandLauncher/help-command_bg.html core/src/main/resources/hudson/slaves/CommandLauncher/help-command_fr.html core/src/main/resources/hudson/slaves/CommandLauncher/help-command_ja.html core/src/main/resources/hudson/slaves/CommandLauncher/help-command_ru.html core/src/main/resources/hudson/slaves/JNLPLauncher/main.jelly core/src/main/resources/windows-service/jenkins-slave.xml test/src/test/java/hudson/model/Slave2Test.java test/src/test/resources/hudson/model/update-center.json http://jenkins-ci.org/commit/jenkins/0a2d6ca2bad601c2ad80502e0f4de861e93c6f2c Log: Merge pull request #3004 from ndeloof/agent JENKINS-35451 - prefer ‘agent.jar’ over ‘slave.jar’ Compare: https://github.com/jenkinsci/jenkins/compare/7f093d3dd786...0a2d6ca2bad6
            danielbeck Daniel Beck added a comment -

            Fixed in 2.77.

            Someone reported this issue as a problem on the changelog. Please indicate in a comment what the encountered problem is, nor file a separate issue for that, and link it here and/or from the changelog. Thanks!

            danielbeck Daniel Beck added a comment - Fixed in 2.77. Someone reported this issue as a problem on the changelog. Please indicate in a comment what the encountered problem is, nor file a separate issue for that, and link it here and/or from the changelog. Thanks!

            People

              Unassigned Unassigned
              bitwiseman Liam Newman
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: