Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35490

JENKINS-27387 broke binding to credentials parameter for Freestyle jobs

    XMLWordPrintable

Details

    Description

      I cannot use a credentials parameter when adding a binding in a Freestyle job

      Attachments

        Issue Links

          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-37707 Saving SecretBuildWrapper for the first time fails due to duplicated credentialsId field unless git also installed

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-33742 Missing Specific credentials/Parameter expression option in Bindings definition

          • Major - Major loss of function.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-27387 NPE generating snippet for BindingStep

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            Ascending order - Click to sort in descending order
            stephenconnolly Stephen Connolly created issue -
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper/config.jelly
            http://jenkins-ci.org/commit/credentials-binding-plugin/5e2f3a81f8290044d7b2e25dad2d49570147a10a
            Log:
            [FIXED JENKINS-35490] Ensure the expressionAllowed variable is captured for the hetero-add

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper/config.jelly http://jenkins-ci.org/commit/credentials-binding-plugin/5e2f3a81f8290044d7b2e25dad2d49570147a10a Log: [FIXED JENKINS-35490] Ensure the expressionAllowed variable is captured for the hetero-add
            scm_issue_link SCM/JIRA link daemon made changes -
            Field Original Value New Value
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]
            stephenconnolly Stephen Connolly added a comment -

            So the issue here is that the expressionAllowed variable is not being captured in the closure for the hetero-add

            stephenconnolly Stephen Connolly added a comment - So the issue here is that the expressionAllowed variable is not being captured in the closure for the hetero-add
            stephenconnolly Stephen Connolly made changes -
            Assignee Jesse Glick [ jglick ] stephenconnolly [ stephenconnolly ]
            Resolution Fixed [ 1 ]
            Status Resolved [ 5 ] Reopened [ 4 ]
            stephenconnolly Stephen Connolly made changes -
            Status Reopened [ 4 ] In Progress [ 3 ]
            jglick Jesse Glick made changes -
            Link This issue is related to JENKINS-27387 [ JENKINS-27387 ]
            jglick Jesse Glick added a comment - - edited

            I am sure I tested this for both project types…did something regress here?

            jglick Jesse Glick added a comment - - edited I am sure I tested this for both project types…did something regress here?
            stephenconnolly Stephen Connolly added a comment -

            jglick it works if you load an existing job with an existing configuration... when you are configuring a new job from scratch is when it blows up.

            stephenconnolly Stephen Connolly added a comment - jglick it works if you load an existing job with an existing configuration... when you are configuring a new job from scratch is when it blows up.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper/config.jelly
            http://jenkins-ci.org/commit/credentials-binding-plugin/3262d165e7be227f7a5ae567723446188ccd26bd
            Log:
            Merge pull request #17 from jenkinsci/jenkins-35490

            [FIXED JENKINS-35490] Ensure the expressionAllowed variable is captured for the hetero-add

            Compare: https://github.com/jenkinsci/credentials-binding-plugin/compare/dfe5288c5aa0...3262d165e7be

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper/config.jelly http://jenkins-ci.org/commit/credentials-binding-plugin/3262d165e7be227f7a5ae567723446188ccd26bd Log: Merge pull request #17 from jenkinsci/jenkins-35490 [FIXED JENKINS-35490] Ensure the expressionAllowed variable is captured for the hetero-add Compare: https://github.com/jenkinsci/credentials-binding-plugin/compare/dfe5288c5aa0...3262d165e7be
            scm_issue_link SCM/JIRA link daemon made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Resolved [ 5 ]
            jglick Jesse Glick added a comment -

            Ah, because of the lazy-loaded block. Right, I must have forgotten to test that.

            jglick Jesse Glick added a comment - Ah, because of the lazy-loaded block. Right, I must have forgotten to test that.
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 171793 ] JNJira + In-Review [ 199163 ]
            jglick Jesse Glick made changes -
            Link This issue is blocked by JENKINS-37707 [ JENKINS-37707 ]
            jglick Jesse Glick made changes -
            Link This issue is duplicated by JENKINS-33742 [ JENKINS-33742 ]
            stephenconnolly Stephen Connolly made changes -
            Status Resolved [ 5 ] Closed [ 6 ]

            People

              stephenconnolly Stephen Connolly
              stephenconnolly Stephen Connolly
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: