-
Improvement
-
Resolution: Done
-
Minor
-
None
For improved test-ability and upgrades, upgrade the parent pom to the 2.x line. The jenkins.version might also be a candidate for upgrades since it's on a line that's old.
- links to
[JENKINS-35510] Migrate git-server-plugin to parent pom
Kristin Whetstone
created issue -
Kristin Whetstone
made changes -
| Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
Kristin Whetstone
added a comment - Created a pull request for this feature. I made upgrades where I could, though it wasn't too easy to test since there aren't any for this plugin.
The biggest issue in this upgrade was leaving the jenkins.version at 1.480 instead of upgrading to 1.580.1 to grab some security fixes. In between the two versions, a core class picked up a new interface requiring role checking. Since I'm not entirely sure where ChannelTransport runs (master or agent) and didn't have a good way of checking my choice, I just decided to leave it.
All feedback is welcome.
Kristin Whetstone
added a comment - Created a pull request for this feature. I made upgrades where I could, though it wasn't too easy to test since there aren't any for this plugin.
The biggest issue in this upgrade was leaving the jenkins.version at 1.480 instead of upgrading to 1.580.1 to grab some security fixes. In between the two versions, a core class picked up a new interface requiring role checking. Since I'm not entirely sure where ChannelTransport runs (master or agent) and didn't have a good way of checking my choice, I just decided to leave it.
All feedback is welcome. Kristin Whetstone
made changes -
| Remote Link | New: This issue links to "PR6 (Web Link)" [ 14439 ] |
| Remote Link | Original: This issue links to "PR6 (Web Link)" [ 14439 ] |
| Remote Link | New: This issue links to "PR-6 (Web Link)" [ 14574 ] |
| Resolution | New: Done [ 10000 ] | |
| Status | Original: In Progress [ 3 ] | New: Closed [ 6 ] |
| Workflow | Original: JNJira [ 171819 ] | New: JNJira + In-Review [ 210125 ] |
This plugin relies on an older version of Jenkins, 1.480. I've been testing migrating to 1.580.1 to grab SECURITY-144, but there are some fundamental changes between versions. Because this plugin has been pretty much functionally untouched since 2014 (findbugs and maven dependency bumps) and it's popularity is rising meteorically, it might be worth keeping the jenkins.version at 1.480.