Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35674

Pull requests not rebuilt when destination commit changes

    XMLWordPrintable

Details

    Description

      When there is a pull request from feature branch to master branch and someone else either commits something directly to master or merges another pull request, the pull request is not rebuilt - bitbucket-branch-source plugin only checks PR HEAD, but not its destination. PR should be rebuilt when either HEAD or DESTINATION changes.

      Attachments

        Issue Links

          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. JENKINS-45502 Add concept of "interesting" to SCMHead and SCMRevision

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open
          relates to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-37491 Build Origin PRs (merge with base branch) conducts rebuilds when baseline changes

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-42822 Github organisation PR -merge builds don't run if master updated

          • Major - Major loss of function.
          • Open

          Activity

            Ascending order - Click to sort in descending order
            dodoent Nenad Miksa created issue -
            rtyler R. Tyler Croy made changes -
            Field Original Value New Value
            Workflow JNJira [ 172028 ] JNJira + In-Review [ 184557 ]
            seanf Sean Flanigan added a comment -

            Note that this behaviour wouldn't work for everyone, because it can trigger build storms: JENKINS-37491.

            seanf Sean Flanigan added a comment - Note that this behaviour wouldn't work for everyone, because it can trigger build storms:  JENKINS-37491 .
            seanf Sean Flanigan made changes -
            Link This issue relates to JENKINS-37491 [ JENKINS-37491 ]
            jamesdumay James Dumay added a comment -

            stephenconnolly another ticket solved by traits?

            jamesdumay James Dumay added a comment - stephenconnolly another ticket solved by traits?
            stephenconnolly Stephen Connolly added a comment -

            jamesdumay nope this is probably something that falls into the "interesting" category. Some users would like to classify the destination changing as making all the PR-merge heads having an change interesting enough to trigger a corresponding build storm... though perhaps not as interesting as a change to the PR HEAD

            Other people do not want the build storm ever.

            Until JENKINS-45502 we probably cannot make either camp completely happy... right now you get the build storm with every periodic scan, but not with the event driven builds (because that at least lets both camps have some control through the frequency of scanning)

            stephenconnolly Stephen Connolly added a comment - jamesdumay nope this is probably something that falls into the "interesting" category. Some users would like to classify the destination changing as making all the PR-merge heads having an change interesting enough to trigger a corresponding build storm... though perhaps not as interesting as a change to the PR HEAD Other people do not want the build storm ever. Until JENKINS-45502  we probably cannot make either camp completely happy... right now you get the build storm with every periodic scan, but not with the event driven builds (because that at least lets both camps have some control through the frequency of scanning)
            stephenconnolly Stephen Connolly made changes -
            Link This issue is blocked by JENKINS-45502 [ JENKINS-45502 ]
            seanf Sean Flanigan made changes -
            Link This issue relates to JENKINS-42822 [ JENKINS-42822 ]

            People

              amuniz Antonio Muñiz
              dodoent Nenad Miksa
              Votes:
              9 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated: