Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35858

admin - the redux store expose currentX we should drop that and use a pointer to the runs array

XMLWordPrintable

      logically ... the runs in "currentRuns" must also exist under "runs". The currentRuns is more a helper for the view, but we should just use a pointer in the array as currentRuns selector and not a state variable.

      https://github.com/reactjs/reselect#accessing-react-props-in-selectors

      [ACTION_TYPES.GET_CURRENT_RUN_DATA](state, props,

      { payload }

      ): State

      { const currentRuns = state.get('runs'); return currentRuns[props.pipeline]; }

      ,

          [JENKINS-35858] admin - the redux store expose currentX we should drop that and use a pointer to the runs array

          James Dumay created issue -
          Michael Neale made changes -
          Epic Link New: UX-35 [ 24725 ]
          V R made changes -
          Project Import New: Tue Jun 14 12:50:41 JST 2016 [ 1465876241198 ]
          R. Tyler Croy made changes -
          Project Import New: Wed Jun 15 02:53:18 UTC 2016 [ 1465959198925 ]
          James Dumay made changes -
          Labels Original: blueocean technical-debt New: blueocean blueocean-imported technical-debt
          James Dumay made changes -
          Component/s New: blueocean-plugin [ 21481 ]
          Key Original: UX-474 New: JENKINS-35858
          Workflow Original: Product Backlog April 2016 V2 [ 172168 ] New: JNJira [ 172478 ]
          Project Original: User Experience [ 10600 ] New: Jenkins [ 10172 ]
          Status Original: To Do [ 10003 ] New: Open [ 1 ]
          V R made changes -
          Assignee Original: Thorsten Scherler [ tscherler ]
          V R made changes -
          Priority Original: Medium [ 3 ] New: Major [ 10000 ]
          V R made changes -
          Reporter Original: Thorsten Scherler [ tscherler ] New: James Dumay [ jamesdumay ]
          V R made changes -
          Reporter Original: James Dumay [ jdumay ] New: James Dumay [ jdumay ]
          James Dumay made changes -
          Rank New: Ranked higher

            Unassigned Unassigned
            jamesdumay James Dumay
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: