-
Story
-
Resolution: Fixed
-
Minor
-
None
-
-
1.0-m10, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, 1.0-beta-1
Create a v1 acceptance test for testing the the multibranch flow:
- Create the multibranch job. Will need to have branches.
- Inspect structure of the Branches tab. Use a Nightwatch page-object for this.
- Setup an SSE listener in the test to listen for runs of one of the branches.
- Press the "run" widget on the branch being listened to.
- Use the async SSE events to move the test to a successful "done()".
- Verify that the "Queued" and "Started" Toast components appeared at the right time. This will be tricky hmmm.
[JENKINS-36177] Acceptance test for Multi-Branch flow
We'd catch those kinds of regressions if we had these kinda of tests but.
some are really hard to test, that is for sure, and this seems pretty sensible (not saying shouldn't do it, but would be nice to find unit tests that can also cover the same where applicable).
I suspect this is the best place to really test SSE, so we don't have a lot of choice.
This is well worth doing
With this, I would like to have acceptance test run as part of the main build, I think it may be worth it.
As mentioned offline, would be nice to have this as a final stage of the main blueocean Jenkinsfile.
It doesn't have to run as part of the main "mvn install" locally (as it puts requirements that may not be satisfied always).
changed this to not-blocking as it is doesn't have a think linked that it is blocking.
cliffmeyers would like to have good coverage in ATH for these common cases, but not technically blocking.
tscherler tfennelly I have thought about this, would be really nice to have.
Instead of creating a repo programmatically, can we wire it up to a pre-existing github repo we establish for the purposes of this? (saves working out how to set it all up locally).
Thoughts?
Just pushed my WiP to https://github.com/tfennelly/blueocean-acceptance-test/tree/JENKINS-36177.
I did this some time ago and more or less forget what state it's in, but ping me and I', sure I'll be able to resurrect it.
Code changed in jenkins
User: Thorsten Scherler
Path:
package.json
src/main/js/api/git.js
src/test/java/io/jenkins/blueocean/MultibranchTest.java
src/test/js/multibranch.js
src/test/resources/multibranch_1/Jenkinsfile
http://jenkins-ci.org/commit/blueocean-acceptance-test/97f2d753a115fde64df7e9b3bdd1ba7647e66c68
Log:
Merge remote-tracking branch 'tom/JENKINS-36177' into JENKINS-36660
Compare: https://github.com/jenkinsci/blueocean-acceptance-test/compare/805d74b40eb5...97f2d753a115
These are all good things, but there have been some pretty major regressions that it would be nice to catch with a regular test suite rather than rely on this (eg around SSE)