Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-3624

Tomcat adapter hardcodes URL to /manager

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • deploy-plugin
    • None
    • Platform: All, OS: All

      I found this in hudson/plugins/deploy/TomcatAdapter.java:

      config.setProperty(TomcatPropertySet.MANAGER_URL,new
      URL(url,"/manager").toExternalForm());

      This does not work with my setup. I have two instances of Tomcat running on the
      same machine, each with a manager webapp installed. I run one as /foo-manager
      and the other as /bar-manager.

        1. deploy.tomcat.manageurl.patch
          1 kB

          [JENKINS-3624] Tomcat adapter hardcodes URL to /manager

          kgeis created issue -

          fnichol added a comment -

          Created an attachment (id=913)
          Patch to remove /manager from tomcat deploy URL and update config field title

          fnichol added a comment - Created an attachment (id=913) Patch to remove /manager from tomcat deploy URL and update config field title

          evernat added a comment -

          I think that the "/manager" webapp is a standard when using Tomcat, and it should probably not be renamed which would be uncommon anyway.
          They are certainly other solutions such as using two different http ports.

          This issue being stale for a long time, I am closing it.
          Please open again if you really think differently.

          evernat added a comment - I think that the "/manager" webapp is a standard when using Tomcat, and it should probably not be renamed which would be uncommon anyway. They are certainly other solutions such as using two different http ports. This issue being stale for a long time, I am closing it. Please open again if you really think differently.
          evernat made changes -
          Resolution New: Won't Fix [ 2 ]
          Status Original: Open [ 1 ] New: Closed [ 6 ]

          kgeis added a comment -

          This issue is still relevant to me, and I do really think differently.

          /manager is a default, not a standard. It works just fine in alternate locations. Although they should be secured in other ways, it is a good practice to relocate your administrative interfaces away from well-known paths.

          Other solutions are possible but are not usable in all situations (like accessing a machine in a data center where only certain ports are visible from the outside.)

          I also wonder why you consider this stale. I think of things as stale when a developer asks for more information and doesn't get it. A viable patch was proposed and not applied. Why not? Looking at it now, I'm thinking that maybe it needs to include code to migrate existing configuration so that the change will not break anything.

          Please comment on what is needed to get this issue fixed.

          kgeis added a comment - This issue is still relevant to me, and I do really think differently. /manager is a default, not a standard. It works just fine in alternate locations. Although they should be secured in other ways, it is a good practice to relocate your administrative interfaces away from well-known paths. Other solutions are possible but are not usable in all situations (like accessing a machine in a data center where only certain ports are visible from the outside.) I also wonder why you consider this stale. I think of things as stale when a developer asks for more information and doesn't get it. A viable patch was proposed and not applied. Why not? Looking at it now, I'm thinking that maybe it needs to include code to migrate existing configuration so that the change will not break anything. Please comment on what is needed to get this issue fixed.
          kgeis made changes -
          Resolution Original: Won't Fix [ 2 ]
          Status Original: Closed [ 6 ] New: Reopened [ 4 ]

          mturra added a comment -

          I agree /manager is a default.
          To preserve the current jobs a checkbox or a input text should be added to add this feature seamlessly.

          mturra added a comment - I agree /manager is a default. To preserve the current jobs a checkbox or a input text should be added to add this feature seamlessly.
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 133697 ] New: JNJira + In-Review [ 185915 ]
          Robin Jansohn made changes -
          Link New: This issue is duplicated by JENKINS-51440 [ JENKINS-51440 ]
          Robin Jansohn made changes -
          Link New: This issue is duplicated by JENKINS-21187 [ JENKINS-21187 ]

            Unassigned Unassigned
            kgeis kgeis
            Votes:
            3 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: