Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36521

Newline characters in commit logs not parsed correctly

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • subversion-plugin
    • None
    • Master (Windows 7), Slaves (Windows 7, Ubuntu 14.04 LTS)
      Jenkins: 2.7.1 LTS
      Subversion plugin 2.6

      I have several jobs building via subversion commit triggers.
      The commit messages contain several lines with the majority in the following format:

      Commiter Name:
      Details of change1.
      Details of change2.
      

      Up to Jenkins version 1.651.1 + Subversion plugin 2.5.7, the build page displayed the commit message with several lines correctly under "change history".
      After upgrading to Jenkins 1.651.3 + Subversion plugin 2.6 and now Jenkins 2.7.1 + Subversion plugin 2.6, the commit message is displayed as a single line.
      For example, the commit message above would be displayed as follows:

      Commiter Name:<br>Details of change1.<br>Details of change2.
      

      Checking the html page source of the build page, it looks like the newline characters in the commit message are being generated as:

      &lt;br>
      

      As a result, the commit message is being displayed as a single line.

          [JENKINS-36521] Newline characters in commit logs not parsed correctly

          chikigai created issue -
          chikigai made changes -
          Description Original: I have several jobs building via subversion commit triggers.
          The commit messages contain several lines with the majority in the following format:

          {code}
          Commiter Name:
          Details of change1.
          Details of change2.
          {code}
           
          Up to Jenkins version 1.651.1, the build page displayed the commit message with several lines correctly under "change history".
          After upgrading to 1.651.3 and now 2.7.1, the commit message is displayed as a single line.
          For example, the commit message above would be displayed as follows:
          {code}
          Commiter Name:<br>Details of change1.<br>Details of change2.
          {code}

          Checking the page source of the build page, it looks like the newline characters in the commit message are being generated as:

          {code:html}
          &lt;br>
          {code}

          As a result, the commit message is being displayed as a single line.
          New: I have several jobs building via subversion commit triggers.
          The commit messages contain several lines with the majority in the following format:

          {code}
          Commiter Name:
          Details of change1.
          Details of change2.
          {code}
           
          Up to Jenkins version 1.651.1, the build page displayed the commit message with several lines correctly under "change history".
          After upgrading to 1.651.3 and now 2.7.1, the commit message is displayed as a single line.
          For example, the commit message above would be displayed as follows:
          {code}
          Commiter Name:<br>Details of change1.<br>Details of change2.
          {code}

          Checking the html page source of the build page, it looks like the newline characters in the commit message are being generated as:

          {code:html}
          &lt;br>
          {code}

          As a result, the commit message is being displayed as a single line.

          Daniel Beck added a comment -

          After upgrading to 1.651.3

          Pretty sure this is irrelevant and misleading, as this appears to be a regression caused by recena in Subverson 2.6 in 86b8dabfa12c8ce3c38ac5e5756e73137770d173 – I think msgAnnotated in digest.jelly must now be printed raw, otherwise its be escaped.

          Daniel Beck added a comment - After upgrading to 1.651.3 Pretty sure this is irrelevant and misleading, as this appears to be a regression caused by recena in Subverson 2.6 in 86b8dabfa12c8ce3c38ac5e5756e73137770d173 – I think msgAnnotated in digest.jelly must now be printed raw, otherwise its be escaped.
          Daniel Beck made changes -
          Component/s Original: core [ 15593 ]
          Daniel Beck made changes -
          Assignee New: Manuel Recena Soto [ recena ]
          chikigai made changes -
          Description Original: I have several jobs building via subversion commit triggers.
          The commit messages contain several lines with the majority in the following format:

          {code}
          Commiter Name:
          Details of change1.
          Details of change2.
          {code}
           
          Up to Jenkins version 1.651.1, the build page displayed the commit message with several lines correctly under "change history".
          After upgrading to 1.651.3 and now 2.7.1, the commit message is displayed as a single line.
          For example, the commit message above would be displayed as follows:
          {code}
          Commiter Name:<br>Details of change1.<br>Details of change2.
          {code}

          Checking the html page source of the build page, it looks like the newline characters in the commit message are being generated as:

          {code:html}
          &lt;br>
          {code}

          As a result, the commit message is being displayed as a single line.
          New: I have several jobs building via subversion commit triggers.
          The commit messages contain several lines with the majority in the following format:

          {code}
          Commiter Name:
          Details of change1.
          Details of change2.
          {code}
           
          Up to Jenkins version 1.651.1 + Subversion plugin 2.5, the build page displayed the commit message with several lines correctly under "change history".
          After upgrading to 1.651.3 + Subversion plugin 2.6 and now 2.7.1, the commit message is displayed as a single line.
          For example, the commit message above would be displayed as follows:
          {code}
          Commiter Name:<br>Details of change1.<br>Details of change2.
          {code}

          Checking the html page source of the build page, it looks like the newline characters in the commit message are being generated as:

          {code:html}
          &lt;br>
          {code}

          As a result, the commit message is being displayed as a single line.

          chikigai added a comment -

          Thank you for pointing this out.
          I checked when I actually upgraded the Subversion plugin and found out it was together with the update to Jenkins 1.651.3.
          I've updated the details in the description accordingly.

          chikigai added a comment - Thank you for pointing this out. I checked when I actually upgraded the Subversion plugin and found out it was together with the update to Jenkins 1.651.3. I've updated the details in the description accordingly.
          chikigai made changes -
          Description Original: I have several jobs building via subversion commit triggers.
          The commit messages contain several lines with the majority in the following format:

          {code}
          Commiter Name:
          Details of change1.
          Details of change2.
          {code}
           
          Up to Jenkins version 1.651.1 + Subversion plugin 2.5, the build page displayed the commit message with several lines correctly under "change history".
          After upgrading to 1.651.3 + Subversion plugin 2.6 and now 2.7.1, the commit message is displayed as a single line.
          For example, the commit message above would be displayed as follows:
          {code}
          Commiter Name:<br>Details of change1.<br>Details of change2.
          {code}

          Checking the html page source of the build page, it looks like the newline characters in the commit message are being generated as:

          {code:html}
          &lt;br>
          {code}

          As a result, the commit message is being displayed as a single line.
          New: I have several jobs building via subversion commit triggers.
          The commit messages contain several lines with the majority in the following format:

          {code}
          Commiter Name:
          Details of change1.
          Details of change2.
          {code}
           
          Up to Jenkins version 1.651.1 + Subversion plugin 2.5, the build page displayed the commit message with several lines correctly under "change history".
          After upgrading to Jenkins 1.651.3 + Subversion plugin 2.6 and now Jenkins 2.7.1 + Subversion plugin 2.6, the commit message is displayed as a single line.
          For example, the commit message above would be displayed as follows:
          {code}
          Commiter Name:<br>Details of change1.<br>Details of change2.
          {code}

          Checking the html page source of the build page, it looks like the newline characters in the commit message are being generated as:

          {code:html}
          &lt;br>
          {code}

          As a result, the commit message is being displayed as a single line.
          chikigai made changes -
          Description Original: I have several jobs building via subversion commit triggers.
          The commit messages contain several lines with the majority in the following format:

          {code}
          Commiter Name:
          Details of change1.
          Details of change2.
          {code}
           
          Up to Jenkins version 1.651.1 + Subversion plugin 2.5, the build page displayed the commit message with several lines correctly under "change history".
          After upgrading to Jenkins 1.651.3 + Subversion plugin 2.6 and now Jenkins 2.7.1 + Subversion plugin 2.6, the commit message is displayed as a single line.
          For example, the commit message above would be displayed as follows:
          {code}
          Commiter Name:<br>Details of change1.<br>Details of change2.
          {code}

          Checking the html page source of the build page, it looks like the newline characters in the commit message are being generated as:

          {code:html}
          &lt;br>
          {code}

          As a result, the commit message is being displayed as a single line.
          New: I have several jobs building via subversion commit triggers.
          The commit messages contain several lines with the majority in the following format:

          {code}
          Commiter Name:
          Details of change1.
          Details of change2.
          {code}
           
          Up to Jenkins version 1.651.1 + Subversion plugin 2.5.7, the build page displayed the commit message with several lines correctly under "change history".
          After upgrading to Jenkins 1.651.3 + Subversion plugin 2.6 and now Jenkins 2.7.1 + Subversion plugin 2.6, the commit message is displayed as a single line.
          For example, the commit message above would be displayed as follows:
          {code}
          Commiter Name:<br>Details of change1.<br>Details of change2.
          {code}

          Checking the html page source of the build page, it looks like the newline characters in the commit message are being generated as:

          {code:html}
          &lt;br>
          {code}

          As a result, the commit message is being displayed as a single line.
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 173234 ] New: JNJira + In-Review [ 185011 ]

            ljader Łukasz Jąder
            chikigai chikigai
            Votes:
            11 Vote for this issue
            Watchers:
            13 Start watching this issue

              Created:
              Updated:
              Resolved: