Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36574

Add option to choose static notification context

XMLWordPrintable

      Commit https://github.com/jenkinsci/github-branch-source-plugin/commit/5a98d2a885aa951087ba329acdc560bc1e6b7062 just broke the workflow for us.

      We have our protected branches set up to check for context "Jenkins", so a successful build (from our organisation/multibranch projects) is enforced before merging. Through the mentioned commit, we now get "Jenkins job <whatever>" as notification context, on which we cannot protect anymore.

      Please add an option to choose if the default context should contain the job name or not.
      I am aware that you can set a custom context through the GitHubCommitStatusSetter step, but its not a viable and clean solution for us, as we would have to change hundreds of Jenkinsfiles.

          [JENKINS-36574] Add option to choose static notification context

          Hans Schulz created issue -
          Hans Schulz made changes -
          Summary Original: Add Option to choose status notifications per job or not New: Add option to choose static notification context
          Jesse Glick made changes -
          Link New: This issue blocks JENKINS-33161 [ JENKINS-33161 ]
          Jesse Glick made changes -
          Assignee Original: Jesse Glick [ jglick ]

          Jesse Glick added a comment -

          FTR the reason for the change is that it is now possible to have two jobs building the same PR in different ways.

          Jesse Glick added a comment - FTR the reason for the change is that it is now possible to have two jobs building the same PR in different ways.

          Jesse Glick added a comment -

          …which would suggest a possible solution of changing the context to not mention the job name, but to vary according to whether or not this is a merging job.

          Jesse Glick added a comment - …which would suggest a possible solution of changing the context to not mention the job name, but to vary according to whether or not this is a merging job.

          Hans Schulz added a comment -

          I don't see why having two jobs building the same PR would not have been possible before, since you can always use the GitHubCommitStatusSetter step to set a different status context.

          Hans Schulz added a comment - I don't see why having two jobs building the same PR would not have been possible before, since you can always use the GitHubCommitStatusSetter step to set a different status context.
          Thomas Müller made changes -
          Link New: This issue is blocked by JENKINS-36602 [ JENKINS-36602 ]

          Thomas Müller added a comment -

          I have to agree - please keep the status constant.
          https://issues.jenkins-ci.org/browse/JENKINS-36602

          Thomas Müller added a comment - I have to agree - please keep the status constant. https://issues.jenkins-ci.org/browse/JENKINS-36602

          Thomas Müller added a comment -

          Here is a pr to revert the change
          https://github.com/jenkinsci/github-branch-source-plugin/pull/62

          Thomas Müller added a comment - Here is a pr to revert the change https://github.com/jenkinsci/github-branch-source-plugin/pull/62

            jglick Jesse Glick
            schulzha Hans Schulz
            Votes:
            12 Vote for this issue
            Watchers:
            21 Start watching this issue

              Created:
              Updated:
              Resolved: