Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36593

ItemCategory exposes public static MIN_TOSHOW field to API

    XMLWordPrintable

Details

    Description

      In https://github.com/jenkinsci/jenkins/commit/25f9c99d8376667b2efaabe8cb6f5b4be6024618 recena introduced a new "public static int MIN_TOSHOW = 1" field. So we have a constant, which can be occasionally modified by any API user.

      This field is now a part of API, so we cannot easily convert it to final or make private. My proposal is to restrict it at least

      Attachments

        Issue Links

          links to

          Web Link PR-2449

          Activity

            Ascending order - Click to sort in descending order
            oleg_nenashev Oleg Nenashev created issue -
            recena Manuel Recena Soto made changes -
            Field Original Value New Value
            Remote Link This issue links to "PR-2449 (Web Link)" [ 14609 ]
            recena Manuel Recena Soto made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            recena Manuel Recena Soto made changes -
            Assignee Oleg Nenashev [ oleg_nenashev ]
            recena Manuel Recena Soto added a comment -

            oleg_nenashev I sent my comments to the PR.

            recena Manuel Recena Soto added a comment - oleg_nenashev I sent my comments to the PR.
            danielbeck Daniel Beck added a comment -

            Fixed in 2.14 (2016/07/17)

            danielbeck Daniel Beck added a comment - Fixed in 2.14 (2016/07/17)
            danielbeck Daniel Beck made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Resolved [ 5 ]
            danielbeck Daniel Beck made changes -
            Labels lts-candidate
            danielbeck Daniel Beck added a comment -

            olivergondza Should be expedited into 2.7.2 to prevent people from using it IMO.

            danielbeck Daniel Beck added a comment - olivergondza Should be expedited into 2.7.2 to prevent people from using it IMO.
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 173314 ] JNJira + In-Review [ 199432 ]
            olivergondza Oliver Gondža made changes -
            Labels lts-candidate 2.7.2-fixed

            People

              oleg_nenashev Oleg Nenashev
              oleg_nenashev Oleg Nenashev
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: