Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36720

Investigate/cleanup spotbugs issues in Jenkins core

      Currently FindBugs settings ignore all medium-priority issues. It's bad, because this level contains NPE checks and other serious issues.

      TODOs:

      • Remove filtering of medium-priority issues by setting <findbugs.threshold>Medium</findbugs.threshold>
      • Investigate error codes, add low-important once to the ignore list
      • Fix important issues in small pull requests

      This task can be handled by multiple contributors!

          [JENKINS-36720] Investigate/cleanup spotbugs issues in Jenkins core

          Oleg Nenashev created issue -
          Oleg Nenashev made changes -
          Epic Link New: JENKINS-36716 [ 172750 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 173452 ] New: JNJira + In-Review [ 185131 ]

          Oleg Nenashev added a comment -

          Summary:

          • 2 issues in CLI
          • 477 issues in the core

          The output is too long to be published as text, I'll attach it

          Oleg Nenashev added a comment - Summary: 2 issues in CLI 477 issues in the core The output is too long to be published as text, I'll attach it
          Oleg Nenashev made changes -
          Attachment New: findbugsIssues_core.txt [ 33665 ]

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          http://jenkins-ci.org/commit/jenkins/6ca0d754c5cba97613bc8b1e7b33327119fbf79c
          Log:
          JENKINS-36720 - FindBugs. Reduse threshold to Medium

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/jenkins/6ca0d754c5cba97613bc8b1e7b33327119fbf79c Log: JENKINS-36720 - FindBugs. Reduse threshold to Medium
          Oleg Nenashev made changes -
          Labels New: newbie-friendly

          Oleg Nenashev added a comment -

          It's actually newbie-friendly. Anyone can pick the core, run FindBugs and then cleanup something from the report. This issue is rather a milestone for such kind of activities

          Oleg Nenashev added a comment - It's actually newbie-friendly. Anyone can pick the core, run FindBugs and then cleanup something from the report. This issue is rather a milestone for such kind of activities
          Stefan Spieker made changes -
          Assignee New: Stefan Spieker [ stefan_spieker ]
          Stefan Spieker made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

            stefan_spieker Stefan Spieker
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated: