Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37006

Improved importing/requiring of modules across bundles

    • 1.0-m12, 1.0-pre-beta-1, 1.0-beta-1

      E.g. to accommodate the how we need control over how react and react-dom are loaded.

      tfennelly assigning to you for now but I intend to reach out tomorrow so we can work this together. We discussed a workaround for this last week but I was not successful after following the steps you'd provided. Could be something I've missed though. If it's not, let's try to fix together, with my final task being to do a write-up in a wiki about the steps needed to work around this problem.

      Steps followed:

      1. Add 'react-addons-css-transition-group' to init.jsx in blueocean-web
      2. In js-extensions/@jenkins-cd/subs/extensions-bundle.js, update the createBundle function near the end
      3. Build a new js-extensions
      4. npm install new js-extensions in blueocean-web and blueocean-personalization
      5. Re-run gulp bundle for both modules

          [JENKINS-37006] Improved importing/requiring of modules across bundles

          Cliff Meyers created issue -
          Cliff Meyers made changes -
          Epic Link New: JENKINS-35749 [ 171790 ]
          Cliff Meyers made changes -
          Link New: This issue blocks JENKINS-37007 [ JENKINS-37007 ]
          Cliff Meyers made changes -
          Description Original: [~tfennelly] assigning to you for now but I intend to reach out tomorrow so we can work this together. We discussed a workaround for this last week but I was not successful after following the steps you'd provided. Could be something I've missed though. If it's not, let's try to fix together, with the final task being to do a write-up in a wiki about the steps needed to work around this problem.

          Steps followed:
          # Add 'react-addons-css-transition-group' to init.jsx in blueocean-web
          # In js-extensions/@jenkins-cd/subs/extensions-bundle.js, update the createBundle function near the end
          # Build a new js-extensions
          # npm install new js-extensions in blueocean-web and blueocean-personalization
          New: [~tfennelly] assigning to you for now but I intend to reach out tomorrow so we can work this together. We discussed a workaround for this last week but I was not successful after following the steps you'd provided. Could be something I've missed though. If it's not, let's try to fix together, with the final task being to do a write-up in a wiki about the steps needed to work around this problem.

          Steps followed:
          # Add 'react-addons-css-transition-group' to init.jsx in blueocean-web
          # In js-extensions/@jenkins-cd/subs/extensions-bundle.js, update the createBundle function near the end
          # Build a new js-extensions
          # npm install new js-extensions in blueocean-web and blueocean-personalization
          # Re-run gulp bundle for both modules
          Cliff Meyers made changes -
          Description Original: [~tfennelly] assigning to you for now but I intend to reach out tomorrow so we can work this together. We discussed a workaround for this last week but I was not successful after following the steps you'd provided. Could be something I've missed though. If it's not, let's try to fix together, with the final task being to do a write-up in a wiki about the steps needed to work around this problem.

          Steps followed:
          # Add 'react-addons-css-transition-group' to init.jsx in blueocean-web
          # In js-extensions/@jenkins-cd/subs/extensions-bundle.js, update the createBundle function near the end
          # Build a new js-extensions
          # npm install new js-extensions in blueocean-web and blueocean-personalization
          # Re-run gulp bundle for both modules
          New: [~tfennelly] assigning to you for now but I intend to reach out tomorrow so we can work this together. We discussed a workaround for this last week but I was not successful after following the steps you'd provided. Could be something I've missed though. If it's not, let's try to fix together, with my final task being to do a write-up in a wiki about the steps needed to work around this problem.

          Steps followed:
          # Add 'react-addons-css-transition-group' to init.jsx in blueocean-web
          # In js-extensions/@jenkins-cd/subs/extensions-bundle.js, update the createBundle function near the end
          # Build a new js-extensions
          # npm install new js-extensions in blueocean-web and blueocean-personalization
          # Re-run gulp bundle for both modules
          Tom FENNELLY made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Tom FENNELLY made changes -
          Summary Original: Adding "react-addons-css-transition-group" to blueocean-personalization results in "duplicate Reacts" error New: Look for a new way of importing/requiring modules across bundles
          Tom FENNELLY made changes -
          Description Original: [~tfennelly] assigning to you for now but I intend to reach out tomorrow so we can work this together. We discussed a workaround for this last week but I was not successful after following the steps you'd provided. Could be something I've missed though. If it's not, let's try to fix together, with my final task being to do a write-up in a wiki about the steps needed to work around this problem.

          Steps followed:
          # Add 'react-addons-css-transition-group' to init.jsx in blueocean-web
          # In js-extensions/@jenkins-cd/subs/extensions-bundle.js, update the createBundle function near the end
          # Build a new js-extensions
          # npm install new js-extensions in blueocean-web and blueocean-personalization
          # Re-run gulp bundle for both modules
          New: E.g. to accommodate the how we need control over how react and react-dom are loaded.

          [~tfennelly] assigning to you for now but I intend to reach out tomorrow so we can work this together. We discussed a workaround for this last week but I was not successful after following the steps you'd provided. Could be something I've missed though. If it's not, let's try to fix together, with my final task being to do a write-up in a wiki about the steps needed to work around this problem.

          Steps followed:
          # Add 'react-addons-css-transition-group' to init.jsx in blueocean-web
          # In js-extensions/@jenkins-cd/subs/extensions-bundle.js, update the createBundle function near the end
          # Build a new js-extensions
          # npm install new js-extensions in blueocean-web and blueocean-personalization
          # Re-run gulp bundle for both modules
          James Dumay made changes -
          Sprint Original: 1.0-m12 [ 76 ] New: 1.0-m12, 1.0-beta-1 [ 76, 86 ]
          Tom FENNELLY made changes -
          Component/s New: js-builder [ 21132 ]
          Component/s New: js-modules [ 21133 ]
          Tom FENNELLY made changes -
          Link New: This issue is duplicated by JENKINS-35727 [ JENKINS-35727 ]

            tfennelly Tom FENNELLY
            cliffmeyers Cliff Meyers
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: