Details
-
Bug
-
Status: Resolved (View Workflow)
-
Minor
-
Resolution: Fixed
-
None
-
* Jenkins: 2.7.1
* JUnit Attachments Plugin: 1.4.2
* JUnit: 4.8.1
Description
Steps to reproduce.
1. Run a test which attaches files including '%' character with JUnit Attachments Plugin.
e.g. https://gist.github.com/miyajan/703d52d1ec449a16f29ed31c6e89865e
2. Access to the page at the method level.
e.g. http://your-jenkins.example.com/job/attachments-test/1/testReport/com.example.miyajan/AttachmentsTest/testScreenshot/
3. Click a link '100%.png'.
-> 404 error.
It seems that the URL is not escaped.
current: http://your-jenkins.example.com/job/attachments-test/1/testReport/com.example.miyajan/AttachmentsTest/testScreenshot/attachments/100%.png
expected: http://your-jenkins.example.com/job/attachments-test/1/testReport/com.example.miyajan/AttachmentsTest/testScreenshot/attachments/100%25.png
Attachments
Issue Links
- is duplicated by
-
-
- Resolved
-
- links to
- mentioned in
-
Page Loading...
Activity
Code changed in jenkins
User: Jesse Glick
Path:
src/main/java/hudson/plugins/junitattachments/AttachmentTestAction.java
src/main/resources/hudson/plugins/junitattachments/AttachmentTestAction/summary.jelly
http://jenkins-ci.org/commit/junit-attachments-plugin/579bba59885f38ba85a0bb571037cd1bed188f1d
Log:
Merge pull request #16 from miyajan/JENKINS-37026
JENKINS-37026 Fix to encode URL to attachments
Compare: https://github.com/jenkinsci/junit-attachments-plugin/compare/5914e4a5f022...579bba59885f
Tobias Gruetzmacher
added a comment - Unfortunately, this change breaks links to files with spaces in their name (But AFAICS the new format is the correct way to encode spaces in URLs).
This plugin creates: href="attachments/Report+hold.png"
Jenkins Core seems to expect URLs to contain the space as %20 for example, the workspace/attachement browser encodes them correctly...
Tobias Gruetzmacher
added a comment - Unfortunately, this change breaks links to files with spaces in their name (But AFAICS the new format is the correct way to encode spaces in URLs).
This plugin creates: href="attachments/Report+hold.png"
Jenkins Core seems to expect URLs to contain the space as %20 for example, the workspace/attachement browser encodes them correctly... 
Code changed in jenkins
User: jumpei-miyata
Path:
src/main/java/hudson/plugins/junitattachments/AttachmentTestAction.java
src/main/resources/hudson/plugins/junitattachments/AttachmentTestAction/summary.jelly
http://jenkins-ci.org/commit/junit-attachments-plugin/a6341ac8d5812eb7dfcf03e8c7f5ea2e33b6883d
Log:
JENKINS-37026Fix to encode URL to attachments