Details
-
Type:
Bug
-
Status: Resolved (View Workflow)
-
Priority:
Major
-
Resolution: Fixed
-
Component/s: gitlab-oauth-plugin
-
Labels:None
-
Environment:GitLab: 8.10.1 CE
Jenkins: 2.7.1 LTS
GitLab Oauth Plugin: 1.5
-
Similar Issues:
Description
Right now HttpClient is using @deprecated methods to setup the DefaultHttpClient. This avoids SSL SNI information to be included in the requests and breaks integration with GitLab server that are behind SSL proxies that rely on SNI to identify the right server.
Attachments
Activity
Field | Original Value | New Value |
---|---|---|
Description |
It seems that the version combination of GitLab, Jenkins and the plugin is not working. I can create the "Application" in GitLab and setup the plugin Security Realm settings. When I then try to login I get the redirect to GitLab and I have to acknowledge "Access your API". So client ID, secret and redirect URL all work fine. But when I then click on "Authorize" and it redirects me back (incl. a new "code" query parameter appended to /securityRealm/finishLogin URL) I am still not logged in and browse Jenkins as anonymous. I already enabled fine grained logging in Jenkins but I don't see any errors/exceptions either. |
Right now HttpClient is using @deprecated methods to setup the DefaultHttpClient. This avoids SSL SNI information to be included in the requests and breaks integration with GitLab server that are behind SSL proxies that rely on SNI to identify the right server. |
Summary | Plugin doesn't log in user | Plugin does not support SSL SNI |
Assignee | Mohamed El Habib [ elhabib_med ] | Thorsten Kunz [ askannon ] |
Resolution | Fixed [ 1 ] | |
Status | Open [ 1 ] | Resolved [ 5 ] |
I create a PR on GitHub to fix the issue: https://github.com/jenkinsci/gitlab-oauth-plugin/pull/2