Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37281

Remove "StopPropagation" from blueocean-dashboard module

    XMLWordPrintable

Details

    • 1.0-pre-beta-1, 1.0-b05/b-06

    Description

      We want to remove StopPropagation from blueocean-dashboard and replace with a simple event.stopPropagation() handler where needed.

      Based on sophistifunk feedback here:
      https://github.com/jenkinsci/blueocean-plugin/pull/386#discussion_r72914647

      It's not really sensible to use a React component to suppress click events. If our use cases become more elaborate down the road, maybe it would be a good idea, but for now, no.

      Attachments

        Issue Links

          Activity

            cliffmeyers Cliff Meyers created issue -
            cliffmeyers Cliff Meyers made changes -
            Field Original Value New Value
            Epic Link JENKINS-35761 [ 171656 ]
            cliffmeyers Cliff Meyers made changes -
            Link This issue is related to JENKINS-37023 [ JENKINS-37023 ]
            jamesdumay James Dumay made changes -
            Sprint 1.0-pre-beta-1 [ 86 ]
            jamesdumay James Dumay made changes -
            Sprint 1.0-pre-beta-1 [ 86 ] 1.0-pre-beta-1, 1.0-beta-1 [ 86, 96 ]
            jamesdumay James Dumay made changes -
            Sprint 1.0-pre-beta-1, 1.0-beta-1 [ 86, 96 ] 1.0-pre-beta-1 [ 86 ]
            jamesdumay James Dumay made changes -
            Sprint 1.0-pre-beta-1 [ 86 ] 1.0-pre-beta-1, 1.0-beta-2 [ 86, 101 ]
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Sprint 1.0-pre-beta-1, 1.0-beta-3 [ 86, 101 ] 1.0-pre-beta-1, 1.0-beta-2 [ 86, 111 ]
            jamesdumay James Dumay made changes -
            Rank Ranked lower
            cliffmeyers Cliff Meyers made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            cliffmeyers Cliff Meyers made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            cliffmeyers Cliff Meyers added a comment - PR: https://github.com/jenkinsci/blueocean-plugin/pull/498
            cliffmeyers Cliff Meyers made changes -
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]
            pjfanning PJ Fanning made changes -
            Link This issue is related to JENKINS-37282 [ JENKINS-37282 ]
            pjfanning PJ Fanning made changes -
            Link This issue is related to JENKINS-37282 [ JENKINS-37282 ]

            People

              cliffmeyers Cliff Meyers
              cliffmeyers Cliff Meyers
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: