Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37440

Disable FindBugs analysis when skipping tests

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Won't Do
    • Icon: Major Major
    • core
    • None

      JENKINS-36715 made a typical developer build of Jenkins (mvn -DskipTests clean install) much slower, adding about a minute of heavy CPU activity on my laptop. Static analysis is useless during developer builds: if there are any regressions, CI builds will catch them alongside automated tests.

      While you can disable the slow plugin execution with -Dfindbugs.skip, it would be nicer to have this be implied by the standard -DskipTests, which is an indication that you are just interested in producing artifacts as quickly as possible.

      For plugins we already do this, so it should be easy to copy that logic to core.

          [JENKINS-37440] Disable FindBugs analysis when skipping tests

          Jesse Glick created issue -
          Jesse Glick made changes -
          Epic Link New: JENKINS-36716 [ 172750 ]
          Jesse Glick made changes -
          Link New: This issue blocks JENKINS-36715 [ JENKINS-36715 ]

          Oleg Nenashev added a comment -

          Agreed. But we should run FindBugs in the case of lightweight tests, so the logic will be a bit different

          Oleg Nenashev added a comment - Agreed. But we should run FindBugs in the case of lightweight tests, so the logic will be a bit different
          Oleg Nenashev made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          James Nord added a comment - - edited

          I'm against this. As a Maven user I expect that -DskipTests skips tests and that -Dfindbugs.skip skips findbugs.

          Please do not overload a specific flag for a plugin with another flag. If you want to use a profile that you can activate -Pquickbuild or activate via a property -DskipTestsAndFindbugs.

          James Nord added a comment - - edited I'm against this. As a Maven user I expect that -DskipTests skips tests and that -Dfindbugs.skip skips findbugs. Please do not overload a specific flag for a plugin with another flag. If you want to use a profile that you can activate -Pquickbuild or activate via a property -DskipTestsAndFindbugs.

          Oleg Nenashev added a comment -

          I would also prefer to have FB by default. This change just aligns the behavior with Parent POM.
          But we can change our mind about parent POM of course

          Oleg Nenashev added a comment - I would also prefer to have FB by default. This change just aligns the behavior with Parent POM. But we can change our mind about parent POM of course
          Jesse Glick made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Oleg Nenashev made changes -
          Remote Link New: This issue links to "PR #2514 (Web Link)" [ 14757 ]
          Jesse Glick made changes -
          Remote Link New: This issue links to "PR 2514 (Web Link)" [ 14758 ]

            Unassigned Unassigned
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: