Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37546

When dynamic plugin load fails, PermissionGroups are not being cleaned up

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Component/s: core
    • Labels:
    • Environment:
      jenkins-2.16
    • Similar Issues:

      Description

      Noticed it during JENKINS-37545.

      Reproduction steps:
      1) Manually deploy a plugin with detached dependencies and permission groups (e.g. Ownership 0.5)
      2) The loading should fail...
      3) Install missing dependencies
      4) Deploy the plugin again
      5) Change the log

      Expected behavior:
      The plugin installation succeeds

      Actual behavior:
      Plugin installation fails due to the missing permission group

      Workaround:
      Restart the instance

        Attachments

          Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-17200 SCM.TAG permission not eagerly loaded

          • Major - Major loss of function.
          • Open

            Activity

            Ascending order - Click to sort in descending order
            oleg_nenashev Oleg Nenashev created issue -
            oleg_nenashev Oleg Nenashev made changes -
            Field Original Value New Value
            Attachment Screen Shot 2016-08-19 at 13.24.21.png [ 33656 ]
            oleg_nenashev Oleg Nenashev made changes -
            Attachment Screen Shot 2016-08-19 at 13.24.21.png [ 33656 ]
            oleg_nenashev Oleg Nenashev made changes -
            Attachment Screen Shot 2016-08-19 at 13.39.31.png [ 33657 ]
            oleg_nenashev Oleg Nenashev made changes -
            Summary When dynamic plugin loading fails, PermissionGroups are not being cleaned up When dynamic plugin load fails, PermissionGroups are not being cleaned up
            Hide
            Permalink
            jglick Jesse Glick added a comment -

            Probably should be fixed implicitly by a rewrite of permission registration, as mentioned in JENKINS-17200.

            Show
            jglick Jesse Glick added a comment - Probably should be fixed implicitly by a rewrite of permission registration, as mentioned in JENKINS-17200 .
            jglick Jesse Glick made changes -
            Link This issue is related to JENKINS-17200 [ JENKINS-17200 ]
            segator Isaac Aymerich made changes -
            Environment jenkins-2.16 jenkins-2.16
            jenkins-2.17
            segator Isaac Aymerich made changes -
            Environment jenkins-2.16
            jenkins-2.17
            		 jenkins-2.16
            Hide
            Permalink
            jvz Matt Sicker added a comment -

            In my current proposal around permissions, this error wouldn't happen as permissions are loaded lazily. Before that, I also had a ConcurrentMap for registering permissions, so even that was using putIfAbsent to avoid duplicating permissions in the UI.

            Show
            jvz Matt Sicker added a comment - In my  current proposal around permissions, this error wouldn't happen as permissions are loaded lazily. Before that, I also had a ConcurrentMap for registering permissions, so even that was using putIfAbsent to avoid duplicating permissions in the UI.
            jvz Matt Sicker made changes -
            Labels permissions

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              oleg_nenashev Oleg Nenashev
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated: