Details
-
Bug
-
Status: Open (View Workflow)
-
Major
-
Resolution: Unresolved
Description
Steps to reproduce
- Create a Pipeline with a Jenkinsfile
- Introduce a Groovy syntax error, like omitting a trailing parenthesis on a method call
- Execute
What ends up happening is that an exception is shown, e.g.:
Checking out Revision f29c250737c3db53f709977224c4547a43ed4886 (refs/remotes/origin/master) org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed: WorkflowScript: 7: expecting ')', found ']' @ line 7, column 17. ])
But the sidebar includes no Replay link to attempt to fix the change, instead you need to commit a change to make the Jenkinsfile correct Groovy syntax.
Expected
- Replay is shown no matter how fscked my Jenkinsfile is so I can correct it
This issue also occurs if you use Replay and introduce a Groovy syntax error as well. Also, I believe this is related to JENKINS-34555
Attachments
Issue Links
- is related to
-
-
- Resolved
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Component/s | pipeline-general [ 21692 ] |
| Component/s | workflow-plugin [ 18820 ] |
| Component/s | workflow-cps-plugin [ 21713 ] | |
| Component/s | pipeline [ 21692 ] |
| Link |
This issue is related to |
Julien Pivotto
made changes -
| Attachment | PP.png [ 35211 ] |
Prince Raj Kumar
made changes -
| Priority | Minor [ 4 ] | Major [ 3 ] |
Sam Van Oort
made changes -
| Labels | community-bee | community-bee maybe-fixed-by-durability-megafix |
Sam Van Oort
added a comment - rtyler orrc Can you check if the error occurs with workflow-cps 2.50 and workflow-cps 2.21? I just released a set of fixes that I think address this.
Sam Van Oort
added a comment - rtyler orrc Can you check if the error occurs with workflow-cps 2.50 and workflow-cps 2.21? I just released a set of fixes that I think address this. 
Enrique Canales
added a comment - I had tested this with workflow-cps 2.54 and workflow-job 2.21 and it looks like the Replay link shows up, but the ` Main Script` portion does not when there was a syntax error.
Enrique Canales
added a comment - I had tested this with workflow-cps 2.54 and workflow-job 2.21 and it looks like the Replay link shows up, but the ` Main Script` portion does not when there was a syntax error. It looks like the main script portion does not show up because ReplayAction#isReplayableSandboxTest returns false because loading the execution fails with the following:
Aug 23, 2018 2:16:33 PM org.jenkinsci.plugins.workflow.cps.replay.ReplayAction getExecutionBlocking
WARNING: Error fetching execution for replay
java.io.IOException: Syntax #1 did not yet start
at org.jenkinsci.plugins.workflow.job.WorkflowRun$Owner.get(WorkflowRun.java:1125)
at org.jenkinsci.plugins.workflow.cps.replay.ReplayAction.getExecutionBlocking(ReplayAction.java:126)
at org.jenkinsci.plugins.workflow.cps.replay.ReplayAction.isReplayableSandboxTest(ReplayAction.java:166)
... the rest of the stack is not relevant (tested via script console)
| Labels | community-bee maybe-fixed-by-durability-megafix | community-bee maybe-fixed-by-durability-megafix triaged-2018-11 |
Marcin Kwiecien
added a comment - It would be awesome if this was fixed... Because it's a major pain. If you don't copy your Jenkinsfile before hitting on the "Run" button and the build fails due to Groovy syntax error then all your changes to the Jenkinsfile you just did via the Replay button are gone.
Marcin Kwiecien
added a comment - It would be awesome if this was fixed... Because it's a major pain. If you don't copy your Jenkinsfile before hitting on the "Run" button and the build fails due to Groovy syntax error then all your changes to the Jenkinsfile you just did via the Replay button are gone. 
Steven Laursen
added a comment - Fingers and teeth.
Probably not surprising, but thought I'd note: the same occurs if you make a syntax error with a purely Declarative Pipeline.