Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37603

Favourite icons do not have hover style

    XMLWordPrintable

Details

    • 1.0-beta-1

    Description

      Same rules should apply to the hover style of the favourites as they do for the other action icons (I believe we use a filter to darken them?) Hit James up if you need assets

      Attachments

        Issue Links

          Activity

            cliffmeyers Cliff Meyers added a comment -

            jamesdumay if we use a filter, it won't work in IE11. Could you give me the precise hex value we should be using for the hover state of favorite in the default, white and yellow states? I can produce the SVG asset (unless you want to do something more complex than a fill). I might also try just using the SVG asset inline so we can more easily style it with CSS. We have them as background-image now because there was a concern over bloating the JS with inline SVG but if we have to produce dup SVG assets just to change colors then that's not an improvement IMO.

            cliffmeyers Cliff Meyers added a comment - jamesdumay if we use a filter, it won't work in IE11. Could you give me the precise hex value we should be using for the hover state of favorite in the default, white and yellow states? I can produce the SVG asset (unless you want to do something more complex than a fill). I might also try just using the SVG asset inline so we can more easily style it with CSS. We have them as background-image now because there was a concern over bloating the JS with inline SVG but if we have to produce dup SVG assets just to change colors then that's not an improvement IMO.
            jamesdumay James Dumay added a comment -

            FYI Cliff and I discussed this and he is taking a different approach that does not require filter (inlining SVGs)

            jamesdumay James Dumay added a comment - FYI Cliff and I discussed this and he is taking a different approach that does not require filter (inlining SVGs)
            cliffmeyers Cliff Meyers added a comment - https://github.com/jenkinsci/jenkins-design-language/pull/88
            cliffmeyers Cliff Meyers added a comment -

            Inline SVG is such a massive improvement here, especially if you sprinkle a few classNames on the paths you care about.

            cliffmeyers Cliff Meyers added a comment - Inline SVG is such a massive improvement here, especially if you sprinkle a few classNames on the paths you care about.
            cliffmeyers Cliff Meyers added a comment - PR: https://github.com/jenkinsci/blueocean-plugin/pull/478

            People

              cliffmeyers Cliff Meyers
              jamesdumay James Dumay
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: