Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37714

js-builder bundle transform not taking dedupe into account when translating fullPaths to Ids

XMLWordPrintable

    • 1.0-beta-1

      js-builder does some transforms on the browserify bundles as part of it's "thing". At the very end, it translates the bundle pack entry IDs from being long "fullPath" IDs to short numbers. Something we missed in this was how browserify dedupes bundle pack entries that are identical, with the deduped pack entry containing the pack ID ... we need to find these too and translate the pack IDs here too.

          [JENKINS-37714] js-builder bundle transform not taking dedupe into account when translating fullPaths to Ids

          Tom FENNELLY created issue -
          Tom FENNELLY made changes -
          Epic Link New: JENKINS-35749 [ 171790 ]
          Tom FENNELLY made changes -
          Link New: This issue blocks JENKINS-35783 [ JENKINS-35783 ]

          Tom FENNELLY added a comment -

          BTW ... these duplicates seem to be happening because of deps being dragged in by jsonwebtoken, where these deps are also deps of other packages, but having different versions. The diff versions results in npm hanging them on subbranches down inside node_modules, which means they end up having different paths and fullPath IDs, but often having identical module file content => resulting in the dedupe.

          Tom FENNELLY added a comment - BTW ... these duplicates seem to be happening because of deps being dragged in by jsonwebtoken, where these deps are also deps of other packages, but having different versions. The diff versions results in npm hanging them on subbranches down inside node_modules, which means they end up having different paths and fullPath IDs, but often having identical module file content => resulting in the dedupe.
          Tom FENNELLY made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Tom FENNELLY added a comment -

          Have a Wip PR: https://github.com/jenkinsci/js-builder/pull/8

          Tom FENNELLY added a comment - Have a Wip PR: https://github.com/jenkinsci/js-builder/pull/8
          Tom FENNELLY made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Tom FENNELLY made changes -
          Component/s New: blueocean-plugin [ 21481 ]

          Tom FENNELLY added a comment -

          And the BlueO PR pulling in the js-builder fixes ... https://github.com/jenkinsci/blueocean-plugin/pull/444

          Tom FENNELLY added a comment - And the BlueO PR pulling in the js-builder fixes ... https://github.com/jenkinsci/blueocean-plugin/pull/444
          Tom FENNELLY made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Resolved [ 5 ]

            tfennelly Tom FENNELLY
            tfennelly Tom FENNELLY
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: