• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Component/s: pipeline-stage-view-plugin
• Labels:

  • ux

[JENKINS-38133] Pipeline stage view shows log expand option where no log exists

Sam Van Oort created issue - 2016-09-12 12:28

Sam Van Oort made changes - 2016-09-12 13:36

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

Collapse comment: SCM/JIRA link daemon added a comment - 2016-09-12 13:36

SCM/JIRA link daemon added a comment - 2016-09-12 13:36

Code changed in jenkins
User: Sam Van Oort
Path:
rest-api/src/main/java/com/cloudbees/workflow/rest/external/AtomFlowNodeExt.java
ui/src/main/js/view/templates/stage-logs.hbs
ui/src/test/js/view/stage-logs-spec.js
http://jenkins-ci.org/commit/pipeline-stage-view-plugin/eab35fc7c9f0882042e290052918a47b8e217169
Log:
Fix JENKINS-38133 and show timing

Expand comment: SCM/JIRA link daemon added a comment - 2016-09-12 13:36

SCM/JIRA link daemon added a comment - 2016-09-12 13:36 Code changed in jenkins User: Sam Van Oort Path: rest-api/src/main/java/com/cloudbees/workflow/rest/external/AtomFlowNodeExt.java ui/src/main/js/view/templates/stage-logs.hbs ui/src/test/js/view/stage-logs-spec.js http://jenkins-ci.org/commit/pipeline-stage-view-plugin/eab35fc7c9f0882042e290052918a47b8e217169 Log: Fix JENKINS-38133 and show timing

Collapse comment: SCM/JIRA link daemon added a comment - 2016-09-12 14:32

SCM/JIRA link daemon added a comment - 2016-09-12 14:32

Code changed in jenkins
User: Sam Van Oort
Path:
rest-api/src/main/java/com/cloudbees/workflow/rest/external/AtomFlowNodeExt.java
ui/src/main/js/view/templates/stage-logs.hbs
ui/src/test/js/view/stage-logs-spec.js
http://jenkins-ci.org/commit/pipeline-stage-view-plugin/ef8a7c7bfe516679ac0f29752287b2073954a230
Log:
Merge pull request #28 from jenkinsci/ui-fix-log-expansion-and-show-timing

Fix JENKINS-38133 and show timing

Compare: https://github.com/jenkinsci/pipeline-stage-view-plugin/compare/1e2f52466b36...ef8a7c7bfe51

Expand comment: SCM/JIRA link daemon added a comment - 2016-09-12 14:32

SCM/JIRA link daemon added a comment - 2016-09-12 14:32 Code changed in jenkins User: Sam Van Oort Path: rest-api/src/main/java/com/cloudbees/workflow/rest/external/AtomFlowNodeExt.java ui/src/main/js/view/templates/stage-logs.hbs ui/src/test/js/view/stage-logs-spec.js http://jenkins-ci.org/commit/pipeline-stage-view-plugin/ef8a7c7bfe516679ac0f29752287b2073954a230 Log: Merge pull request #28 from jenkinsci/ui-fix-log-expansion-and-show-timing Fix JENKINS-38133 and show timing Compare: https://github.com/jenkinsci/pipeline-stage-view-plugin/compare/1e2f52466b36...ef8a7c7bfe51

Sam Van Oort made changes - 2016-09-12 16:44

Status

Original: In Progress [ 3 ]

New: In Review [ 10005 ]

Collapse comment: Sam Van Oort added a comment - 2016-09-12 16:44

Sam Van Oort added a comment - 2016-09-12 16:44

Merged and will go into the next release

Expand comment: Sam Van Oort added a comment - 2016-09-12 16:44

Sam Van Oort added a comment - 2016-09-12 16:44 Merged and will go into the next release

Sam Van Oort made changes - 2016-09-12 16:44

Resolution		New: Fixed [ 1 ]
Status	Original: In Review [ 10005 ]	New: Resolved [ 5 ]

Collapse comment: SCM/JIRA link daemon added a comment - 2016-09-30 19:10

SCM/JIRA link daemon added a comment - 2016-09-30 19:10

Code changed in jenkins
User: Sam Van Oort
Path:
ui/src/main/js/view/templates/stage-logs.hbs
ui/src/test/js/view/stage-logs-spec.js
http://jenkins-ci.org/commit/pipeline-stage-view-plugin/880cc246979675ad1df263b3578dbbb505bb7683
Log:
Fix small UX regression with skipped flownodes from JENKINS-38133 by hiding NotExecuted nodes from log display

Expand comment: SCM/JIRA link daemon added a comment - 2016-09-30 19:10

SCM/JIRA link daemon added a comment - 2016-09-30 19:10 Code changed in jenkins User: Sam Van Oort Path: ui/src/main/js/view/templates/stage-logs.hbs ui/src/test/js/view/stage-logs-spec.js http://jenkins-ci.org/commit/pipeline-stage-view-plugin/880cc246979675ad1df263b3578dbbb505bb7683 Log: Fix small UX regression with skipped flownodes from JENKINS-38133 by hiding NotExecuted nodes from log display

Edwin Makiuchi made changes - 2016-11-03 16:58

Link

New: This issue is related to JENKINS-39484 [ JENKINS-39484 ]