Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38167

NPE when using properties from @Field in workflow-cps 2.14

XMLWordPrintable

      Scripts using @Field instance initializers which referred to properties on the Script such as binding broke as of workflow-cps 2.14 with

      groovy.lang.GroovyRuntimeException: Failed to create Script instance for class: class WorkflowScript. Reason: java.lang.NullPointerException
	at org.codehaus.groovy.runtime.InvokerHelper.createScript(InvokerHelper.java:430)
	at groovy.lang.GroovyShell.parse(GroovyShell.java:743)
	at org.jenkinsci.plugins.workflow.cps.CpsGroovyShell.reparse(CpsGroovyShell.java:67)
	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.parseScript(CpsFlowExecution.java:410)
	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.start(CpsFlowExecution.java:373)
	at org.jenkinsci.plugins.workflow.job.WorkflowRun.run(WorkflowRun.java:213)
	at hudson.model.ResourceController.execute(ResourceController.java:98)
	at hudson.model.Executor.run(Executor.java:410)
Caused by: java.lang.NullPointerException
	at org.jenkinsci.plugins.workflow.cps.CpsScript.$build(CpsScript.java:137)
	at org.jenkinsci.plugins.workflow.cps.CpsScript.$buildNoException(CpsScript.java:148)
	at org.jenkinsci.plugins.workflow.cps.CpsScript.getProperty(CpsScript.java:125)
	at org.codehaus.groovy.runtime.callsite.PogoGetPropertySite.getProperty(PogoGetPropertySite.java:47)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callGroovyObjectGetProperty(AbstractCallSite.java:231)
	at WorkflowScript.<init>(WorkflowScript:...)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:422)
	at java.lang.Class.newInstance(Class.java:442)
	at org.codehaus.groovy.runtime.InvokerHelper.createScript(InvokerHelper.java:408)
	... 7 more

          [JENKINS-38167] NPE when using properties from @Field in workflow-cps 2.14

          Jesse Glick created issue -
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Jesse Glick made changes -
          Link New: This issue blocks JENKINS-31155 [ JENKINS-31155 ]

          Jesse Glick added a comment -

          Caused by changes made for JENKINS-31155.

          Jesse Glick added a comment - Caused by changes made for JENKINS-31155 .
          Jesse Glick made changes -
          Remote Link New: This issue links to "PR 55 (Web Link)" [ 14835 ]
          Jesse Glick made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          src/main/java/org/jenkinsci/plugins/workflow/cps/CpsScript.java
          src/test/java/org/jenkinsci/plugins/workflow/cps/CpsScriptTest.java
          http://jenkins-ci.org/commit/workflow-cps-plugin/adc9b4cf81be93159f9292b3e0bdbc911da69243
          Log:
          [FIXED JENKINS-38167] NPE from scripts using @Field with instance initializers loading properties.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/workflow/cps/CpsScript.java src/test/java/org/jenkinsci/plugins/workflow/cps/CpsScriptTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/adc9b4cf81be93159f9292b3e0bdbc911da69243 Log: [FIXED JENKINS-38167] NPE from scripts using @Field with instance initializers loading properties.
          Jesse Glick made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Resolved [ 5 ]
          CloudBees Inc. made changes -
          Remote Link New: This issue links to "CloudBees Internal OSS-1435 (Web Link)" [ 18697 ]

          Hari Dara added a comment -

          When is this fix expected to be released?

          Hari Dara added a comment - When is this fix expected to be released?

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: