[JENKINS-38281] Global variables starting with capital letter regression

Type: Bug
Resolution: Unresolved
Priority: Major
Component/s: workflow-cps-global-lib-plugin
Labels:
- robustness
- triaged-2018-11
Environment:
Jenkins: 2.7.4
workflow-cps-global-lib: 2.3

Similar Issues:
Powered by SuggestiMate

Show

Problem

Calling a function like `Myvariable.myFunctionName()` from a global library returns the following error;

org.jenkinsci.plugins.scriptsecurity.sandbox.RejectedAccessException: unclassified method java.lang.Class myFunctionName

This only happens when calling global variables beginning with a capital letter.

Downgrading the workflow-cps-global-lib plugin to v2.0 results in the error going away. Upgrading to v2.1 makes the error appear.

From my point of view this is a regression between v2.0 and v2.1.

Am I not supposed to create global variables starting with a capital letter? This represents a breaking change in some of my global library code.

Steps to reproduce

1. Setup a global library like;

# directory structure
+- vars
 |   +- one.groovy 
 |   +- Two.groovy

# in vars/one.groovy
def call() {
  echo "in one()"
}

def fn() {
  echo "In one.fn()"
}

# in vars/Two.groovy
def call() {
  echo "In Two()"
}

def fn() {
  echo "In Two.fn()"
}

2. Load the global library into jenkins (git push)

3. Create a pipeline job with the following pipeline script

one()
one.fn()

Two()
Two.fn()

Expected Output

[Pipeline] echo
in one()
[Pipeline] echo
In one.fn()
[Pipeline] echo
In Two()
[Pipeline] echo
In Two.fn()

Actual Output

in one()
[Pipeline] echo
In one.fn()
[Pipeline] echo
In Two()
[Pipeline] End of Pipeline
org.jenkinsci.plugins.scriptsecurity.sandbox.RejectedAccessException: unclassified method java.lang.Class fn
	at org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SandboxInterceptor.onMethodCall(SandboxInterceptor.java:113)
	at org.kohsuke.groovy.sandbox.impl.Checker$1.call(Checker.java:149)
	at org.kohsuke.groovy.sandbox.impl.Checker.checkedCall(Checker.java:146)

        [... truncated - full stack trace attached to ticket ...]

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

workflow-cps-global-lib-2.0.png
49 kB
2016-09-16 14:53
workflow-cps-global-lib-2.1.png
210 kB
2016-09-16 14:53
full_stacktrace.txt
3 kB
2016-09-16 14:53

is duplicated by

JENKINS-36673 MissingMethodException When Calling Pipeline Library Function

Resolved

links to

workflow-step-api PR 9

Phil Grayson created issue - 2016-09-16 15:00

Phil Grayson made changes - 2016-09-16 15:12

Description

Original: h3. Problem

Calling a function like `Myvariable.myFunctionName()` from a global library returns the following error;

{code:java}
org.jenkinsci.plugins.scriptsecurity.sandbox.RejectedAccessException: unclassified method java.lang.Class myFunctionName
{code}

This only happens when calling global variables beginning with a capital letter.

Downgrading the workflow-cps-global-lib plugin to v2.0 results in the error going away. Upgrading to v2.1 makes the error appear.

From my point of view this is a regression between v2.0 and v2.1.

Am I not supposed to create global variables starting with a capital letter? This represents a breaking change

h3. Steps to reproduce
1. Setup a global library like;

{code:java}
# directory structure
+- vars
| +- one.groovy
| +- Two.groovy
{code}

{code:java}
# in vars/one.groovy
def call() {
  echo "in one()"
}

def fn() {
  echo "In one.fn()"
}
{code}

{code:java}
# in vars/Two.groovy
def call() {
  echo "In Two()"
}

def fn() {
  echo "In Two.fn()"
}
{code}

2. Load the global library into jenkins (git push)

3. Create a pipeline job with the following pipeline script

{code:java}
one()
one.fn()

Two()
Two.fn()
{code}

h5. Expected Output
{code}
[Pipeline] echo
in one()
[Pipeline] echo
In one.fn()
[Pipeline] echo
In Two()
[Pipeline] echo
In Two.fn()
{code}

h5. Actual Output

{code}
in one()
[Pipeline] echo
In one.fn()
[Pipeline] echo
In Two()
[Pipeline] End of Pipeline
org.jenkinsci.plugins.scriptsecurity.sandbox.RejectedAccessException: unclassified method java.lang.Class fn
at org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SandboxInterceptor.onMethodCall(SandboxInterceptor.java:113)
at org.kohsuke.groovy.sandbox.impl.Checker$1.call(Checker.java:149)
at org.kohsuke.groovy.sandbox.impl.Checker.checkedCall(Checker.java:146)

        [... truncated - full stack trace attached to ticket ...]
{code}

New: h3. Problem

Calling a function like `Myvariable.myFunctionName()` from a global library returns the following error;

{code:java}
org.jenkinsci.plugins.scriptsecurity.sandbox.RejectedAccessException: unclassified method java.lang.Class myFunctionName
{code}

This only happens when calling global variables beginning with a capital letter.

Downgrading the workflow-cps-global-lib plugin to v2.0 results in the error going away. Upgrading to v2.1 makes the error appear.

From my point of view this is a regression between v2.0 and v2.1.

Am I not supposed to create global variables starting with a capital letter? This represents a breaking change in some of my global library code.

h3. Steps to reproduce
1. Setup a global library like;

{code:java}
# directory structure
+- vars
| +- one.groovy
| +- Two.groovy
{code}

{code:java}
# in vars/one.groovy
def call() {
  echo "in one()"
}

def fn() {
  echo "In one.fn()"
}
{code}

{code:java}
# in vars/Two.groovy
def call() {
  echo "In Two()"
}

def fn() {
  echo "In Two.fn()"
}
{code}

2. Load the global library into jenkins (git push)

3. Create a pipeline job with the following pipeline script

{code:java}
one()
one.fn()

Two()
Two.fn()
{code}

h5. Expected Output
{code}
[Pipeline] echo
in one()
[Pipeline] echo
In one.fn()
[Pipeline] echo
In Two()
[Pipeline] echo
In Two.fn()
{code}

h5. Actual Output

{code}
in one()
[Pipeline] echo
In one.fn()
[Pipeline] echo
In Two()
[Pipeline] End of Pipeline
org.jenkinsci.plugins.scriptsecurity.sandbox.RejectedAccessException: unclassified method java.lang.Class fn
at org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SandboxInterceptor.onMethodCall(SandboxInterceptor.java:113)
at org.kohsuke.groovy.sandbox.impl.Checker$1.call(Checker.java:149)
at org.kohsuke.groovy.sandbox.impl.Checker.checkedCall(Checker.java:146)

        [... truncated - full stack trace attached to ticket ...]
{code}

Jesse Glick added a comment - 2016-10-04 19:16

Am I not supposed to create global variables starting with a capital letter?

No, variable names must start with a lowercase letter. Probably the plugin should enforce this directly.

Jesse Glick added a comment - 2016-10-04 19:16 Am I not supposed to create global variables starting with a capital letter? No, variable names must start with a lowercase letter. Probably the plugin should enforce this directly.

Jesse Glick made changes - 2016-10-04 19:18

Link

New: This issue is duplicated by ~~JENKINS-36673~~ [ ~~JENKINS-36673~~ ]

Phil Grayson added a comment - 2016-10-04 21:32

Thank you for the update. I've migrated my affected code since.

I'm happy for this ticket to be closed and I can raise a low priority feature request if you like.

Phil Grayson added a comment - 2016-10-04 21:32 Thank you for the update. I've migrated my affected code since. I'm happy for this ticket to be closed and I can raise a low priority feature request if you like.

Jesse Glick added a comment - 2016-10-05 18:28

Can just leave this for the robustness fix.

Jesse Glick added a comment - 2016-10-05 18:28 Can just leave this for the robustness fix.

Jesse Glick made changes - 2016-10-05 18:45

Remote Link

New: This issue links to "workflow-step-api PR 9 (Web Link)" [ 14923 ]

Jesse Glick made changes - 2017-02-10 21:02

Labels

New: robustness

Vivek Pandey made changes - 2018-11-16 16:44

Labels

Original: robustness

New: robustness triaged-2018-11

Assignee:: Jesse Glick

Reporter:: Phil Grayson

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Created:: 2016-09-16 15:00

Updated:: 2018-11-16 16:44

Jenkins

Details

Description

Problem

Steps to reproduce

Expected Output

Actual Output

Attachments

Attachments

Issue Links

Activity

Collapse comment: Jesse Glick added a comment - 2016-10-04 19:16

Expand comment: Jesse Glick added a comment - 2016-10-04 19:16

Collapse comment: Phil Grayson added a comment - 2016-10-04 21:32

Expand comment: Phil Grayson added a comment - 2016-10-04 21:32

Collapse comment: Jesse Glick added a comment - 2016-10-05 18:28

Expand comment: Jesse Glick added a comment - 2016-10-05 18:28

People

Dates