Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38307

ATH erroneously installs detached plugins, causing needless restarts

XMLWordPrintable

      The acceptance test harness must restart Jenkins after plugin installation due to the fact that outdated, detached plugins are installed by default. As per this outdated commit, it looks like the intent is just to fix failing tests which have never had to declare detached plugins in their WithPlugins.

      One impact of this is that almost every test case must restart Jenkins because it installs updated plugins over the existing detached ones, which prevents dynamic deployment from working.

      I think we actually must take the hard path here and fix up the WithPlugins to be accurate.

          [JENKINS-38307] ATH erroneously installs detached plugins, causing needless restarts

          Ryan Campbell created issue -
          Ryan Campbell made changes -
          Description Original: The acceptance test harness must restart Jenkins after plugin installation due to the fact that outdated, [detached plugins are installed|https://github.com/jenkinsci/acceptance-test-harness/blob/c1512e4da9dc3b4dd701988dae103eaec405ec25/src/main/java/org/jenkinsci/test/acceptance/controller/LocalController.java#L182] by default. As per this [outdated commit|https://github.com/jenkinsci/acceptance-test-harness/commit/61e55fa7517efd2ee41b61312d6659c0ce31d0a2], it looks like the intent is just to fix failing tests which have never had to declare detached plugins in their WithPlugins.

          I think we actually must take the hard path here and fix up the WithPlugins to be accurate.           		New: The acceptance test harness must restart Jenkins after plugin installation due to the fact that outdated, [detached plugins are installed|https://github.com/jenkinsci/acceptance-test-harness/blob/c1512e4da9dc3b4dd701988dae103eaec405ec25/src/main/java/org/jenkinsci/test/acceptance/controller/LocalController.java#L182] by default. As per this [outdated commit|https://github.com/jenkinsci/acceptance-test-harness/commit/61e55fa7517efd2ee41b61312d6659c0ce31d0a2], it looks like the intent is just to fix failing tests which have never had to declare detached plugins in their WithPlugins.

          One impact of this is that almost every test case must restart Jenkins because it installs updated plugins over the existing detached ones, which prevents dynamic deployment from working.

          I think we actually must take the hard path here and fix up the WithPlugins to be accurate.
          Ryan Campbell made changes -
          Assignee Original: Oliver Gondža [ olivergondza ] New: Ryan Campbell [ recampbell ]
          Ryan Campbell made changes -
          Remote Link New: This issue links to "PR (Web Link)" [ 14850 ]
          Ryan Campbell made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Ryan Campbell made changes -
          Link New: This issue is blocked by JENKINS-37545 [ JENKINS-37545 ]
          Jesse Glick made changes -
          Link New: This issue relates to JENKINS-40092 [ JENKINS-40092 ]
          Jesse Glick made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

            recampbell Ryan Campbell
            recampbell Ryan Campbell
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: