Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38390

Timestamp background color white

    XMLWordPrintable

Details

    Description

      This is the theme URL I'm using:
      https://jenkins-contrib-themes.github.io/jenkins-material-theme/dist/material-light-blue.css

      Then I have a build with the timestamp and ansi color wrappers and one shell step that does this:

      #!/bin/bash

echo "This looks terrible"
echo -e "\e[31m This is red\e[0m"
echo -e "\e[32m This doesn't reset"
echo "The end"

      The attached screenshot is the build output. It does not do this with timestamper 1.8.4 (which we had previously).

      This seems to be related to JENKINS-34019

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-38573 Timestamp CSS style is problematic

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-34019 ANSIColor plugin leaks format onto next line's timestamp

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Reopened

          Activity

            Ascending order - Click to sort in descending order
            stevengbrown Steven G Brown added a comment -

            Another example can be found here: JENKINS-38573.

            stevengbrown Steven G Brown added a comment - Another example can be found here: JENKINS-38573 .
            stevengbrown Steven G Brown added a comment -

            I'm at a loss. Any ideas how to fix this without reintroducing JENKINS-34019 ?

            stevengbrown Steven G Brown added a comment - I'm at a loss. Any ideas how to fix this without reintroducing JENKINS-34019 ?
            dankirkd Daniel Kirkdorffer added a comment - - edited

            stevengbrown Why can't you use the suggestion borgstrom made in the comments of JENKINS-34019 and here https://github.com/jenkinsci/timestamper-plugin/commit/c31dc9571d5d1121d3f7e43d81059e0818e58b7a#commitcomment-19199648?

            dankirkd Daniel Kirkdorffer added a comment - - edited stevengbrown Why can't you use the suggestion borgstrom made in the comments of JENKINS-34019 and here https://github.com/jenkinsci/timestamper-plugin/commit/c31dc9571d5d1121d3f7e43d81059e0818e58b7a#commitcomment-19199648?
            stevengbrown Steven G Brown added a comment -

            That would fix this issue, but reintroduce JENKINS-34019. (The white background for the timestamps overrides the styling applied by the AnsiColor plugin.) I'd like to have a plan for dealing with both.

            stevengbrown Steven G Brown added a comment - That would fix this issue, but reintroduce JENKINS-34019 . (The white background for the timestamps overrides the styling applied by the AnsiColor plugin.) I'd like to have a plan for dealing with both.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Steven Brown
            Path:
            src/main/resources/hudson/plugins/timestamper/annotator/TimestampAnnotatorFactory2/style.css
            http://jenkins-ci.org/commit/timestamper-plugin/6b763a9b72afa21d7f3fe3a8e850612029bac335
            Log:
            JENKINS-38390 JENKINS-34019 Revert timestamps style added by c31dc95

            The style matched the default Jenkins theme, but clashed with custom themes.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Steven Brown Path: src/main/resources/hudson/plugins/timestamper/annotator/TimestampAnnotatorFactory2/style.css http://jenkins-ci.org/commit/timestamper-plugin/6b763a9b72afa21d7f3fe3a8e850612029bac335 Log: JENKINS-38390 JENKINS-34019 Revert timestamps style added by c31dc95 The style matched the default Jenkins theme, but clashed with custom themes.
            stevengbrown Steven G Brown added a comment -

            All changes made under JENKINS-34019 have been reverted. I have an idea about how it can be fixed within the AnsiColor plugin instead.

            Custom themes should look normal again.

            Fix released with Timestamper 1.8.7.

            stevengbrown Steven G Brown added a comment - All changes made under JENKINS-34019 have been reverted. I have an idea about how it can be fixed within the AnsiColor plugin instead. Custom themes should look normal again. Fix released with Timestamper 1.8.7.
            dankirkd Daniel Kirkdorffer added a comment -

            Fixed verified. Thanks.

            dankirkd Daniel Kirkdorffer added a comment - Fixed verified. Thanks.

            People

              stevengbrown Steven G Brown
              b_dean Ben Dean
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: