-
Improvement
-
Resolution: Fixed
-
Major
-
None
DepthFirstScanner in the graphanalysis APIs works, but the API mandates that it visit the first node then the branches after (but in reverse order).
Instead we should visit the branches in order for drop-in compatibility with FlowGraphWalker
This will, incidentally, fix JENKINS-38457.
- relates to
-
JENKINS-38457 FlowGraphTable shows parallel branches out of order
-
- Resolved
-
[JENKINS-38458] Mandate consistent iteration order for DepthFirstScanner
Sam Van Oort
created issue -
Sam Van Oort
made changes -
| Assignee | New: Sam Van Oort [ svanoort ] |
| Description |
Original:
DepthFirstScanner in the graphanalysis APIs works, but the API mandates that it visit the *first* node then the branches after (but in reverse order). Instead we should visit the last first, then then others, as with ForkScanner in [ This will, incidentally, fix https://issues.jenkins-ci.org/browse/JENKINS-38381 too. |
New:
DepthFirstScanner in the graphanalysis APIs works, but the API mandates that it visit the *first* node then the branches after (but in reverse order). Instead we should visit the last first, then then others, as with ForkScanner in This will, incidentally, fix |
Does not fix JENKINS-38457, since that requires FlowGraphTable to also reverse its parallel branches.
| Link |
New:
This issue relates to |
Code changed in jenkins
User: Sam Van Oort
Path:
src/main/java/org/jenkinsci/plugins/workflow/graphanalysis/DepthFirstScanner.java
http://jenkins-ci.org/commit/workflow-api-plugin/3baae43984b507100343473c61c6c7615085d02e
Log:
Make DepthFirstScanner obey last->first parallel branch ordering per JENKINS-38458
Sam Van Oort
made changes -
| Description |
Original:
DepthFirstScanner in the graphanalysis APIs works, but the API mandates that it visit the *first* node then the branches after (but in reverse order). Instead we should visit the last first, then then others, as with ForkScanner in This will, incidentally, fix |
New:
DepthFirstScanner in the graphanalysis APIs works, but the API mandates that it visit the *first* node then the branches after (but in reverse order). Instead we should visit the branches in order for drop-in compatibility with FlowGraphWalker This will, incidentally, fix |
Sam Van Oort
made changes -
| Description |
Original:
DepthFirstScanner in the graphanalysis APIs works, but the API mandates that it visit the *first* node then the branches after (but in reverse order). Instead we should visit the branches in order for drop-in compatibility with FlowGraphWalker This will, incidentally, fix |
New:
DepthFirstScanner in the graphanalysis APIs works, but the API mandates that it visit the *first* node then the branches after (but in reverse order). Instead we should visit the branches in order for drop-in compatibility with FlowGraphWalker This will, incidentally, fix |
Sam Van Oort
made changes -
| Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
JENKINS-38457did you mean?