Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38458

Mandate consistent iteration order for DepthFirstScanner

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • workflow-api-plugin
    • None

      DepthFirstScanner in the graphanalysis APIs works, but the API mandates that it visit the first node then the branches after (but in reverse order).

      Instead we should visit the branches in order for drop-in compatibility with FlowGraphWalker

      This will, incidentally, fix JENKINS-38457.

          [JENKINS-38458] Mandate consistent iteration order for DepthFirstScanner

          Sam Van Oort created issue -
          Sam Van Oort made changes -
          Assignee New: Sam Van Oort [ svanoort ]
          Jesse Glick made changes -
          Description Original: DepthFirstScanner in the graphanalysis APIs works, but the API mandates that it visit the *first* node then the branches after (but in reverse order).

          Instead we should visit the last first, then then others, as with ForkScanner in [JENKINS-38309|https://issues.jenkins-ci.org/browse/JENKINS-38309].

          This will, incidentally, fix https://issues.jenkins-ci.org/browse/JENKINS-38381 too.
          New: DepthFirstScanner in the graphanalysis APIs works, but the API mandates that it visit the *first* node then the branches after (but in reverse order).

          Instead we should visit the last first, then then others, as with ForkScanner in JENKINS-38309.

          This will, incidentally, fix JENKINS-38381 too.
          Jesse Glick made changes -
          Link New: This issue relates to JENKINS-38457 [ JENKINS-38457 ]
          Sam Van Oort made changes -
          Description Original: DepthFirstScanner in the graphanalysis APIs works, but the API mandates that it visit the *first* node then the branches after (but in reverse order).

          Instead we should visit the last first, then then others, as with ForkScanner in JENKINS-38309.

          This will, incidentally, fix JENKINS-38381 too.
          New: DepthFirstScanner in the graphanalysis APIs works, but the API mandates that it visit the *first* node then the branches after (but in reverse order).

          Instead we should visit the branches in order for drop-in compatibility with FlowGraphWalker

          This will, incidentally, fix JENKINS-38381.
          Sam Van Oort made changes -
          Description Original: DepthFirstScanner in the graphanalysis APIs works, but the API mandates that it visit the *first* node then the branches after (but in reverse order).

          Instead we should visit the branches in order for drop-in compatibility with FlowGraphWalker

          This will, incidentally, fix JENKINS-38381.
          New: DepthFirstScanner in the graphanalysis APIs works, but the API mandates that it visit the *first* node then the branches after (but in reverse order).

          Instead we should visit the branches in order for drop-in compatibility with FlowGraphWalker

          This will, incidentally, fix JENKINS-38457.
          Sam Van Oort made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Sam Van Oort made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Sam Van Oort made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Closed [ 6 ]

            svanoort Sam Van Oort
            svanoort Sam Van Oort
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: