Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38691

Sub-par write performance in JNLPv4 NIONetwork layer

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Fix
    • Icon: Major Major
    • remoting
    • None

      The JNLP v2 protocol has a sub par write implementation if there is more than one buffers worth of data to be written to the network.
      The current implementation writes one buffers worth and then exits - waiting for another callback from the selector before writing another buffer.
      The code should write as much data as possible before returning back.

      see https://github.com/jenkinsci/remoting/blob/c3e675c9f1dc29a8fd99eca191c1ce1e5ebb2a7e/src/main/java/org/jenkinsci/remoting/protocol/impl/NIONetworkLayer.java#L191-L227

          [JENKINS-38691] Sub-par write performance in JNLPv4 NIONetwork layer

          James Nord created issue -

          James Nord added a comment - - edited

          stephenconnolly looked at this and tried an implementation - but it did not improve performance and used more heap

          James Nord added a comment - - edited stephenconnolly looked at this and tried an implementation - but it did not improve performance and used more heap
          James Nord made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Closed [ 6 ]
          James Nord made changes -
          Resolution Original: Fixed [ 1 ]
          Status Original: Closed [ 6 ] New: Reopened [ 4 ]
          James Nord made changes -
          Resolution New: Won't Fix [ 2 ]
          Status Original: Reopened [ 4 ] New: Closed [ 6 ]
          CloudBees Inc. made changes -
          Remote Link New: This issue links to "CloudBees Internal OSS-1519 (Web Link)" [ 18668 ]
          James Nord made changes -
          Assignee Original: James Nord [ teilo ]

            Unassigned Unassigned
            teilo James Nord
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: