Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38960

Deprecate TopLevelItemDescriptor.getIconFilePathPattern() and TopLevelItemDescriptor.getIconFile(String)

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • core
    • None

    Description

      These two methods were introduced in Jenkins 2.0

      Given that IconSet and IconSpec have been available since August 2014, the Icon classes should actually have been used instead of hardcoding a path.

      Attachments

        Issue Links

          links to

          Web Link CloudBees Internal OSS-1546

          Activity

            Ascending order - Click to sort in descending order
            View 12 older comments
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/hudson/maven/MavenModuleSet.java
            http://jenkins-ci.org/commit/maven-plugin/de1d63daf7c9d5411d199f48e98bc07dfe930412
            Log:
            [JENKINS-38960 Follow-up] Switch to IconSet

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/maven/MavenModuleSet.java http://jenkins-ci.org/commit/maven-plugin/de1d63daf7c9d5411d199f48e98bc07dfe930412 Log: [JENKINS-38960 Follow-up] Switch to IconSet
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/images/make-inkscape.sh
            src/images/mavenmoduleset.svg
            src/main/webapp/images/16x16/mavenmoduleset.png
            src/main/webapp/images/24x24/mavenmoduleset.png
            src/main/webapp/images/32x32/mavenmoduleset.png
            src/main/webapp/images/48x48/mavenmoduleset.png
            http://jenkins-ci.org/commit/maven-plugin/3bff1bbce4f2490c9e3820ab9e4453c78159642b
            Log:
            [JENKINS-38960 Follow-up] We don't have the rights to use the Apache Feather

            • The Maven Mascot is permitted to be used, so we will use the mascot
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/images/make-inkscape.sh src/images/mavenmoduleset.svg src/main/webapp/images/16x16/mavenmoduleset.png src/main/webapp/images/24x24/mavenmoduleset.png src/main/webapp/images/32x32/mavenmoduleset.png src/main/webapp/images/48x48/mavenmoduleset.png http://jenkins-ci.org/commit/maven-plugin/3bff1bbce4f2490c9e3820ab9e4453c78159642b Log: [JENKINS-38960 Follow-up] We don't have the rights to use the Apache Feather The Maven Mascot is permitted to be used, so we will use the mascot
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/images/mavenmoduleset.svg
            src/main/webapp/images/16x16/mavenmoduleset.png
            src/main/webapp/images/24x24/mavenmoduleset.png
            src/main/webapp/images/32x32/mavenmoduleset.png
            src/main/webapp/images/48x48/mavenmoduleset.png
            http://jenkins-ci.org/commit/maven-plugin/d658fe9568ede15cadc26449e50193ab25a2f82b
            Log:
            [JENKINS-38960 Follow-up] Tweak the image

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/images/mavenmoduleset.svg src/main/webapp/images/16x16/mavenmoduleset.png src/main/webapp/images/24x24/mavenmoduleset.png src/main/webapp/images/32x32/mavenmoduleset.png src/main/webapp/images/48x48/mavenmoduleset.png http://jenkins-ci.org/commit/maven-plugin/d658fe9568ede15cadc26449e50193ab25a2f82b Log: [JENKINS-38960 Follow-up] Tweak the image
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/images/make-inkscape.sh
            src/images/mavenmoduleset.svg
            src/main/java/hudson/maven/MavenModuleSet.java
            src/main/webapp/images/16x16/mavenmoduleset.png
            src/main/webapp/images/24x24/mavenmoduleset.png
            src/main/webapp/images/32x32/mavenmoduleset.png
            src/main/webapp/images/48x48/mavenmoduleset.png
            http://jenkins-ci.org/commit/maven-plugin/6fcec84df690187a104d57c1b40916053d42fdad
            Log:
            Merge pull request #84 from stephenc/jenkins-38960-followup

            [JENKINS-38960 Follow-up] Switch to IconSpec

            Compare: https://github.com/jenkinsci/maven-plugin/compare/4b29ab88fa1b...6fcec84df690

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/images/make-inkscape.sh src/images/mavenmoduleset.svg src/main/java/hudson/maven/MavenModuleSet.java src/main/webapp/images/16x16/mavenmoduleset.png src/main/webapp/images/24x24/mavenmoduleset.png src/main/webapp/images/32x32/mavenmoduleset.png src/main/webapp/images/48x48/mavenmoduleset.png http://jenkins-ci.org/commit/maven-plugin/6fcec84df690187a104d57c1b40916053d42fdad Log: Merge pull request #84 from stephenc/jenkins-38960-followup [JENKINS-38960 Follow-up] Switch to IconSpec Compare: https://github.com/jenkinsci/maven-plugin/compare/4b29ab88fa1b...6fcec84df690
            oleg_nenashev Oleg Nenashev added a comment -

            The fix is integrated towards 2.27

            oleg_nenashev Oleg Nenashev added a comment - The fix is integrated towards 2.27

            People

              stephenconnolly Stephen Connolly
              stephenconnolly Stephen Connolly
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: