Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38960

Deprecate TopLevelItemDescriptor.getIconFilePathPattern() and TopLevelItemDescriptor.getIconFile(String)

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None

      These two methods were introduced in Jenkins 2.0

      Given that IconSet and IconSpec have been available since August 2014, the Icon classes should actually have been used instead of hardcoding a path.

          [JENKINS-38960] Deprecate TopLevelItemDescriptor.getIconFilePathPattern() and TopLevelItemDescriptor.getIconFile(String)

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/images/folder.svg
          src/images/make-inkscape.sh
          src/main/java/com/cloudbees/hudson/plugins/folder/Folder.java
          src/main/java/com/cloudbees/hudson/plugins/folder/FolderIcon.java
          src/main/java/com/cloudbees/hudson/plugins/folder/icons/StockFolderIcon.java
          src/main/java/com/cloudbees/hudson/plugins/folder/relocate/RelocationAction.java
          src/main/java/com/cloudbees/hudson/plugins/folder/relocate/RelocationUI.java
          src/main/resources/com/cloudbees/hudson/plugins/folder/relocate/DefaultRelocationUI/main.jelly
          src/main/webapp/images/16x16/folder.png
          src/main/webapp/images/24x24/folder.png
          src/main/webapp/images/32x32/folder.png
          src/main/webapp/images/48x48/folder.png
          http://jenkins-ci.org/commit/cloudbees-folder-plugin/5dfa20ed76a05b59120939e2b958f332d5862c16
          Log:
          [JENKINS-38960 Follow-up] Switch to IconSet

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/images/folder.svg src/images/make-inkscape.sh src/main/java/com/cloudbees/hudson/plugins/folder/Folder.java src/main/java/com/cloudbees/hudson/plugins/folder/FolderIcon.java src/main/java/com/cloudbees/hudson/plugins/folder/icons/StockFolderIcon.java src/main/java/com/cloudbees/hudson/plugins/folder/relocate/RelocationAction.java src/main/java/com/cloudbees/hudson/plugins/folder/relocate/RelocationUI.java src/main/resources/com/cloudbees/hudson/plugins/folder/relocate/DefaultRelocationUI/main.jelly src/main/webapp/images/16x16/folder.png src/main/webapp/images/24x24/folder.png src/main/webapp/images/32x32/folder.png src/main/webapp/images/48x48/folder.png http://jenkins-ci.org/commit/cloudbees-folder-plugin/5dfa20ed76a05b59120939e2b958f332d5862c16 Log: [JENKINS-38960 Follow-up] Switch to IconSet

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
          src/main/webapp/images/48x48/github-scmnavigator.png
          http://jenkins-ci.org/commit/github-branch-source-plugin/c94b4f076ebfde87b6793487d69dea1fecd8347d
          Log:
          [JENKINS-38960 Follow-up] Switch to IconSet

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java src/main/webapp/images/48x48/github-scmnavigator.png http://jenkins-ci.org/commit/github-branch-source-plugin/c94b4f076ebfde87b6793487d69dea1fecd8347d Log: [JENKINS-38960 Follow-up] Switch to IconSet

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/branch/CustomOrganizationFolderDescriptor.java
          http://jenkins-ci.org/commit/branch-api-plugin/648edd2b35925f9a491d3b35fc0ce92485304271
          Log:
          [JENKINS-38960 Follow-up] Switch to IconSet

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/branch/CustomOrganizationFolderDescriptor.java http://jenkins-ci.org/commit/branch-api-plugin/648edd2b35925f9a491d3b35fc0ce92485304271 Log: [JENKINS-38960 Follow-up] Switch to IconSet

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/images/github-scmnavigator.svg
          src/images/make-inkscape.sh
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
          src/main/webapp/images/16x16/github-scmnavigator.png
          src/main/webapp/images/24x24/github-scmnavigator.png
          src/main/webapp/images/32x32/github-scmnavigator.png
          src/main/webapp/images/48x48/github-scmnavigator.png
          http://jenkins-ci.org/commit/github-branch-source-plugin/f14427b130c465bd43e9af76be9c47050e3c6ce3
          Log:
          [JENKINS-38960 Follow-up] Switch to IconSet

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/images/github-scmnavigator.svg src/images/make-inkscape.sh src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java src/main/webapp/images/16x16/github-scmnavigator.png src/main/webapp/images/24x24/github-scmnavigator.png src/main/webapp/images/32x32/github-scmnavigator.png src/main/webapp/images/48x48/github-scmnavigator.png http://jenkins-ci.org/commit/github-branch-source-plugin/f14427b130c465bd43e9af76be9c47050e3c6ce3 Log: [JENKINS-38960 Follow-up] Switch to IconSet

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          http://jenkins-ci.org/commit/branch-api-plugin/66823d0c6bc1a04cc3087a60ec88fe454fed20a8
          Log:
          [JENKINS-38960 Follow-up] Need latest scm-api

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml http://jenkins-ci.org/commit/branch-api-plugin/66823d0c6bc1a04cc3087a60ec88fe454fed20a8 Log: [JENKINS-38960 Follow-up] Need latest scm-api

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/branch/CustomOrganizationFolderDescriptor.java
          http://jenkins-ci.org/commit/branch-api-plugin/3645881cb775782935b6048bb322bc63c520813b
          Log:
          Merge pull request #51 from jenkinsci/use-iconset

          [JENKINS-38960 Follow-up] Switch to IconSet

          Compare: https://github.com/jenkinsci/branch-api-plugin/compare/637eeced2a9a...3645881cb775

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/branch/CustomOrganizationFolderDescriptor.java http://jenkins-ci.org/commit/branch-api-plugin/3645881cb775782935b6048bb322bc63c520813b Log: Merge pull request #51 from jenkinsci/use-iconset [JENKINS-38960 Follow-up] Switch to IconSet Compare: https://github.com/jenkinsci/branch-api-plugin/compare/637eeced2a9a...3645881cb775

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/images/folder.svg
          src/images/make-inkscape.sh
          src/main/java/com/cloudbees/hudson/plugins/folder/Folder.java
          src/main/java/com/cloudbees/hudson/plugins/folder/FolderIcon.java
          src/main/java/com/cloudbees/hudson/plugins/folder/icons/StockFolderIcon.java
          src/main/java/com/cloudbees/hudson/plugins/folder/relocate/RelocationAction.java
          src/main/java/com/cloudbees/hudson/plugins/folder/relocate/RelocationUI.java
          src/main/resources/com/cloudbees/hudson/plugins/folder/relocate/DefaultRelocationUI/main.jelly
          src/main/webapp/images/16x16/folder.png
          src/main/webapp/images/24x24/folder.png
          src/main/webapp/images/32x32/folder.png
          src/main/webapp/images/48x48/folder.png
          http://jenkins-ci.org/commit/cloudbees-folder-plugin/fc2cff09dfc0282a9d83fc5d0f68d1ba872cd88f
          Log:
          Merge pull request #71 from jenkinsci/use-iconset

          [JENKINS-38960 Follow-up] Switch to IconSet

          Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/ac5476606a67...fc2cff09dfc0

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/images/folder.svg src/images/make-inkscape.sh src/main/java/com/cloudbees/hudson/plugins/folder/Folder.java src/main/java/com/cloudbees/hudson/plugins/folder/FolderIcon.java src/main/java/com/cloudbees/hudson/plugins/folder/icons/StockFolderIcon.java src/main/java/com/cloudbees/hudson/plugins/folder/relocate/RelocationAction.java src/main/java/com/cloudbees/hudson/plugins/folder/relocate/RelocationUI.java src/main/resources/com/cloudbees/hudson/plugins/folder/relocate/DefaultRelocationUI/main.jelly src/main/webapp/images/16x16/folder.png src/main/webapp/images/24x24/folder.png src/main/webapp/images/32x32/folder.png src/main/webapp/images/48x48/folder.png http://jenkins-ci.org/commit/cloudbees-folder-plugin/fc2cff09dfc0282a9d83fc5d0f68d1ba872cd88f Log: Merge pull request #71 from jenkinsci/use-iconset [JENKINS-38960 Follow-up] Switch to IconSet Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/ac5476606a67...fc2cff09dfc0

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/images/github-scmnavigator.svg
          src/images/make-inkscape.sh
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
          src/main/webapp/images/16x16/github-scmnavigator.png
          src/main/webapp/images/24x24/github-scmnavigator.png
          src/main/webapp/images/32x32/github-scmnavigator.png
          src/main/webapp/images/48x48/github-scmnavigator.png
          http://jenkins-ci.org/commit/github-branch-source-plugin/794434f40178e45cebc0226a9deb29764735dbe5
          Log:
          Merge pull request #80 from jenkinsci/use-iconset

          [JENKINS-38960 Follow-up] Switch to IconSet

          Compare: https://github.com/jenkinsci/github-branch-source-plugin/compare/ac752a236b87...794434f40178

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/images/github-scmnavigator.svg src/images/make-inkscape.sh src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java src/main/webapp/images/16x16/github-scmnavigator.png src/main/webapp/images/24x24/github-scmnavigator.png src/main/webapp/images/32x32/github-scmnavigator.png src/main/webapp/images/48x48/github-scmnavigator.png http://jenkins-ci.org/commit/github-branch-source-plugin/794434f40178e45cebc0226a9deb29764735dbe5 Log: Merge pull request #80 from jenkinsci/use-iconset [JENKINS-38960 Follow-up] Switch to IconSet Compare: https://github.com/jenkinsci/github-branch-source-plugin/compare/ac752a236b87...794434f40178

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/images/make-inkscape.sh
          src/images/pipelinemultibranchproject.svg
          src/main/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProject.java
          src/main/webapp/images/16x16/pipelinemultibranchproject.png
          src/main/webapp/images/24x24/pipelinemultibranchproject.png
          src/main/webapp/images/32x32/pipelinemultibranchproject.png
          src/main/webapp/images/48x48/pipelinemultibranchproject.png
          http://jenkins-ci.org/commit/workflow-multibranch-plugin/ab6484210720ad708f9d183420507d4ba0cbbd9a
          Log:
          [JENKINS-38960 Follow-up] Switch to IconSet

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/images/make-inkscape.sh src/images/pipelinemultibranchproject.svg src/main/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProject.java src/main/webapp/images/16x16/pipelinemultibranchproject.png src/main/webapp/images/24x24/pipelinemultibranchproject.png src/main/webapp/images/32x32/pipelinemultibranchproject.png src/main/webapp/images/48x48/pipelinemultibranchproject.png http://jenkins-ci.org/commit/workflow-multibranch-plugin/ab6484210720ad708f9d183420507d4ba0cbbd9a Log: [JENKINS-38960 Follow-up] Switch to IconSet

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/images/make-inkscape.sh
          src/images/pipelinemultibranchproject.svg
          src/main/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProject.java
          src/main/webapp/images/16x16/pipelinemultibranchproject.png
          src/main/webapp/images/24x24/pipelinemultibranchproject.png
          src/main/webapp/images/32x32/pipelinemultibranchproject.png
          src/main/webapp/images/48x48/pipelinemultibranchproject.png
          http://jenkins-ci.org/commit/workflow-multibranch-plugin/7d126dfd895519740bb2bfaf1504ae62b0070ddd
          Log:
          Merge pull request #38 from jenkinsci/jenkins-38960-follow-up

          [JENKINS-38960 Follow-up] Switch to IconSet

          Compare: https://github.com/jenkinsci/workflow-multibranch-plugin/compare/00e1e44d7e0f...7d126dfd8955

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/images/make-inkscape.sh src/images/pipelinemultibranchproject.svg src/main/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProject.java src/main/webapp/images/16x16/pipelinemultibranchproject.png src/main/webapp/images/24x24/pipelinemultibranchproject.png src/main/webapp/images/32x32/pipelinemultibranchproject.png src/main/webapp/images/48x48/pipelinemultibranchproject.png http://jenkins-ci.org/commit/workflow-multibranch-plugin/7d126dfd895519740bb2bfaf1504ae62b0070ddd Log: Merge pull request #38 from jenkinsci/jenkins-38960-follow-up [JENKINS-38960 Follow-up] Switch to IconSet Compare: https://github.com/jenkinsci/workflow-multibranch-plugin/compare/00e1e44d7e0f...7d126dfd8955

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/com/cloudbees/hudson/plugins/folder/FolderIcon.java
          src/main/java/com/cloudbees/hudson/plugins/folder/icons/StockFolderIcon.java
          http://jenkins-ci.org/commit/cloudbees-folder-plugin/9c718a0f35c3746d66c9786fd957eaeaaab2d2b5
          Log:
          [JENKINS-38960 Follow-up] Make the IconSpec API for FolderIcon more reusable

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/com/cloudbees/hudson/plugins/folder/FolderIcon.java src/main/java/com/cloudbees/hudson/plugins/folder/icons/StockFolderIcon.java http://jenkins-ci.org/commit/cloudbees-folder-plugin/9c718a0f35c3746d66c9786fd957eaeaaab2d2b5 Log: [JENKINS-38960 Follow-up] Make the IconSpec API for FolderIcon more reusable

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          core/src/main/java/hudson/model/FreeStyleProject.java
          core/src/main/java/hudson/model/TopLevelItemDescriptor.java
          core/src/main/java/hudson/model/View.java
          http://jenkins-ci.org/commit/jenkins/bd834fe831b14a0658594ab6b3a4a68a8f3de808
          Log:
          [FIXED JENKINS-38960] Deprecate getIconFilePathPattern and switch to IconSpec

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/hudson/model/FreeStyleProject.java core/src/main/java/hudson/model/TopLevelItemDescriptor.java core/src/main/java/hudson/model/View.java http://jenkins-ci.org/commit/jenkins/bd834fe831b14a0658594ab6b3a4a68a8f3de808 Log: [FIXED JENKINS-38960] Deprecate getIconFilePathPattern and switch to IconSpec

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/hudson/maven/MavenModuleSet.java
          http://jenkins-ci.org/commit/maven-plugin/de1d63daf7c9d5411d199f48e98bc07dfe930412
          Log:
          [JENKINS-38960 Follow-up] Switch to IconSet

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/maven/MavenModuleSet.java http://jenkins-ci.org/commit/maven-plugin/de1d63daf7c9d5411d199f48e98bc07dfe930412 Log: [JENKINS-38960 Follow-up] Switch to IconSet

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/images/make-inkscape.sh
          src/images/mavenmoduleset.svg
          src/main/webapp/images/16x16/mavenmoduleset.png
          src/main/webapp/images/24x24/mavenmoduleset.png
          src/main/webapp/images/32x32/mavenmoduleset.png
          src/main/webapp/images/48x48/mavenmoduleset.png
          http://jenkins-ci.org/commit/maven-plugin/3bff1bbce4f2490c9e3820ab9e4453c78159642b
          Log:
          [JENKINS-38960 Follow-up] We don't have the rights to use the Apache Feather

          • The Maven Mascot is permitted to be used, so we will use the mascot

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/images/make-inkscape.sh src/images/mavenmoduleset.svg src/main/webapp/images/16x16/mavenmoduleset.png src/main/webapp/images/24x24/mavenmoduleset.png src/main/webapp/images/32x32/mavenmoduleset.png src/main/webapp/images/48x48/mavenmoduleset.png http://jenkins-ci.org/commit/maven-plugin/3bff1bbce4f2490c9e3820ab9e4453c78159642b Log: [JENKINS-38960 Follow-up] We don't have the rights to use the Apache Feather The Maven Mascot is permitted to be used, so we will use the mascot

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/images/mavenmoduleset.svg
          src/main/webapp/images/16x16/mavenmoduleset.png
          src/main/webapp/images/24x24/mavenmoduleset.png
          src/main/webapp/images/32x32/mavenmoduleset.png
          src/main/webapp/images/48x48/mavenmoduleset.png
          http://jenkins-ci.org/commit/maven-plugin/d658fe9568ede15cadc26449e50193ab25a2f82b
          Log:
          [JENKINS-38960 Follow-up] Tweak the image

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/images/mavenmoduleset.svg src/main/webapp/images/16x16/mavenmoduleset.png src/main/webapp/images/24x24/mavenmoduleset.png src/main/webapp/images/32x32/mavenmoduleset.png src/main/webapp/images/48x48/mavenmoduleset.png http://jenkins-ci.org/commit/maven-plugin/d658fe9568ede15cadc26449e50193ab25a2f82b Log: [JENKINS-38960 Follow-up] Tweak the image

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/images/make-inkscape.sh
          src/images/mavenmoduleset.svg
          src/main/java/hudson/maven/MavenModuleSet.java
          src/main/webapp/images/16x16/mavenmoduleset.png
          src/main/webapp/images/24x24/mavenmoduleset.png
          src/main/webapp/images/32x32/mavenmoduleset.png
          src/main/webapp/images/48x48/mavenmoduleset.png
          http://jenkins-ci.org/commit/maven-plugin/6fcec84df690187a104d57c1b40916053d42fdad
          Log:
          Merge pull request #84 from stephenc/jenkins-38960-followup

          [JENKINS-38960 Follow-up] Switch to IconSpec

          Compare: https://github.com/jenkinsci/maven-plugin/compare/4b29ab88fa1b...6fcec84df690

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/images/make-inkscape.sh src/images/mavenmoduleset.svg src/main/java/hudson/maven/MavenModuleSet.java src/main/webapp/images/16x16/mavenmoduleset.png src/main/webapp/images/24x24/mavenmoduleset.png src/main/webapp/images/32x32/mavenmoduleset.png src/main/webapp/images/48x48/mavenmoduleset.png http://jenkins-ci.org/commit/maven-plugin/6fcec84df690187a104d57c1b40916053d42fdad Log: Merge pull request #84 from stephenc/jenkins-38960-followup [JENKINS-38960 Follow-up] Switch to IconSpec Compare: https://github.com/jenkinsci/maven-plugin/compare/4b29ab88fa1b...6fcec84df690

          Oleg Nenashev added a comment -

          The fix is integrated towards 2.27

          Oleg Nenashev added a comment - The fix is integrated towards 2.27

            stephenconnolly Stephen Connolly
            stephenconnolly Stephen Connolly
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: