Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-39370

Introduce the remoting working directory concept

    XMLWordPrintable

Details

    • New Feature
    • Status: Resolved (View Workflow)
    • Major
    • Resolution: Fixed
    • remoting
    • None

    Description

      Right now remoting has no it's own Working Directory on startup. It complicates implementation of features like JENKINS-39369 and JENKINS-18578

      Requirements:

      • The directory is compatible with the current agent workspace architecture of JNLP slaves and
      • The directory is being created only if explicitly required (behavior compatibility for the current workspace-less agents)
      • The workspace should not interfere with Jenkins plugins putting the data to the root of the agent workspace

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-18578 Default jar cache location is hardcoded to ~/.jenkins/cache/jars

          • Major - Major loss of function.
          • Resolved

          New Feature - A new feature of the product, which has yet to be developed. JENKINS-39369 Automatically dump agent logs to the disk

          • Major - Major loss of function.
          • Resolved
          is blocking

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-39130 Jenkins JNLP agents should not connect/schedule builds if the workspace cannot be created or not writable

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link CloudBees Internal OSS-553

          Web Link remoting/pull/129

          Activity

            Ascending order - Click to sort in descending order
            oleg_nenashev Oleg Nenashev created issue -
            oleg_nenashev Oleg Nenashev made changes -
            Field Original Value New Value
            Epic Link JENKINS-38833 [ 175240 ]
            oleg_nenashev Oleg Nenashev made changes -
            Priority Minor [ 4 ] Major [ 3 ]
            oleg_nenashev Oleg Nenashev made changes -
            Link This issue blocks JENKINS-39369 [ JENKINS-39369 ]
            oleg_nenashev Oleg Nenashev made changes -
            Link This issue blocks JENKINS-18578 [ JENKINS-18578 ]
            oleg_nenashev Oleg Nenashev made changes -
            Description Right now remoting has no it's own Working Directory on startup. It complicates implementation of features like JENKINS-39369 and JENKINS-18578 Right now remoting has no it's own Working Directory on startup. It complicates implementation of features like JENKINS-39369 and JENKINS-18578

            Requirements:
            * The directory is compatible with the current agent workspace architecture of JNLP slaves and
            * The directory is being created only if explicitly required (behavior compatibility for the current workspace-less agents)
            * The workspace should not interfere with Jenkins plugins putting the data to the root of the agent workspace
            oleg_nenashev Oleg Nenashev made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            oleg_nenashev Oleg Nenashev made changes -
            Assignee Oleg Nenashev [ oleg_nenashev ]
            oleg_nenashev Oleg Nenashev made changes -
            Link This issue is blocking JENKINS-39130 [ JENKINS-39130 ]
            recampbell Ryan Campbell made changes -
            Comment [ Oleg, you've marked this as In Review, but none of the issues link to any PR. ]
            oleg_nenashev Oleg Nenashev made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            oleg_nenashev Oleg Nenashev made changes -
            Remote Link This issue links to "remoting/pull/129 (Web Link)" [ 15091 ]
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            README.md
            docs/logging.md
            docs/workDir.md
            src/main/java/hudson/remoting/Engine.java
            src/main/java/hudson/remoting/FileSystemJarCache.java
            src/main/java/hudson/remoting/Launcher.java
            src/main/java/hudson/remoting/TeeOutputStream.java
            src/main/java/hudson/remoting/jnlp/Main.java
            src/main/java/org/jenkinsci/remoting/engine/WorkDirManager.java
            src/test/java/org/jenkinsci/remoting/engine/WorkDirManagerTest.java
            http://jenkins-ci.org/commit/remoting/76c9b8ccf14f7def1141565b0dee2e4d1c5508d4
            Log:
            [JENKINS-39370,JENKINS-39369] - Support of work directories in Remoting (#129)

            • [JENKINS-39370,JENKINS-39369] - Add workDir parameter and automatically create logs there if specified
            • Save the progress
            • JENKINS-39370 - Generalize the workspace manager for Java Web Start
            • JENKINS-39370 - Restrict the range of supported symbols in the remoting work directory
            • JENKINS-39130 - Allow specifying flag for failing initialization if workdir is missing
            • JENKINS-39370 - @stephenc noticed that workDir may be null, Intellij IDEA adoption fun
            • JENKINS-39370 - Another message, which likely breaks the CI instance
            • JENKINS-39817 - Introduce the agentLog parameter in remoting.jnlp.Main

            @stephenc suggested doing it in the PR, so I decided to address it as a part of JENKINS-39370.
            But the code still has initialization in hudson.remoting.Launcher for other logging modes.

            • Enable JUL logging to a log-rotated file by default
            • JENKINS-18578 - If workspace manager is defined, use JAR Cache within its interbal directory
            • JENKINS-39370 - Fix the workDirManager's log initialization in Launcher
            • JENKINS-39369 - Make JUL logging system configurable via property file
            • JENKINS-39369 - Fixes in logging management after the manual testing
            • JENKINS-39369 - Respect configuration being passed from java.util.logging.config.file system property
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: README.md docs/logging.md docs/workDir.md src/main/java/hudson/remoting/Engine.java src/main/java/hudson/remoting/FileSystemJarCache.java src/main/java/hudson/remoting/Launcher.java src/main/java/hudson/remoting/TeeOutputStream.java src/main/java/hudson/remoting/jnlp/Main.java src/main/java/org/jenkinsci/remoting/engine/WorkDirManager.java src/test/java/org/jenkinsci/remoting/engine/WorkDirManagerTest.java http://jenkins-ci.org/commit/remoting/76c9b8ccf14f7def1141565b0dee2e4d1c5508d4 Log: [JENKINS-39370,JENKINS-39369] - Support of work directories in Remoting (#129) [JENKINS-39370,JENKINS-39369] - Add workDir parameter and automatically create logs there if specified Save the progress JENKINS-39370 - Generalize the workspace manager for Java Web Start JENKINS-39370 - WiP - Save progress in the test suite JENKINS-39370 - Add tests for WorkDirManager JENKINS-39370 - Restrict the range of supported symbols in the remoting work directory JENKINS-39370 - Generalize the workspace initialization checks JENKINS-39130 - Allow specifying flag for failing initialization if workdir is missing JENKINS-39370 - Reference DirType in WorkDirManager Javadocs JENKINS-39370 - @stephenc noticed that workDir may be null, Intellij IDEA adoption fun JENKINS-39370 - Seems this message breaks our CI JENKINS-39370 - Another message, which likely breaks the CI instance JENKINS-39370 - Simplify the log handling logic JENKINS-39817 - Introduce the agentLog parameter in remoting.jnlp.Main @stephenc suggested doing it in the PR, so I decided to address it as a part of JENKINS-39370 . But the code still has initialization in hudson.remoting.Launcher for other logging modes. Enable JUL logging to a log-rotated file by default JENKINS-18578 - If workspace manager is defined, use JAR Cache within its interbal directory JENKINS-39370 - Fix the workDirManager's log initialization in Launcher JENKINS-39370 - Draft the documentation JENKINS-39369 - Make JUL logging system configurable via property file JENKINS-39369 - Fixes in logging management after the manual testing JENKINS-39369 - Add tests for the logging subsystem JENKINS-39369 - Respect configuration being passed from java.util.logging.config.file system property
            oleg_nenashev Oleg Nenashev made changes -
            Epic Link JENKINS-38833 [ 175240 ] JENKINS-44108 [ 181734 ]
            oleg_nenashev Oleg Nenashev added a comment -

            Released in Remoting 3.8. Needs integration into the core

            oleg_nenashev Oleg Nenashev added a comment - Released in Remoting 3.8. Needs integration into the core
            oleg_nenashev Oleg Nenashev made changes -
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/test/java/hudson/LauncherTest.java
            pom.xml
            test/src/test/java/hudson/slaves/JNLPLauncherTest.java
            http://jenkins-ci.org/commit/jenkins/e7cdd6517cf25940a497f9abced72c888a398720
            Log:
            JENKINS-39370 - Update Remoting in Jenkins core to 3.10 (#2886)

            • Update Remoting in Jenkins core to 3.8
            • JENKINS-39370 - Introduce support of Work Directories in remoting (opt-in).
            • PR 129 - Allow configuring java.util.logging settings via a property file (-loggingConfig or JUL system property). See the Logging page for more details.
            • JENKINS-37567 - Change of the code signing certificate

            More info: https://github.com/jenkinsci/remoting/blob/master/CHANGELOG.md#38

            • JENKINS-39370 - Add direct tests for JNLP Launcher start with -workDir
            • Pick Remoting 3.9
            • Improve error message of LauncherTest#remoteKill()
            • Update Remoting to 3.10
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/test/java/hudson/LauncherTest.java pom.xml test/src/test/java/hudson/slaves/JNLPLauncherTest.java http://jenkins-ci.org/commit/jenkins/e7cdd6517cf25940a497f9abced72c888a398720 Log: JENKINS-39370 - Update Remoting in Jenkins core to 3.10 (#2886) Update Remoting in Jenkins core to 3.8 JENKINS-39370 - Introduce support of Work Directories in remoting (opt-in). PR 129 - Allow configuring java.util.logging settings via a property file (-loggingConfig or JUL system property). See the Logging page for more details. JENKINS-37567 - Change of the code signing certificate More info: https://github.com/jenkinsci/remoting/blob/master/CHANGELOG.md#38 JENKINS-39370 - Add direct tests for JNLP Launcher start with -workDir Pick Remoting 3.9 Improve error message of LauncherTest#remoteKill() Update Remoting to 3.10
            oleg_nenashev Oleg Nenashev added a comment -

            Merged towards Jenkins 2.68

            oleg_nenashev Oleg Nenashev added a comment - Merged towards Jenkins 2.68
            cloudbees CloudBees Inc. made changes -
            Remote Link This issue links to "CloudBees Internal OSS-553 (Web Link)" [ 18878 ]

            People

              oleg_nenashev Oleg Nenashev
              oleg_nenashev Oleg Nenashev
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: