Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-39837

scm: Browser isn't set to GithubWeb

    XMLWordPrintable

Details

    Description

      When using GitHub Organization Folders, the browser attribute isn't set to GithubWeb.

      As a result, the links aren't created to GitHub in the changelog.

      Attachments

        Issue Links

          Activity

            docwhat Christian Höltje created issue -

            I'm guessing that guessBrowser isn't figuring out our enterprise github instance is github. There is no reason to use guessBrowser here, GitHub Org Folders should just set it itself.

            docwhat Christian Höltje added a comment - I'm guessing that guessBrowser isn't figuring out our enterprise github instance is github. There is no reason to use guessBrowser here, GitHub Org Folders should just set it itself.

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/hudson/plugins/git/GitSCM.java
            http://jenkins-ci.org/commit/git-plugin/36154403f21b0adc1edeb001d0d4a4ceb5aa14b1
            Log:
            JENKINS-39837 We need to be able to set the browser after instantiation

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/plugins/git/GitSCM.java http://jenkins-ci.org/commit/git-plugin/36154403f21b0adc1edeb001d0d4a4ceb5aa14b1 Log: JENKINS-39837 We need to be able to set the browser after instantiation

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/hudson/plugins/git/GitSCM.java
            http://jenkins-ci.org/commit/git-plugin/7b8460c1af808528fb0268b32c937db6396344c9
            Log:
            JENKINS-39837 We need to be able to set the browser after instantiation

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/plugins/git/GitSCM.java http://jenkins-ci.org/commit/git-plugin/7b8460c1af808528fb0268b32c937db6396344c9 Log: JENKINS-39837 We need to be able to set the browser after instantiation
            stephenconnolly Stephen Connolly made changes -
            Field Original Value New Value
            Assignee Kohsuke Kawaguchi [ kohsuke ] Stephen Connolly [ stephenconnolly ]
            stephenconnolly Stephen Connolly made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            stephenconnolly Stephen Connolly made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            stephenconnolly Stephen Connolly made changes -
            Remote Link This issue links to "PR#101 (Web Link)" [ 15253 ]
            stephenconnolly Stephen Connolly made changes -
            Component/s github-branch-source-plugin [ 20858 ]
            Component/s github-organization-folder-plugin [ 21427 ]
            stephenconnolly Stephen Connolly made changes -
            Link This issue is duplicated by JENKINS-34752 [ JENKINS-34752 ]

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
            http://jenkins-ci.org/commit/github-branch-source-plugin/8fd5f83219dc3bc99ca2a7b4bf56e38d33110b1d
            Log:
            [FIXED JENKINS-39837] Set the GithubWeb browser when creating SCM

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java http://jenkins-ci.org/commit/github-branch-source-plugin/8fd5f83219dc3bc99ca2a7b4bf56e38d33110b1d Log: [FIXED JENKINS-39837] Set the GithubWeb browser when creating SCM
            stephenconnolly Stephen Connolly made changes -
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Closed [ 6 ]
            cloudbees CloudBees Inc. made changes -
            Remote Link This issue links to "CloudBees Internal OSS-1840 (Web Link)" [ 18541 ]

            People

              stephenconnolly Stephen Connolly
              docwhat Christian Höltje
              Votes:
              2 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: