-
Bug
-
Resolution: Duplicate
-
Major
-
None
-
-
tasman
In scope
If the run result is opened and no run or job exists it should go to the 404 page.
Follow up work of JENKINS-39809, this part should cover:
- mobx returns always an answer
- response object should contain at least data and error attributes, maybe a generic state as well
const pager = { data, error, state } // then in view if (pager.error) { return <NotFound/>; } // and to get rid of pager.$pending if (pager.state === 'PENDING') { return null; }
- use this new code to fix 404 with patterns
'/blue/organizations/gibtEsNicht', '/blue/organizations/jenkins/my-pipeline/detail/my-pipeline/20/pipeline'
where this comes from ATH smoke test and the last url stands for a detail view of a build number that not yet exists.
dogfood context
https://ci.jenkins.io/blue/organizations/jenkins/Infra%2Fpatron/detail/PR-16/1/pipeline/
- duplicates
-
JENKINS-36083 Improve Error handling
-
- Open
-
- is blocked by
-
-
- Open
-
[JENKINS-40032] Handle errors and 404s consistently
| Description |
Original:
Follow up work of The missing part should cover: - mobx returns always an answer - response object should contain at least data and error attributes, maybe a generic state as well {code} const pager = { data, error, state } // then in view if (pager.error) { return <NotFound/>; } // or to get rid of pager.$pending if (pager.state === 'PENDING') { return null; } {code} - use this new code to fix 404 with pattern {code} '/blue/organizations/gibtEsNicht', '/blue/organizations/jenkins/my-pipeline/detail/my-pipeline/20/pipeline' {code} where this comes from ATH smoke test and the last url stands for a detail view of a build number that not yet exists. |
New:
Follow up work of The missing part should cover: - mobx returns always an answer - response object should contain at least data and error attributes, maybe a generic state as well {code} const pager = { data, error, state } // then in view if (pager.error) { return <NotFound/>; } // and to get rid of pager.$pending if (pager.state === 'PENDING') { return null; } {code} - use this new code to fix 404 with pattern {code} '/blue/organizations/gibtEsNicht', '/blue/organizations/jenkins/my-pipeline/detail/my-pipeline/20/pipeline' {code} where this comes from ATH smoke test and the last url stands for a detail view of a build number that not yet exists. |
| Description |
Original:
Follow up work of The missing part should cover: - mobx returns always an answer - response object should contain at least data and error attributes, maybe a generic state as well {code} const pager = { data, error, state } // then in view if (pager.error) { return <NotFound/>; } // and to get rid of pager.$pending if (pager.state === 'PENDING') { return null; } {code} - use this new code to fix 404 with pattern {code} '/blue/organizations/gibtEsNicht', '/blue/organizations/jenkins/my-pipeline/detail/my-pipeline/20/pipeline' {code} where this comes from ATH smoke test and the last url stands for a detail view of a build number that not yet exists. |
New:
Follow up work of The missing part should cover: - mobx returns always an answer - response object should contain at least data and error attributes, maybe a generic state as well {code} const pager = { data, error, state } // then in view if (pager.error) { return <NotFound/>; } // and to get rid of pager.$pending if (pager.state === 'PENDING') { return null; } {code} - use this new code to fix 404 with pattern {code} '/blue/organizations/gibtEsNicht', '/blue/organizations/jenkins/my-pipeline/detail/my-pipeline/20/pipeline' {code} where this comes from ATH smoke test and the last url stands for a detail view of a build number that not yet exists. *further in scope* If the run result is opened and no run or job exists it should go to the 404 page. *Context* https://ci.jenkins.io/blue/organizations/jenkins/Infra%2Fpatron/detail/PR-16/1/pipeline/ |
| Description |
Original:
Follow up work of The missing part should cover: - mobx returns always an answer - response object should contain at least data and error attributes, maybe a generic state as well {code} const pager = { data, error, state } // then in view if (pager.error) { return <NotFound/>; } // and to get rid of pager.$pending if (pager.state === 'PENDING') { return null; } {code} - use this new code to fix 404 with pattern {code} '/blue/organizations/gibtEsNicht', '/blue/organizations/jenkins/my-pipeline/detail/my-pipeline/20/pipeline' {code} where this comes from ATH smoke test and the last url stands for a detail view of a build number that not yet exists. *further in scope* If the run result is opened and no run or job exists it should go to the 404 page. *Context* https://ci.jenkins.io/blue/organizations/jenkins/Infra%2Fpatron/detail/PR-16/1/pipeline/ |
New:
*In scope* If the run result is opened and no run or job exists it should go to the 404 page. Follow up work of - mobx returns always an answer - response object should contain at least data and error attributes, maybe a generic state as well {code} const pager = { data, error, state } // then in view if (pager.error) { return <NotFound/>; } // and to get rid of pager.$pending if (pager.state === 'PENDING') { return null; } {code} - use this new code to fix 404 with patterns {code} '/blue/organizations/gibtEsNicht', '/blue/organizations/jenkins/my-pipeline/detail/my-pipeline/20/pipeline' {code} where this comes from ATH smoke test and the last url stands for a detail view of a build number that not yet exists. *dogfood context* https://ci.jenkins.io/blue/organizations/jenkins/Infra%2Fpatron/detail/PR-16/1/pipeline/ |
| Epic Link | New: JENKINS-35759 [ 171771 ] |
| Epic Link | Original: JENKINS-35759 [ 171771 ] | New: JENKINS-35749 [ 171790 ] |
Ivan Meredith
made changes -
| Assignee | Original: Ivan Meredith [ detab ] | New: Ivan Meredith [ imeredith ] |
Ivan Meredith
made changes -
| Sprint | New: frank [ 156 ] |
Ivan Meredith
made changes -
| Rank | New: Ranked higher |
Ivan Meredith
made changes -
| Summary | Original: mobx should return an error object so each view can return a notfound when they want | New: mobx should return an error object so each view can return a notfound when they wantse |