Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40255

WorkflowJob.getSCMs() should have similar behaviour as poll()

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • workflow-job-plugin
    • None
    • jenkins: 2.19.4
      workflow-job: 2.9

      The implementation of WorkflowJob.getSCMs() is troublesome. It uses the latest completed build to determine the SCM resource. Normally this works fine, however, if the last completed build has failed before all SCM resources was checked out, then none or not all SCM resources are returned. This is quite common for us since we, from time to time, have network problems and the SCM checkout step fails.
      So, I therefor suggest that getSCMs() first check if getLastSuccessfulBuild() returns a build, if not fall back by using getLastCompletedBuild().
      This behaviour is also more inline with WorkflowJob.poll() where it first check for a successful build.

          [JENKINS-40255] WorkflowJob.getSCMs() should have similar behaviour as poll()

          Jon Sten created issue -
          Jesse Glick made changes -
          Link New: This issue relates to JENKINS-32214 [ JENKINS-32214 ]
          Jesse Glick made changes -
          Remote Link New: This issue links to "PR 34 (Web Link)" [ 15263 ]
          Jesse Glick made changes -
          Assignee New: Jon Sten [ jons ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Jesse Glick made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Jesse Glick made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Resolved [ 5 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: jon
          Path:
          src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowJob.java
          http://jenkins-ci.org/commit/workflow-job-plugin/0b04f3d9fb2c00768b0d97eadf2a44023c75c0e8
          Log:
          JENKINS-40255 Changed behavior for WorkflowJob.getSCMs(), not it checks for successful build first.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: jon Path: src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowJob.java http://jenkins-ci.org/commit/workflow-job-plugin/0b04f3d9fb2c00768b0d97eadf2a44023c75c0e8 Log: JENKINS-40255 Changed behavior for WorkflowJob.getSCMs(), not it checks for successful build first.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: jon
          Path:
          src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowJob.java
          http://jenkins-ci.org/commit/workflow-job-plugin/ffdde4e96cb16985b08c511d0383b7c7c12b1793
          Log:
          JENKINS-40255 Changed behavior for WorkflowJob.getSCMs(), now it checks for successful build first.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: jon Path: src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowJob.java http://jenkins-ci.org/commit/workflow-job-plugin/ffdde4e96cb16985b08c511d0383b7c7c12b1793 Log: JENKINS-40255 Changed behavior for WorkflowJob.getSCMs(), now it checks for successful build first.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: jon
          Path:
          http://jenkins-ci.org/commit/workflow-job-plugin/9209eac4647fbbda2ea37993740ead9f7d7928aa
          Log:
          Merge branch 'JENKINS-40255' of https://github.com/jonsten/workflow-job-plugin into JENKINS-40255

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: jon Path: http://jenkins-ci.org/commit/workflow-job-plugin/9209eac4647fbbda2ea37993740ead9f7d7928aa Log: Merge branch ' JENKINS-40255 ' of https://github.com/jonsten/workflow-job-plugin into JENKINS-40255

            jons Jon Sten
            jons Jon Sten
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: