Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40255

WorkflowJob.getSCMs() should have similar behaviour as poll()

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • workflow-job-plugin
    • None
    • jenkins: 2.19.4
      workflow-job: 2.9

      The implementation of WorkflowJob.getSCMs() is troublesome. It uses the latest completed build to determine the SCM resource. Normally this works fine, however, if the last completed build has failed before all SCM resources was checked out, then none or not all SCM resources are returned. This is quite common for us since we, from time to time, have network problems and the SCM checkout step fails.
      So, I therefor suggest that getSCMs() first check if getLastSuccessfulBuild() returns a build, if not fall back by using getLastCompletedBuild().
      This behaviour is also more inline with WorkflowJob.poll() where it first check for a successful build.

          [JENKINS-40255] WorkflowJob.getSCMs() should have similar behaviour as poll()

          Jon Sten created issue -
          Jesse Glick made changes -
          Link New: This issue relates to JENKINS-32214 [ JENKINS-32214 ]
          Jesse Glick made changes -
          Remote Link New: This issue links to "PR 34 (Web Link)" [ 15263 ]
          Jesse Glick made changes -
          Assignee New: Jon Sten [ jons ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Jesse Glick made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Jesse Glick made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Resolved [ 5 ]
          Jesse Glick made changes -
          Link New: This issue is duplicated by JENKINS-41652 [ JENKINS-41652 ]

            jons Jon Sten
            jons Jon Sten
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: