Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40286

EncryptedSlaveAgentJnlpFile should use SlaveComputer.getJnlpMac() instead of reimplementing it

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None

      Basically getJnlpMac() does JnlpSlaveAgentProtocol.SLAVE_SECRET.mac(getName()), and EncryptedSlaveAgentJnlpFile.generateResponse does: JnlpSlaveAgentProtocol.SLAVE_SECRET.mac(slaveName.getBytes("UTF-8"))
      I'd like to be able to override getJnlpMac and have the key used consistently.

          [JENKINS-40286] EncryptedSlaveAgentJnlpFile should use SlaveComputer.getJnlpMac() instead of reimplementing it

          Kevin Browder created issue -
          Kevin Browder made changes -
          Summary Original: EncryptedSlaveAgentJnlpFile should use SlaveComputer.getJnlpMac() instead of implementing it New: EncryptedSlaveAgentJnlpFile should use SlaveComputer.getJnlpMac() instead of reimplementing it
          Daniel Beck made changes -
          Issue Type Original: Bug [ 1 ] New: Improvement [ 4 ]
          Kevin Browder made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Kevin Browder made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Oleg Nenashev made changes -
          Link New: This issue is related to JENKINS-40413 [ JENKINS-40413 ]
          Oleg Nenashev made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Resolved [ 5 ]

            Unassigned Unassigned
            kbrowder Kevin Browder
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: