Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40413

Create JNLPMacProvider interface and have AccessControlled inherit from it

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Trivial Trivial
    • core

      It is a follow-up to https://github.com/jenkinsci/jenkins/pull/2658. JENKINS-40286 allows SlaveComputers to change the way the JnlpMac is generated, however ideally any AccessControlled could change override the default behavior.

      Comment from oleg_nenashev

      > I would rather introduce a new interface like JNLPMacProvider with getJnlpMac(). In such case other AccessControlled items will be also able to tweak the logic by implementing this interface. Maybe deserves a follow-up JIRA ticket

          [JENKINS-40413] Create JNLPMacProvider interface and have AccessControlled inherit from it

          Kevin Browder created issue -
          Kevin Browder made changes -
          Summary Original: Create JNLPMacProvider and have AccessControlled inherit from it New: Create JNLPMacProvider interface and have AccessControlled inherit from it
          Oleg Nenashev made changes -
          Description Original: JENKINS-40286 allows SlaveComputers to change the way the JnlpMac is generated, however ideally any AccessControlled could change override the default behavior. New: It is a follow-up to https://github.com/jenkinsci/jenkins/pull/2658. JENKINS-40286 allows SlaveComputers to change the way the JnlpMac is generated, however ideally any AccessControlled could change override the default behavior.


          Comment from [~oleg_nenashev]

          > I would rather introduce a new interface like JNLPMacProvider with getJnlpMac(). In such case other AccessControlled items will be also able to tweak the logic by implementing this interface. Maybe deserves a follow-up JIRA ticket

          Oleg Nenashev made changes -
          Link New: This issue is related to JENKINS-40286 [ JENKINS-40286 ]

            Unassigned Unassigned
            kbrowder Kevin Browder
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: