• Type: Bug
• Resolution: Unresolved
• Priority: Minor
• Component/s: pipeline-githubnotify-step-plugin
• Labels:

  None
• Environment:

  pipeline-githubnotify-step-plugin 1.0.0
  jenkins 2.36

[JENKINS-40422] Inferring credentials resolves wrong credential

Martin Ringehahn created issue - 2016-12-13 21:17

Martin Ringehahn made changes - 2016-12-13 21:17

Description

Original: The inference for the github credentials uses `getCredentials` which return checkout credentials. Checkout credentials can be SSH credentials, unsuitable for API calls such as commit status updates. When checkout credentials are SSH credentials, inference fails with: {{java.lang.IllegalArgumentException: The credentialsId does not seem to exist, please check it}} Instead, the plugin should probably use {{getScanCredentialsId}} to obtain its credentials.

New: The inference for the github credentials uses {{getCredentials}} which return checkout credentials. Checkout credentials can be SSH credentials, unsuitable for API calls such as commit status updates. When checkout credentials are SSH credentials, inference fails with: {{java.lang.IllegalArgumentException: The credentialsId does not seem to exist, please check it}} Instead, the plugin should probably use {{getScanCredentialsId}} to obtain its credentials.

Raul Arabaolaza made changes - 2016-12-13 21:53

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

Raul Arabaolaza made changes - 2016-12-20 08:26

Remote Link

New: This issue links to "PR-2 (Web Link)" [ 15148 ]

Raul Arabaolaza made changes - 2016-12-23 21:33

Resolution		New: Fixed [ 1 ]
Status	Original: In Progress [ 3 ]	New: Resolved [ 5 ]

liyatikal made changes - 2017-12-25 20:21

Resolution	Original: Fixed [ 1 ]
Status	Original: Resolved [ 5 ]	New: Reopened [ 4 ]