Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Minor
-
Resolution: Fixed
-
Component/s: blueocean-plugin
-
Labels:
-
Similar Issues:
-
Epic Link:
-
Sprint:frank
Description
Paging currently has some problems.
1) broken on activity (PR has been merged, see below)
2) Branches hides show more button erroneously
In Scope
- Write an ATH for branches and activity pagination
- Fix the bug with activity button: ttps://github.com/jenkinsci/blueocean-plugin/pull/658
- Fix branches
- Remove fetchMore and test case if it isn't needed (from smart-fetch.js) - is smart-fetch.js actually used now? confirm with test coverage
Steps to reproduce broken pagination on activity
- Go to https://ci.blueocean.io/blue/organizations/jenkins/blueocean/activity/
- Click show more
Console error
Uncaught TypeError: _this2.pager.fetchMore is not a function
at onClick (https://ci.blueocean.io/adjuncts/8c0ace04/org/jenkins/ui/jsmodules/blueocean-dashboard/jenkins-js-extension.js:31655:53)
at Object.invokeGuardedCallback (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85069:12)
at executeDispatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77193:21)
at Object.executeDispatchesInOrder (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:77216:5)
at executeDispatchesAndRelease (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76670:22)
at executeDispatchesAndReleaseTopLevel (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76681:10)
at Array.forEach (native)
at forEachAccumulated (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:91338:9)
at Object.processEventQueue (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:76857:7)
at runEventQueueInBatch (https://ci.blueocean.io/adjuncts/8c0ace04/io/jenkins/blueocean/blueocean.js:85127:18)
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Sprint | frank [ 156 ] |
| Rank | Ranked higher |
| Priority | Minor [ 4 ] | Blocker [ 1 ] |
| Assignee | Ivan Meredith [ imeredith ] |
Ivan Meredith as this touches on some new code - are you able to take a look, mostly around testing, and then seeing if we can chop that old "fetchMore()" function, as it is confusing that it is in there now iwth mobx, I think, and we should be able to get rid of it if we can.
I can see it is used elsewhere in smartfetch in paginate - but it isn't clear if that paginate function is now really used anywhere (it is in actions.js as fetchAllPipelines(), and getAllPipelines() - but then that doesn't seem to be used).
Can we please add an ATH for pagination, and THEN (only then) look at chopping this really confusing code, if it isn't needed?
| Priority | Blocker [ 1 ] | Major [ 3 ] |
| Summary | REGRESSION: pagination is broken on activity | Pagination needs ATH coverage |
| Summary | Pagination needs ATH coverage | Pagination for branches and ATH coverage |
| Priority | Major [ 3 ] | Critical [ 2 ] |
| Sprint | frank [ 156 ] | frank, christmas [ 156, 176 ] |
| Epic Link | JENKINS-35742 [ 171802 ] |
| Sprint | frank, christmas [ 156, 176 ] | frank [ 156 ] |
| Rank | Ranked higher |
| Sprint | frank [ 156 ] | frank, panthalassa [ 156, 221 ] |
| Rank | Ranked lower |
| Sprint | frank, panthalassa [ 156, 221 ] | frank, up next [ 156, 171 ] |
| Rank | Ranked higher |
| Sprint | frank, up next [ 156, 171 ] | frank [ 156 ] |
| Sprint | frank [ 156 ] | frank, 1.1 [ 156, 251 ] |
| Rank | Ranked higher |
| Rank | Ranked higher |
| Labels | technical-debt |
| Priority | Critical [ 2 ] | Minor [ 4 ] |
I believe this one was done some time ago.
| Resolution | Fixed [ 1 ] | |
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Sprint | frank, Blue Ocean up next [ 156, 251 ] | frank [ 156 ] |
| Rank | Ranked lower |
Jenn Briden
made changes -
| Status | Resolved [ 5 ] | Closed [ 6 ] |
Pull request: https://github.com/jenkinsci/blueocean-plugin/pull/658 for fix
no ATH yet - but ATH for pagination is well worth it IMO