Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40435

Job configuration submission should be a bulk change

      When I submit an empty Freestyle job config in the default configuration of Jenkins 2.35, the data is being saved to the disk 8 times. All of them happen in this code: https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/Job.java#L1227-L1246

      • setDisplayName
      • Project#getBuildWrappersList().rebuild (onModified handler)
      • Project#getBuilderList().rebuild (onModified handler)
      • Project#getPublisherList().rebuild (onModified handler)
      • AbstractProject#makeDisabled
      • AbstractProject#setScm
      • AbstractProject#triggers.replaceBy
      • final save()

      I think there is not so much sense to submit partial configurations to the disk due to the risk of data inconsistency there. I propose to wrap the selected code segment into a bulk operation

          [JENKINS-40435] Job configuration submission should be a bulk change

          Oleg Nenashev created issue -
          Oleg Nenashev made changes -
          Assignee New: Oleg Nenashev [ oleg_nenashev ]
          Oleg Nenashev made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Oleg Nenashev made changes -
          Remote Link New: This issue links to "jenkins/pull/2664 (Web Link)" [ 15128 ]
          Oleg Nenashev made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
          Oleg Nenashev made changes -
          Labels Original: disk performance New: disk lts-candidate performance
          Oliver Gondža made changes -
          Labels Original: disk lts-candidate performance New: 2.32.2-fixed disk performance
          Oleg Nenashev made changes -
          Link New: This issue is duplicated by JENKINS-8953 [ JENKINS-8953 ]
          Marc Carter made changes -
          Link New: This issue is blocking JENKINS-42886 [ JENKINS-42886 ]

            oleg_nenashev Oleg Nenashev
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: