Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-4043

can't link to viewvc installation that doesn't end with "viewvc"

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • viewVC-plugin
    • None
    • Platform: All, OS: All

      I have a viewvc installation at http://www.example.com/cgi-bin/viewvc.cgi as its
      root.The current implementation only allows setting the hostname and path, not
      the script name. So when I use the above as url, the plugin sends me to
      http://www.example.com/cgi-bin/viewvc.cgi/viewvc which doesn't exist.

      I suggest that the configuration uses the full url and doesn't append "/viewvc".
      Backwards compatibility might pose a problem, but that could be remedied by
      appending "/viewvc" to the url on upgrading.

        1. HUDSON-4043.patch
          3 kB

          [JENKINS-4043] can't link to viewvc installation that doesn't end with "viewvc"

          wvengen created issue -

          Matthew Buckett added a comment -

          Patch that allows the user to specify the full URL for viewvc. It should also migrate existing installations correctly.

          Matthew Buckett added a comment - Patch that allows the user to specify the full URL for viewvc. It should also migrate existing installations correctly.
          Matthew Buckett made changes -
          Attachment New: JENKINS-4043.patch [ 19157 ]

          wvengen added a comment -

          Just tested in Hudson 1.350 and I can now specify the full url. Thanks!

          wvengen added a comment - Just tested in Hudson 1.350 and I can now specify the full url. Thanks!
          wvengen made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          Andrew Bayer made changes -
          Status Original: Resolved [ 5 ] New: Closed [ 6 ]

          Christopher Tarento added a comment -

          does not work in 1.445

          Christopher Tarento added a comment - does not work in 1.445
          Christopher Tarento made changes -
          Resolution Original: Fixed [ 1 ]
          Status Original: Closed [ 6 ] New: Reopened [ 4 ]

          Michael Rumpf added a comment -

          Works in 1.506. Pull request has been sent: https://github.com/jenkinsci/viewVC-plugin/pull/2

          Michael Rumpf added a comment - Works in 1.506. Pull request has been sent: https://github.com/jenkinsci/viewVC-plugin/pull/2

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: mrumpf
          Path:
          src/main/java/hudson/plugins/viewVC/ViewVCRepositoryBrowser.java
          http://jenkins-ci.org/commit/viewVC-plugin/7f5d0c24284ce961dad4a3f1ea0489f354eefaf0
          Log:
          Applied the patch from JENKINS-4043.
          The patch adds the /viewvc/ suffix for all existing ViewVC configurations.
          For new jobs the suffix is not added anymore.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: mrumpf Path: src/main/java/hudson/plugins/viewVC/ViewVCRepositoryBrowser.java http://jenkins-ci.org/commit/viewVC-plugin/7f5d0c24284ce961dad4a3f1ea0489f354eefaf0 Log: Applied the patch from JENKINS-4043 . The patch adds the /viewvc/ suffix for all existing ViewVC configurations. For new jobs the suffix is not added anymore.

            mirumpf Michael Rumpf
            wvengen wvengen
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: