Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40446

Links broken in GitHub status for matrix projects

    • frank, pannonian

      When using blue ocean (I think starting from beta 11 or so), the links in GitHub status were replaced by BlueOcean links, but, at least for matrix projects, these links are broken, for example this is a matrix project that lives in a folder "thefolder" and is called "theproject" in Jenkins, the link used by blueocean is:
      https://jenkins/blue/organizations/jenkins/thefolder%2Ftheproject%2FDIST%3Dtrusty/detail/trusty/921/pipeline
      while the correct non-blue ocean link is:
      https://jenkins/job/thefolder/job/theproject/921/DIST=trusty/

      Going through the blue ocean web interface to the project, nothing is even shown.

      If this can't be fixed soon, there should be at least an option to enable/disable replacing conventional links with blue ocean links, this makes using blue ocean practically impossible with github testing.

          [JENKINS-40446] Links broken in GitHub status for matrix projects

          Michael Neale added a comment -

          lucasocio as an immediate measure, if you remove the plugin called "BlueOcean Display URL plugin" then it should revert to the normal behavior. There is an update to that plugin that lets it be configured to. (it won't be re-installed automatically). Or disable it - up to you.

          there is also a related ticket: https://issues.jenkins-ci.org/browse/JENKINS-37427 which will make blue ocean do the right thing with matrix, which would make this kind of moot, but you need to solve this now - so I recommend the above.

          jamesdumay do I have this right?

          Michael Neale added a comment - lucasocio as an immediate measure, if you remove the plugin called "BlueOcean Display URL plugin" then it should revert to the normal behavior. There is an update to that plugin that lets it be configured to. (it won't be re-installed automatically). Or disable it - up to you. there is also a related ticket: https://issues.jenkins-ci.org/browse/JENKINS-37427 which will make blue ocean do the right thing with matrix, which would make this kind of moot, but you need to solve this now - so I recommend the above. jamesdumay do I have this right?

          James Dumay added a comment - - edited

          michaelneale working on a fix for the blueocean display URL plugin that will not generate a blue URL to matrix projects.

          But yes, there is an option to disable the behaviour on the user profile coming soon.

          James Dumay added a comment - - edited michaelneale working on a fix for the blueocean display URL plugin that will not generate a blue URL to matrix projects. But yes, there is an option to disable the behaviour on the user profile coming soon.

          James Dumay added a comment -

          There is a fix in the next version of the plugin. Release is a week away.

          James Dumay added a comment - There is a fix in the next version of the plugin. Release is a week away.

          Thanks for the quick response!

          Leandro Lucarella added a comment - Thanks for the quick response!

          FYI, I can't disable the "BlueOcean Display URL" plugin without also disabling the "BlueOcean beta" plugin

          Leandro Lucarella added a comment - FYI, I can't disable the "BlueOcean Display URL" plugin without also disabling the "BlueOcean beta" plugin

          James Dumay added a comment -

          lucasocio the BlueOcean beta plugin is just an aggregator - disabling it wont break blue ocean.

          James Dumay added a comment - lucasocio the BlueOcean beta plugin is just an aggregator - disabling it wont break blue ocean.

          Code changed in jenkins
          User: James Dumay
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/blueoceandisplayurl/BlueOceanDisplayURLImpl.java
          http://jenkins-ci.org/commit/blueocean-display-url-plugin/f67ea827eb8520be77d5a07f9623600756fd003f
          Log:
          JENKINS-40446 Links broken in GitHub status for matrix projects

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: James Dumay Path: pom.xml src/main/java/org/jenkinsci/plugins/blueoceandisplayurl/BlueOceanDisplayURLImpl.java http://jenkins-ci.org/commit/blueocean-display-url-plugin/f67ea827eb8520be77d5a07f9623600756fd003f Log: JENKINS-40446 Links broken in GitHub status for matrix projects

          Code changed in jenkins
          User: James Dumay
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/blueoceandisplayurl/BlueOceanDisplayURLImpl.java
          http://jenkins-ci.org/commit/blueocean-display-url-plugin/983465ef14544ce8afc9f429097d7add80d9f872
          Log:
          JENKINS-40446 Links broken in GitHub status for matrix projects

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: James Dumay Path: pom.xml src/main/java/org/jenkinsci/plugins/blueoceandisplayurl/BlueOceanDisplayURLImpl.java http://jenkins-ci.org/commit/blueocean-display-url-plugin/983465ef14544ce8afc9f429097d7add80d9f872 Log: JENKINS-40446 Links broken in GitHub status for matrix projects

          Code changed in jenkins
          User: James William Dumay
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/blueoceandisplayurl/BlueOceanDisplayURLImpl.java
          http://jenkins-ci.org/commit/blueocean-display-url-plugin/b69894665fccd09a2f9d84566ab91d3d1cd5fe1b
          Log:
          JENKINS-40446 Links broken in GitHub status for matrix projects (#3)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: James William Dumay Path: pom.xml src/main/java/org/jenkinsci/plugins/blueoceandisplayurl/BlueOceanDisplayURLImpl.java http://jenkins-ci.org/commit/blueocean-display-url-plugin/b69894665fccd09a2f9d84566ab91d3d1cd5fe1b Log: JENKINS-40446 Links broken in GitHub status for matrix projects (#3)

          BTW, I'm trying this again on beta 18 and sadly it is still broken. Links put in GitHub statuses are still broken. Same if you want to access a project URL directly (https://jenkins/blue/organizations/jenkins/thefolder%2Ftheproject) following the original example. It just shows a regular blueocean project but with no branches or PRs, all empty, and no redirection is performed.

          As it is, blueocean links are still unusable with matrix jobs and makes github statuses links unusable.

          Leandro Lucarella added a comment - BTW, I'm trying this again on beta 18 and sadly it is still broken. Links put in GitHub statuses are still broken. Same if you want to access a project URL directly ( https://jenkins/blue/organizations/jenkins/thefolder%2Ftheproject ) following the original example. It just shows a regular blueocean project but with no branches or PRs, all empty, and no redirection is performed. As it is, blueocean links are still unusable with matrix jobs and makes github statuses links unusable.

          Ah, sorry, please see the previous comment.

          Leandro Lucarella added a comment - Ah, sorry, please see the previous comment.

          James Dumay added a comment -

          lucasocio for new PRs is the link correct? Just upgrading the plugin won't change the existing links

          James Dumay added a comment - lucasocio for new PRs is the link correct? Just upgrading the plugin won't change the existing links

          Sorry, is not the GitHub status that has a wrong link, is e-mail and slack notifications.

          Should I create another issue?

          Leandro Lucarella added a comment - Sorry, is not the GitHub status that has a wrong link, is e-mail and slack notifications. Should I create another issue?

          James Dumay added a comment -

          lucasocio what versions of the following plugins do you have installed?

          • Blue Ocean beta
          • BlueOcean Display URL plugin
          • Display URL API

          James Dumay added a comment - lucasocio what versions of the following plugins do you have installed? Blue Ocean beta BlueOcean Display URL plugin Display URL API

          • io.jenkins.blueocean:blueocean:1.0.0-b19
          • org.jenkins-ci.plugins:blueocean-display-url:1.3
          • org.jenkins-ci.plugins:display-url-api:0.5

          Leandro Lucarella added a comment - io.jenkins.blueocean:blueocean:1.0.0-b19 org.jenkins-ci.plugins:blueocean-display-url:1.3 org.jenkins-ci.plugins:display-url-api:0.5

          James Dumay added a comment -

          lucasocio good news is that we had fixed this a few months back but had not released it. Ill do some more testing and get a release out shortly.

          James Dumay added a comment - lucasocio good news is that we had fixed this a few months back but had not released it. Ill do some more testing and get a release out shortly.

          James Dumay added a comment -

          This improvement will be shipping alongside beta 21 this week.

          James Dumay added a comment - This improvement will be shipping alongside beta 21 this week.

          Cool! Thanks!

          Leandro Lucarella added a comment - Cool! Thanks!

          James Dumay added a comment -

          You can grab these fixes from the Update Center right now by upgrading the Blue Ocean Display URL plugin to 1.4

          James Dumay added a comment - You can grab these fixes from the Update Center right now by upgrading the Blue Ocean Display URL plugin to 1.4

          I can confirm now matrix job links works well with both slack and e-mail notifications. Thanks!!!

          Leandro Lucarella added a comment - I can confirm now matrix job links works well with both slack and e-mail notifications. Thanks!!!

          James Dumay added a comment -

          Awesome! Thanks for waiting out the fix

          James Dumay added a comment - Awesome! Thanks for waiting out the fix

            jamesdumay James Dumay
            lucasocio Leandro Lucarella
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: