Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40487

OPTIMIZATION: Pre-load Run data on fresh load of the Run Details

    XMLWordPrintable

    Details

    • Similar Issues:
    • Epic Link:
    • Sprint:
      arctic, tasman, frank, tethys

      Description

      Prefetch and embed the Run object on the Run Details page.

      Process should be to create a RESTFetchPreloader implementation that checks the current url to see if it links to a pipeline run details page and adds the Run object data if it is. See PipelineStatePreloader.

      In Scope

      • This data is attached to the $.blueOceanConfig object
      • When the page loads the data is injected into the store
      • We never have to do a XHR when loading the run details

        Attachments

          Issue Links

          depends on

          Task - A task that needs to be done. JENKINS-39625 OPTIMIZATION: Pre-load Runs on pipeline activity page

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          is related to

          Task - A task that needs to be done. JENKINS-40941 OPTIMIZATION: Pre-load /steps and /nodes REST calls on run details page

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

            Activity

            Ascending order - Click to sort in descending order
            tfennelly Tom FENNELLY created issue -
            tfennelly Tom FENNELLY made changes -
            Field Original Value New Value
            Epic Link JENKINS-37957 [ 174099 ]
            tfennelly Tom FENNELLY made changes -
            Link This issue depends on JENKINS-39625 [ JENKINS-39625 ]
            tfennelly Tom FENNELLY made changes -
            Description On a fresh load of the run details we want to avoid fetching the pipeline's run.

            Note: What we're talking about here is when the user goes directly to the Run Details page e.g. from a notification of some sort (e.g. an email). We're not talking about "normal" navigation to the Run Details page.

            *In Scope*
            * This data is attached to the {{$.blueOceanConfig}} object
            * When the page loads the data is injected into the store
            * We never have to do a XHR when loading the run details             		Prefetch and embed the Run object on the Run Details page.

            Process should be to create a [RESTFetchPreloader|https://github.com/jenkinsci/blueocean-plugin/blob/master/blueocean-commons/src/main/java/io/jenkins/blueocean/commons/RESTFetchPreloader.java] implementation that checks the current url to see if it links to a pipeline run details page and adds the Run object data if it is. See [PipelineStatePreloader|https://github.com/jenkinsci/blueocean-plugin/blob/master/blueocean-dashboard/src/main/java/io/jenkins/blueocean/preload/PipelineStatePreloader.java].
            tfennelly Tom FENNELLY made changes -
            Description Prefetch and embed the Run object on the Run Details page.

            Process should be to create a [RESTFetchPreloader|https://github.com/jenkinsci/blueocean-plugin/blob/master/blueocean-commons/src/main/java/io/jenkins/blueocean/commons/RESTFetchPreloader.java] implementation that checks the current url to see if it links to a pipeline run details page and adds the Run object data if it is. See [PipelineStatePreloader|https://github.com/jenkinsci/blueocean-plugin/blob/master/blueocean-dashboard/src/main/java/io/jenkins/blueocean/preload/PipelineStatePreloader.java].             		Prefetch and embed the Run object on the Run Details page.

            Process should be to create a [RESTFetchPreloader|https://github.com/jenkinsci/blueocean-plugin/blob/master/blueocean-commons/src/main/java/io/jenkins/blueocean/commons/RESTFetchPreloader.java] implementation that checks the current url to see if it links to a pipeline run details page and adds the Run object data if it is. See [PipelineStatePreloader|https://github.com/jenkinsci/blueocean-plugin/blob/master/blueocean-dashboard/src/main/java/io/jenkins/blueocean/preload/PipelineStatePreloader.java].

            *In Scope*
            * This data is attached to the {{$.blueOceanConfig}} object
            * When the page loads the data is injected into the store
            * We never have to do a XHR when loading the run details
            jamesdumay James Dumay made changes -
            Attachment blueocean #528 2016-12-16 13-27-48.png [ 35200 ]
            Hide
            Permalink
            jamesdumay James Dumay added a comment - - edited

            Tom FENNELLY I think we might have to prefetch the Pipeline that the run belongs to as well as the run. See screenshot.

            Show
            jamesdumay James Dumay added a comment - - edited Tom FENNELLY I think we might have to prefetch the Pipeline that the run belongs to as well as the run. See screenshot.
            Hide
            Permalink
            tfennelly Tom FENNELLY added a comment -

            And Favorites too I think.

            Show
            tfennelly Tom FENNELLY added a comment - And Favorites too I think.
            jamesdumay James Dumay made changes -
            Sprint arctic, tasman, frank [ 131, 136, 156 ] arctic, tasman, frank, christmas [ 131, 136, 156, 176 ]
            jamesdumay James Dumay made changes -
            Sprint arctic, tasman, frank, christmas [ 131, 136, 156, 176 ] arctic, tasman, frank, tethys [ 131, 136, 156, 161 ]
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Priority Minor [ 4 ] Major [ 3 ]
            tfennelly Tom FENNELLY made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            tfennelly Tom FENNELLY made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            Hide
            Permalink
            tfennelly Tom FENNELLY added a comment - - edited

            PR: https://github.com/jenkinsci/blueocean-plugin/pull/690

            Show
            tfennelly Tom FENNELLY added a comment - - edited PR: https://github.com/jenkinsci/blueocean-plugin/pull/690
            Hide
            Permalink
            tfennelly Tom FENNELLY added a comment - - edited

            Have this specific optimization on the above linked PR. Also added 2 others while I was at it.

            Not going to do any more on this for now (need to work/help on other issues). There are others too that we could do for MBP branch run details pages. I'll add a JIRA for that (JENKINS-40941).

            Show
            tfennelly Tom FENNELLY added a comment - - edited Have this specific optimization on the above linked PR. Also added 2 others while I was at it. Not going to do any more on this for now (need to work/help on other issues). There are others too that we could do for MBP branch run details pages. I'll add a JIRA for that ( JENKINS-40941 ).
            tfennelly Tom FENNELLY made changes -
            Link This issue is related to JENKINS-40941 [ JENKINS-40941 ]
            tfennelly Tom FENNELLY made changes -
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]
            Hide
            Permalink
            jamesdumay James Dumay added a comment -

            Nice one Tom FENNELLY

            Show
            jamesdumay James Dumay added a comment - Nice one Tom FENNELLY

              People

              Assignee:
              tfennelly Tom FENNELLY
              Reporter:
              tfennelly Tom FENNELLY
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: