Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40566

Allow non-admins ability to cancel or abort builds when using "GitHub Committer Authorization Strategy"

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • github-oauth-plugin
    • None
    • Jenkins ver. 2.19.2
      GitHub OAuth Plugin Version 0.25

      There appears to be no option when using the Github Authentication Plugin Security Realm and the GitHub Committer Authorization Strategy Authorization to allow non-admins to cancel a scheduled, or abort a running, build.

      This poses a problem where (in a large organization with thousands of builds) admins are constantly pinged if a build is stuck and needs to be forcibly aborted.

          [JENKINS-40566] Allow non-admins ability to cancel or abort builds when using "GitHub Committer Authorization Strategy"

          Ashok Manji created issue -

          Sam Gleske added a comment - - edited

          I agree with you on this sentiment. When I took over this plugin it has always been a part of it that has been sorely lacking. I plan to revamp the permissions and set them up so that a user can choose what permissions anybody gets in Jenkins based on their access in GitHub (think similar to the matrix-based authorization strategy).

          For now, as a workaround. I highly recommend making use of the matrix-based authorization strategies. I personally use the Job DSL plugin and the project matrix-based authorization strategy in a large Jenkins installation (~600+ users with ~1300+ jobs). For now, that works for me. However, I agree that part of the GitHub authentication plugin needs some love.

          I'll use this issue to track enhancing this feature.

          See also https://wiki.jenkins-ci.org/display/JENKINS/GitHub+OAuth+Plugin#GitHubOAuthPlugin-MatrixbasedAuthorizationstrategy

          Sam Gleske added a comment - - edited I agree with you on this sentiment. When I took over this plugin it has always been a part of it that has been sorely lacking. I plan to revamp the permissions and set them up so that a user can choose what permissions anybody gets in Jenkins based on their access in GitHub (think similar to the matrix-based authorization strategy). For now, as a workaround. I highly recommend making use of the matrix-based authorization strategies. I personally use the Job DSL plugin and the project matrix-based authorization strategy in a large Jenkins installation (~600+ users with ~1300+ jobs). For now, that works for me. However, I agree that part of the GitHub authentication plugin needs some love. I'll use this issue to track enhancing this feature. See also https://wiki.jenkins-ci.org/display/JENKINS/GitHub+OAuth+Plugin#GitHubOAuthPlugin-MatrixbasedAuthorizationstrategy
          Sam Gleske made changes -
          Link New: This issue relates to JENKINS-27844 [ JENKINS-27844 ]
          Sam Gleske made changes -
          Link New: This issue relates to JENKINS-33661 [ JENKINS-33661 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: John Maguire
          Path:
          src/main/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACL.java
          src/main/webapp/help/auth/use-repository-permissions-help.html
          src/test/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACLTest.java
          http://jenkins-ci.org/commit/github-oauth-plugin/056917638fad1c89a113fd1ab9ebb4293523953b
          Log:
          JENKINS-40566 - Allow collaborators to cancel/abort a build

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: John Maguire Path: src/main/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACL.java src/main/webapp/help/auth/use-repository-permissions-help.html src/test/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACLTest.java http://jenkins-ci.org/commit/github-oauth-plugin/056917638fad1c89a113fd1ab9ebb4293523953b Log: JENKINS-40566 - Allow collaborators to cancel/abort a build

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Sam Gleske
          Path:
          src/main/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACL.java
          src/main/webapp/help/auth/use-repository-permissions-help.html
          src/test/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACLTest.java
          http://jenkins-ci.org/commit/github-oauth-plugin/05313d07327f3efdd9831f7492a6b38e072e4db9
          Log:
          Merge pull request #81 from johnjmaguire/master

          JENKINS-40566 Allow collaborators to cancel/abort a build

          Compare: https://github.com/jenkinsci/github-oauth-plugin/compare/4aea81453f45...05313d07327f

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Gleske Path: src/main/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACL.java src/main/webapp/help/auth/use-repository-permissions-help.html src/test/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACLTest.java http://jenkins-ci.org/commit/github-oauth-plugin/05313d07327f3efdd9831f7492a6b38e072e4db9 Log: Merge pull request #81 from johnjmaguire/master JENKINS-40566 Allow collaborators to cancel/abort a build Compare: https://github.com/jenkinsci/github-oauth-plugin/compare/4aea81453f45...05313d07327f

          Sam Gleske added a comment -

          0.27 released https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/github-oauth/0.27/github-oauth-0.27.hpi

          Sam Gleske added a comment - 0.27 released https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/github-oauth/0.27/github-oauth-0.27.hpi
          Sam Gleske made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          Ashok Manji added a comment -

          LGTM. Thanks!

          Ashok Manji added a comment - LGTM. Thanks!
          Ashok Manji made changes -
          Status Original: Resolved [ 5 ] New: Closed [ 6 ]

            sag47 Sam Gleske
            ashokm Ashok Manji
            Votes:
            2 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: