[JENKINS-40594] submitterParameter does not work without at least one actual parameter - Jenkins Jira

XML

Word

Printable

Details

Type: Bug
Status: Resolved (View Workflow)
Priority: Critical
Resolution: Fixed
Component/s: pipeline-input-step-plugin
Labels:
None

Similar Issues:

Show

Description

Hello,

According to the documentation I should be able to do the following:

def ret = input(message: 'some message', submitterParameter: 'username_approval')
println(ret['username_approval'])

However I only receive a null object instead of the expected map.

Regards,

Attachments

Issue Links

is blocking

JENKINS-31396 Access to submitter ID from return value of input step

Resolved

is duplicated by

JENKINS-42897 input step can return a null when approved via link in console output

Resolved

links to

PR 13

Activity

Ascending order - Click to sort in descending order

Adam Cecile created issue - 2016-12-21 11:51

Adam Cecile made changes - 2016-12-21 11:51

Field	Original Value	New Value
Description	Hello, According to the documentation I should be able to do the following: {{ def ret = input(message: 'some message', submitterParameter: 'username_approval') println(ret['username_approval']) }} However I only receive a null object instead of the expected map. Regards,	Hello, According to the documentation I should be able to do the following: {{def ret = input(message: 'some message', submitterParameter: 'username_approval') println(ret['username_approval'])}} However I only receive a null object instead of the expected map. Regards,

Adam Cecile made changes - 2016-12-21 11:51

Description

Hello,

According to the documentation I should be able to do the following:

{{def ret = input(message: 'some message', submitterParameter: 'username_approval')
println(ret['username_approval'])}}

However I only receive a null object instead of the expected map.

Regards,

Hello,

According to the documentation I should be able to do the following:

def ret = input(message: 'some message', submitterParameter: 'username_approval')
println(ret['username_approval'])

However I only receive a null object instead of the expected map.

Regards,

Scott Lillibridge added a comment - 2016-12-22 22:15

To add more information, I am seeing this same issue. I am only able to access submitterParameter if I also include parameters. Using the workflow defined in the test test_submitter_parameter_no_submitter() I see the following behavior:

Pipeline:

def x = input message:'Do you want chocolate?', id:'Icecream', ok: 'Purchase icecream', submitterParameter: 'approval'
echo("after: ${x}")
def y = input message:'Do you want chocolate?', id:'Icecream', ok: 'Purchase icecream', submitterParameter: 'approval', parameters: [string(defaultValue: 'herp', description: '', name: 'derp')]
echo("after: " + y['approval'])

Output:

Started by user Scott Lillibridge
[Pipeline] input
Do you want chocolate?
Purchase icecream or Abort
Approved by Scott Lillibridge
[Pipeline] echo
after: null
[Pipeline] input
Input requested
Approved by Scott Lillibridge
[Pipeline] echo
after: scott.lillibridge
[Pipeline] End of Pipeline
Finished: SUCCESS

Is there a different way to access the submitterParameter without including parameters?

Versions/Environment:

Jenkins 2.36 (rpm installed from the jenkins-ci repository)
Pipeline Input Step 2.5
openjdk version "1.8.0_111"
OpenJDK Runtime Environment (build 1.8.0_111-b15)
OpenJDK 64-Bit Server VM (build 25.111-b15, mixed mode)

Scott Lillibridge added a comment - 2016-12-22 22:15 To add more information, I am seeing this same issue. I am only able to access submitterParameter if I also include parameters. Using the workflow defined in the test test_submitter_parameter_no_submitter() I see the following behavior: Pipeline: def x = input message: 'Do you want chocolate?' , id: 'Icecream' , ok: 'Purchase icecream' , submitterParameter: 'approval' echo( "after: ${x}" ) def y = input message: 'Do you want chocolate?' , id: 'Icecream' , ok: 'Purchase icecream' , submitterParameter: 'approval' , parameters: [string(defaultValue: 'herp' , description: '', name: ' derp')] echo( "after: " + y[ 'approval' ]) Output: Started by user Scott Lillibridge [Pipeline] input Do you want chocolate? Purchase icecream or Abort Approved by Scott Lillibridge [Pipeline] echo after: null [Pipeline] input Input requested Approved by Scott Lillibridge [Pipeline] echo after: scott.lillibridge [Pipeline] End of Pipeline Finished: SUCCESS Is there a different way to access the submitterParameter without including parameters? Versions/Environment: Jenkins 2.36 (rpm installed from the jenkins-ci repository) Pipeline Input Step 2.5 openjdk version "1.8.0_111" OpenJDK Runtime Environment (build 1.8.0_111-b15) OpenJDK 64-Bit Server VM (build 25.111-b15, mixed mode)

Kuber Kaul added a comment - 2017-02-28 16:42

Facing the same issue - Jenkins version - 2.44 , Pipeline Input Step 2.5 .

Kuber Kaul added a comment - 2017-02-28 16:42 Facing the same issue - Jenkins version - 2.44 , Pipeline Input Step 2.5 .

Kuber Kaul added a comment - 2017-02-28 16:43

It seems necessary to include at least one custom parameter. For example this will work:

def inputResponse = input(message: 'Should we proceed', submitter: "myorg*myteam", submitterParameter: 'approver', parameters:[booleanParam(defaultValue: false, description: '', name: 'promote')] )

But the more sensible simplification returns null:

def inputResponse = input(message: 'Should we proceed', submitter: "myorg*myteam", submitterParameter: 'approver' )

Kuber Kaul added a comment - 2017-02-28 16:43 It seems necessary to include at least one custom parameter. For example this will work: def inputResponse = input(message: 'Should we proceed' , submitter: "myorg*myteam" , submitterParameter: 'approver' , parameters:[booleanParam(defaultValue: false , description: '', name: ' promote')] ) But the more sensible simplification returns null: def inputResponse = input(message: 'Should we proceed' , submitter: "myorg*myteam" , submitterParameter: 'approver' )

Kuber Kaul made changes - 2017-02-28 16:43

Link

This issue is blocking ~~JENKINS-31396~~ [ ~~JENKINS-31396~~ ]

Kuber Kaul made changes - 2017-02-28 16:45

Assignee

Jesse Glick [ jglick ]

Jesse Glick made changes - 2017-02-28 17:52

Summary

submitterParameter returns nothing

submitterParameter does not work without at least one actual parameter

Jesse Glick made changes - 2017-02-28 17:52

Assignee

Jesse Glick [ jglick ]

Kuber Kaul made changes - 2017-02-28 18:19

Labels

pipeline-input

Kuber Kaul made changes - 2017-02-28 18:19

Priority

Minor [ 4 ]

Critical [ 2 ]

John Hovell made changes - 2017-02-28 19:15

Comment

[ I realize this is a bit off topic but is there a separate issue for having a feature to just add a new repository (or delete a no longer needed repo) by name instead of needing to scan the entire org to pick up a new repo? I feel like this would eliminate 99% of the use cases to need to scan the organization at all. Thanks! ]

John Hovell added a comment - 2017-02-28 19:17 - edited

Sorry just commented on incorrect ticket. Confirmed this behavior is what I see as well in 2.5 of input step plugin.

John Hovell added a comment - 2017-02-28 19:17 - edited Sorry just commented on incorrect ticket. Confirmed this behavior is what I see as well in 2.5 of input step plugin.

Jesse Glick made changes - 2017-04-24 15:31

Link

This issue is duplicated by ~~JENKINS-42897~~ [ ~~JENKINS-42897~~ ]

Jesse Glick added a comment - 2017-04-24 15:32

PR 13 may be fixing this.

Jesse Glick added a comment - 2017-04-24 15:32 PR 13 may be fixing this.

Jesse Glick made changes - 2017-04-24 15:32

Remote Link

This issue links to "PR 13 (Web Link)" [ 16300 ]

Jesse Glick made changes - 2017-04-24 15:32

Labels

pipeline-input

Kun Tang made changes - 2017-04-24 18:29

Assignee

Kun Tang [ tangkun75 ]

Kun Tang added a comment - 2017-04-24 18:31

I've updated the changes for this issue. Please review it.

Kun Tang added a comment - 2017-04-24 18:31 I've updated the changes for this issue. Please review it.

Kun Tang made changes - 2017-04-24 18:31

Status

Open [ 1 ]

In Progress [ 3 ]

Jesse Glick made changes - 2017-04-24 19:08

Status

In Progress [ 3 ]

In Review [ 10005 ]

Jesse Glick made changes - 2017-04-27 01:11

Resolution		Fixed [ 1 ]
Status	In Review [ 10005 ]	Resolved [ 5 ]

SCM/JIRA link daemon added a comment - 2017-04-27 01:11

Code changed in jenkins
User: Kun Tang
Path:
src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java
http://jenkins-ci.org/commit/pipeline-input-step-plugin/db8641f197b171e5ca94190ceb43e43f3103ea83
Log:
~~JENKINS-40594~~
submitterParameter does not work without at least one actual parameter

SCM/JIRA link daemon added a comment - 2017-04-27 01:11 Code changed in jenkins User: Kun Tang Path: src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java http://jenkins-ci.org/commit/pipeline-input-step-plugin/db8641f197b171e5ca94190ceb43e43f3103ea83 Log: JENKINS-40594 submitterParameter does not work without at least one actual parameter

SCM/JIRA link daemon added a comment - 2017-04-27 01:12

Code changed in jenkins
User: Kun Tang
Path:
src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java
src/test/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepTest.java
http://jenkins-ci.org/commit/pipeline-input-step-plugin/c31b370008145e91e8900db7264d3c6087f79ef7
Log:
Update a test and add @Issue annotation for ~~JENKINS-40594~~

SCM/JIRA link daemon added a comment - 2017-04-27 01:12 Code changed in jenkins User: Kun Tang Path: src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java src/test/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepTest.java http://jenkins-ci.org/commit/pipeline-input-step-plugin/c31b370008145e91e8900db7264d3c6087f79ef7 Log: Update a test and add @Issue annotation for JENKINS-40594

People

Assignee:: Kun Tang

Reporter:: Adam Cecile

Votes:: 5 Vote for this issue

Watchers:: 12 Start watching this issue

Dates

Created:: 2016-12-21 11:51

Updated:: 2017-04-27 01:12

Resolved:: 2017-04-27 01:11