Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40719

Add support for email-ext-plugin config files

    XMLWordPrintable

Details

    Description

      Please add support for managing the email-ext config file types, GroovyTemplateConfigProvider and JellyTemplateConfigProvider, via job-dsl.

      These are used for ${SCRIPT, script="managed:script-name"} and ${JELLY_SCRIPT, html="managed:script-name"}

      These would complement the already existing support for the CustomConfigProvider which is used for ${TEMPLATE, file="managed:template-name"}

      Attachments

        Issue Links

          Activity

            glance Anton Lundin created issue -
            glance Anton Lundin made changes -
            Field Original Value New Value
            Issue Type Bug [ 1 ] Improvement [ 4 ]

            email-ext needs to be update to config-file-provider 2.15+ before this can be implemented.

            daspilker Daniel Spilker added a comment - email-ext needs to be update to config-file-provider 2.15+ before this can be implemented.
            daspilker Daniel Spilker made changes -
            Link This issue is blocked by JENKINS-40964 [ JENKINS-40964 ]

            I've started to work on this: https://github.com/jenkinsci/job-dsl-plugin/pull/984

            Feedback is welcome.

            daspilker Daniel Spilker added a comment - I've started to work on this: https://github.com/jenkinsci/job-dsl-plugin/pull/984 Feedback is welcome.

            Code changed in jenkins
            User: Daniel Spilker
            Path:
            docs/Home.md
            docs/Job-DSL-Commands.md
            job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/AbstractDslScriptLoader.groovy
            job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/DslFactory.groovy
            job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/DslScriptLoader.groovy
            job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/JobParent.groovy
            job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/ConfigFilesContext.groovy
            job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/ExecuteDslScripts.java
            job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/JenkinsDslScriptLoader.java
            job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/JenkinsJobParent.groovy
            job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/structs/DescribableListContext.groovy
            job-dsl-plugin/src/test/groovy/javaposse/jobdsl/plugin/ExecuteDslScriptsSpec.groovy
            job-dsl-plugin/src/test/resources/javaposse/jobdsl/plugin/configFiles.groovy
            http://jenkins-ci.org/commit/job-dsl-plugin/b7fcc87cbe8d25beb9d85d525c136ffba4c6473a
            Log:
            use automatically generated DSL to create config files

            [FIXES JENKINS-39754]
            [FIXES JENKINS-40719]

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Spilker Path: docs/Home.md docs/Job-DSL-Commands.md job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/AbstractDslScriptLoader.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/DslFactory.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/DslScriptLoader.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/JobParent.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/ConfigFilesContext.groovy job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/ExecuteDslScripts.java job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/JenkinsDslScriptLoader.java job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/JenkinsJobParent.groovy job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/structs/DescribableListContext.groovy job-dsl-plugin/src/test/groovy/javaposse/jobdsl/plugin/ExecuteDslScriptsSpec.groovy job-dsl-plugin/src/test/resources/javaposse/jobdsl/plugin/configFiles.groovy http://jenkins-ci.org/commit/job-dsl-plugin/b7fcc87cbe8d25beb9d85d525c136ffba4c6473a Log: use automatically generated DSL to create config files [FIXES JENKINS-39754] [FIXES JENKINS-40719]

            Code changed in jenkins
            User: Daniel Spilker
            Path:
            docs/Home.md
            docs/Job-DSL-Commands.md
            docs/Migration.md
            job-dsl-api-viewer/src/assets/javascripts/Dsl.js
            job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/AbstractDslScriptLoader.groovy
            job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/ConfigFile.groovy
            job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/ConfigFileType.groovy
            job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/DslFactory.groovy
            job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/DslScriptLoader.groovy
            job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/JobManagement.groovy
            job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/JobParent.groovy
            job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/MavenSettingsConfigFile.groovy
            job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/MemoryJobManagement.groovy
            job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/MockJobManagement.groovy
            job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/NoDoc.java
            job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/ParametrizedConfigFile.groovy
            job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/doc/ApiDocGenerator.groovy
            job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/ConfigFilesContext.groovy
            job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/step/MavenContext.groovy
            job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/step/StepContext.groovy
            job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/wrapper/ConfigFilesContext.groovy
            job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/jobs/MavenJob.groovy
            job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/JobParentSpec.groovy
            job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/step/StepContextSpec.groovy
            job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/wrapper/WrapperContextSpec.groovy
            job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/jobs/MavenJobSpec.groovy
            job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/ConfigFileProviderHelper.groovy
            job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/ExecuteDslScripts.java
            job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/JenkinsDslScriptLoader.java
            job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/JenkinsJobManagement.java
            job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/JenkinsJobParent.groovy
            job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/structs/DescribableListContext.groovy
            job-dsl-plugin/src/test/groovy/javaposse/jobdsl/plugin/ExecuteDslScriptsSpec.groovy
            job-dsl-plugin/src/test/resources/javaposse/jobdsl/plugin/configFiles.groovy
            http://jenkins-ci.org/commit/job-dsl-plugin/224523422c476ed23f8fbc2ce30b488767e71753
            Log:
            Merge pull request #984 from daspilker/JENKINS-40719

            new syntax for creating config files

            Compare: https://github.com/jenkinsci/job-dsl-plugin/compare/877e860ea3d8...224523422c47

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Spilker Path: docs/Home.md docs/Job-DSL-Commands.md docs/Migration.md job-dsl-api-viewer/src/assets/javascripts/Dsl.js job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/AbstractDslScriptLoader.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/ConfigFile.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/ConfigFileType.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/DslFactory.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/DslScriptLoader.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/JobManagement.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/JobParent.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/MavenSettingsConfigFile.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/MemoryJobManagement.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/MockJobManagement.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/NoDoc.java job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/ParametrizedConfigFile.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/doc/ApiDocGenerator.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/ConfigFilesContext.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/step/MavenContext.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/step/StepContext.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/wrapper/ConfigFilesContext.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/jobs/MavenJob.groovy job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/JobParentSpec.groovy job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/step/StepContextSpec.groovy job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/wrapper/WrapperContextSpec.groovy job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/jobs/MavenJobSpec.groovy job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/ConfigFileProviderHelper.groovy job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/ExecuteDslScripts.java job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/JenkinsDslScriptLoader.java job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/JenkinsJobManagement.java job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/JenkinsJobParent.groovy job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/structs/DescribableListContext.groovy job-dsl-plugin/src/test/groovy/javaposse/jobdsl/plugin/ExecuteDslScriptsSpec.groovy job-dsl-plugin/src/test/resources/javaposse/jobdsl/plugin/configFiles.groovy http://jenkins-ci.org/commit/job-dsl-plugin/224523422c476ed23f8fbc2ce30b488767e71753 Log: Merge pull request #984 from daspilker/ JENKINS-40719 new syntax for creating config files Compare: https://github.com/jenkinsci/job-dsl-plugin/compare/877e860ea3d8...224523422c47
            daspilker Daniel Spilker made changes -
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]
            glance Anton Lundin added a comment -

            I took a look at the code and I couldn't really figure out how to for example configure a GroovyTemplateConfigProvider-file.

            Could you clarify that for me or even add an example to the documentation?

            glance Anton Lundin added a comment - I took a look at the code and I couldn't really figure out how to for example configure a GroovyTemplateConfigProvider-file. Could you clarify that for me or even add an example to the documentation?

            This is implemented with the Automatically Generated DSL, so it's not visible in the code. But the embedded API viewer will show the syntax.

            configFiles {
              groovyTemplateConfig {
                id(String value)
                name(String value)
                comment(String value)
                content(String value)
              } 
            }
            
            daspilker Daniel Spilker added a comment - This is implemented with the Automatically Generated DSL , so it's not visible in the code. But the embedded API viewer will show the syntax. configFiles { groovyTemplateConfig { id( String value) name( String value) comment( String value) content( String value) } }
            glance Anton Lundin added a comment -

            Cool. Thank you.

            glance Anton Lundin added a comment - Cool. Thank you.
            daspilker Daniel Spilker made changes -
            Status Resolved [ 5 ] Closed [ 6 ]

            People

              daspilker Daniel Spilker
              glance Anton Lundin
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: