Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40755

Settings link appears when user does not have edit permissions

    XMLWordPrintable

Details

    • tethys, pannonian, iapetus

    Description

      We need to check if the current user has the edit permission when choosing to display the cog icon on the result screen.

      In Scope

      • Audit all the locations where we show the settings link to ensure that that they honour the edit permission
      • update any that do not honour the edit permission

      Attachments

        1. 1.png
          1.png
          73 kB
        2. 2.png
          2.png
          68 kB

        Activity

          jamesdumay James Dumay created issue -
          jamesdumay James Dumay made changes -
          Field Original Value New Value
          Epic Link JENKINS-35750 [ 171713 ]
          jamesdumay James Dumay made changes -
          Rank Ranked higher
          jamesdumay James Dumay made changes -
          Rank Ranked higher
          jamesdumay James Dumay made changes -
          Sprint kraken [ 166 ] release candidate [ 171 ]
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Sprint release candidate [ 171 ] tethys [ 161 ]
          jamesdumay James Dumay made changes -
          Rank Ranked higher
          jamesdumay James Dumay made changes -
          Description We need to check if the current user has the edit permission when choosing to display the cog icon on the result screen. We need to check if the current user has the edit permission when choosing to display the cog icon on the result screen.

          *In Scope*
          * Audit all the locations where we show the settings link to ensure that that they honour the edit permission
          * update any that do not honour the edit permission
          jamesdumay James Dumay added a comment -

          michaelneale I think its only fair that you get to fix this one

          jamesdumay James Dumay added a comment - michaelneale I think its only fair that you get to fix this one
          jamesdumay James Dumay made changes -
          Assignee Ivan Meredith [ imeredith ] Michael Neale [ michaelneale ]
          jamesdumay James Dumay made changes -
          Sprint tethys [ 161 ] tethys, pannonian [ 161, 211 ]
          jamesdumay James Dumay made changes -
          Assignee Michael Neale [ michaelneale ] Thorsten Scherler [ tscherler ]
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Assignee Thorsten Scherler [ tscherler ] Tom FENNELLY [ tfennelly ]
          jamesdumay James Dumay made changes -
          Rank Ranked higher
          tfennelly Tom FENNELLY made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          tfennelly Tom FENNELLY made changes -
          Status In Progress [ 3 ] Open [ 1 ]
          jamesdumay James Dumay made changes -
          Sprint tethys, pannonian [ 161, 211 ] tethys, pannonian, iapetus [ 161, 211, 216 ]
          tfennelly Tom FENNELLY made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          tfennelly Tom FENNELLY added a comment -

          Hmmm ... need to talk to vivek about this. We need some way of checking a user permission on a domain object. I don't see that there atm.

          tfennelly Tom FENNELLY added a comment - Hmmm ... need to talk to vivek about this. We need some way of checking a user permission on a domain object. I don't see that there atm.
          tfennelly Tom FENNELLY added a comment -

          And I'm not sure adding user/requester specific data onto the side of these domain object REST responses would be very restful as it it would make them uncacheable etc.

          tfennelly Tom FENNELLY added a comment - And I'm not sure adding user/requester specific data onto the side of these domain object REST responses would be very restful as it it would make them uncacheable etc.
          tfennelly Tom FENNELLY made changes -
          Status In Progress [ 3 ] Open [ 1 ]
          tfennelly Tom FENNELLY made changes -
          Rank Ranked lower
          tfennelly Tom FENNELLY made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          tfennelly Tom FENNELLY made changes -
          Rank Ranked higher
          tfennelly Tom FENNELLY made changes -
          Status In Progress [ 3 ] In Review [ 10005 ]
          tfennelly Tom FENNELLY added a comment - https://github.com/jenkinsci/blueocean-plugin/pull/825
          tfennelly Tom FENNELLY made changes -
          Resolution Fixed [ 1 ]
          Status In Review [ 10005 ] Resolved [ 5 ]
          jbriden Jenn Briden made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

          People

            tfennelly Tom FENNELLY
            jamesdumay James Dumay
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: